Uh oh!
There was an error while loading. Please reload this page.
JIT: ensure fgFirstBB has appropriate flags - #40038
Merged
Merged
Conversation
This fixes an issue where release jits might sometimes generate bad GC info. Keeping it minimal for now so we can consider servicing preview 8. See dotnet#39023 for details.
AndyAyersMS
commented
Jul 28, 2020
MemberAuthor
@BruceForstall PTAL Don't expect codegen diffs, will run SPMI in rel/rel mode to see if it spots any GC info diffs. |
AndyAyersMS
commented
Jul 28, 2020
MemberAuthor
Arm build failure looks spurious: |
BruceForstall
approved these changes
Jul 28, 2020
AndyAyersMS
commented
Jul 28, 2020
MemberAuthor
No release-release SPMI diffs on tests.pmi.Windows_NT.x64.Release.mch, or on the sample code I had from #39023. Not surprising -- it is unclear how often / how many methods might be affected by this, and SPMI might alter the odds. |
AndyAyersMS
commented
Jul 28, 2020
MemberAuthor
Format patch file is empty, no changes when I reformat locally. |
BruceForstall
commented
Jul 28, 2020
Contributor
formatting: #40034 |
AndyAyersMS
commented
Jul 29, 2020
MemberAuthor
Pretty sure all these failures are unrelated. |
AndyAyersMS added a commit
to AndyAyersMS/runtime
that referenced
this pull request
Jul 29, 2020
Port of dotnet#40038 to Preview 8. Fixdotnet#39023 Release jits might sometimes generate bad GC info. Mysterious intermittent crashes. Without this fix jit GC info generation for some methods is non-deterministically bad. Yes, problem does not occur in 3.1. Very low.
This was referenced Jul 29, 2020
Jacksondr5 pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
This fixes an issue where release jits might sometimes generate bad GC info. Keeping it minimal for now so we can consider servicing preview 8. See dotnet#39023 for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where release jits might sometimes generate bad GC info.
Keeping it minimal for now so we can consider servicing preview 8.
See #39023 for details.