Uh oh!
There was an error while loading. Please reload this page.
Fix CoreLib build when building libraries solutions - #40097
Merged
Conversation
If a project that is part of solution has a ProjectReference to CoreLib, the Platform property was set to AnyCPU and CoreLib was built with the wrong Platform/Platform_Target.
ericstj
approved these changes
Jul 29, 2020
ericstj
left a comment
Member
There was a problem hiding this comment.
This seems OK. Double check that we don't need to clear the SetPlatform metadata, can't remember if that is something used anywhere.
ViktorHofer
commented
Jul 29, 2020
MemberAuthor
Yeah validated that. The output is now identical when building from a solution vs when building the corelib subset. |
jkotas
commented
Jul 29, 2020
Member
Would it make sense to print error in System.Private.CoreLib.csproj for AnyCPU Platform? |
ViktorHofer
commented
Jul 29, 2020
MemberAuthor
Yes will do that in a follow-up one. |
Jacksondr5 pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
If a project that is part of solution has a ProjectReference to CoreLib, the Platform property was set to AnyCPU and CoreLib was built with the wrong Platform/Platform_Target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a project that is part of solution has a ProjectReference to CoreLib, the Platform property was set to AnyCPU and CoreLib was built with the wrong Platform/Platform_Target.
Fixes#40073
cc @alnikola