Skip to content

Implement platform guards in OperatingSystem class - #40457

Merged
adamsitnik merged 13 commits into
dotnet:masterfrom
adamsitnik:implementOsChecks
Aug 7, 2020
Merged

Implement platform guards in OperatingSystem class#40457
adamsitnik merged 13 commits into
dotnet:masterfrom
adamsitnik:implementOsChecks

Conversation

@adamsitnik

@adamsitnikadamsitnik commented Aug 6, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Contributes to #40111
Fixes#40358

@Dotnet-GitSync-Bot

Dotnet-GitSync-Bot commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@Dotnet-GitSync-Bot

Dotnet-GitSync-Bot commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@adamsitnikadamsitnik added this to the 5.0.0 milestone Aug 6, 2020
jkotas
jkotas reviewed Aug 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs Outdated
jkotas
jkotas reviewed Aug 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs
jkotas
jkotas reviewed Aug 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs Outdated
jkotas
jkotas reviewed Aug 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs Outdated
adamsitnik
adamsitnik commented Aug 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs
terrajobst
terrajobst approved these changes Aug 6, 2020
View reviewed changes

@terrajobstterrajobst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsitnikadamsitnik mentioned this pull request Aug 6, 2020
Merged
eerhardt
eerhardt reviewed Aug 6, 2020
View reviewed changes
Comment threadsrc/coreclr/clr.featuredefines.props Outdated
@adamsitnik
adamsitnik requested a review from vargaz as a code ownerAugust 6, 2020 17:28
adamsitnik added a commit to adamsitnik/runtime that referenced this pull request Aug 6, 2020
@adamsitnik
delegate RuntimeInformation.IsOSPlatform to call OperatingSystem.IsOS…
1056230
…Platform. it won't compile now as the new guards have not been merged yet (dotnet#40457)
@hoyosjs

hoyosjs commented Aug 6, 2020

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Aug 6, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

danmoseley
danmoseley reviewed Aug 6, 2020
View reviewed changes
Comment threadsrc/libraries/System.Runtime.Extensions/tests/System/OperatingSystemTests.cs Outdated
@adamsitnik
adamsitnik merged commit c073e57 into dotnet:masterAug 7, 2020
@adamsitnik
adamsitnik deleted the implementOsChecks branch August 7, 2020 07:16
adamsitnik added a commit that referenced this pull request Aug 7, 2020
@adamsitnik
Remove new platform members from OSPlatform (#40373)
3ea278d
* Remove new platform members from OSPlatform
* remove IsOSPlatformEarlierThan and IsOSPlatformOrLater methods
* remove unused resource and dependency
* delegate RuntimeInformation.IsOSPlatform to call OperatingSystem.IsOSPlatform. it won't compile now as the new guards have not been merged yet (#40457)
* remove OSPlatform.Browser and it's usage
This was referenced Aug 7, 2020
Merged
Closed
Closed
Closed
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@adamsitnik@Jacksondr5
Implement platform guards in OperatingSystem class (dotnet#40457)
dbf6d45
* add Is$OsName methods to OperatingSystem class
* add OperatingSystem.*VersionAtLeast methods
* add IsOSPlatform and IsOSPlatformVersionAtLeast
* add xml comments
* address code review suggestions
* move TARGET_* defines to a common file
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@adamsitnik@Jacksondr5
Remove new platform members from OSPlatform (dotnet#40373)
b60dbbf
* Remove new platform members from OSPlatform
* remove IsOSPlatformEarlierThan and IsOSPlatformOrLater methods
* remove unused resource and dependency
* delegate RuntimeInformation.IsOSPlatform to call OperatingSystem.IsOSPlatform. it won't compile now as the new guards have not been merged yet (dotnet#40457)
* remove OSPlatform.Browser and it's usage
@ghostghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@eerhardteerhardteerhardt left review comments
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@buyaa-nbuyaa-nAwaiting requested review from buyaa-n
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@EgorBoEgorBoAwaiting requested review from EgorBo
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisok
@vargazvargazAwaiting requested review from vargaz
+2 more reviewers
@terrajobstterrajobstterrajobst approved these changes
@danmoseleydanmoseleydanmoseley left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtimenew-api-needs-documentation

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Implement OS checks

8 participants

@adamsitnik@Dotnet-GitSync-Bot@hoyosjs@marek-safar@terrajobst@danmoseley@jkotas@eerhardt