Uh oh!
There was an error while loading. Please reload this page.
Add nullability annotations to System.Private.Xml.Linq project - #40744
Conversation
ghost
commented
Aug 13, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| } | ||
| public virtual object Evaluate(string xpath, IXmlNamespaceResolver resolver) | ||
| public virtual object Evaluate(string xpath, IXmlNamespaceResolver? resolver) |
There was a problem hiding this comment.
should all resolvers above also be nullable?
There was a problem hiding this comment.
Yes, and also in other places where a IXmlNamespaceResolver is taken, not sure if everywhere but we should be able to take null in other cases, e.g:
The docs also mention that the param can be null https://docs.microsoft.com/dotnet/api/system.xml.xmlreader.readcontentas?view=netcore-3.1
There was a problem hiding this comment.
Do the other places IXmlNamespaceResolver is taken still need to be updated to be nulalble?
There was a problem hiding this comment.
XmlReader.ReadContentAs(Type, IXmlNamespaceResolver) is yet as not-nullable so I assume is the same for the other cases if they exists.
There was a problem hiding this comment.
I did a scan through the methods that can take IXmlNamespaceResolver and found a few ones that could be changed to IXmlNamespaceResolver?. I submitted #41079 with the changes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
66f7021 to
43ba8e1Compare
krwq
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing, please ensure build errors are fixed or known issues
jozkee
commented
Aug 20, 2020
CI issues are unrelated, see #41006. |
Contributes to #2339