implement ConnectAsync overloads with CancellationToken on Socket and TcpClient by geoffkizer · Pull Request #40750 · dotnet/runtime

geoffkizer · 2020-08-13T04:20:55Z

Contributes to #33418

Dotnet-GitSync-Bot · 2020-08-13T04:20:58Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2020-08-13T04:21:01Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

geoffkizer · 2020-08-13T04:27:39Z

/azp run runtime-libraries outerloop

azure-pipelines · 2020-08-13T04:27:53Z

Azure Pipelines successfully started running 1 pipeline(s).

stephentoub

Can we use this now in the connection factory stuff?

antonfirsov · 2020-08-13T09:52:23Z

Can we use this now in the connection factory stuff?

Good question which PR gets merged first. If mine, we can do it in a follow-up PR.

geoffkizer · 2020-08-13T20:26:05Z

/azp run runtime-libraries outerloop

azure-pipelines · 2020-08-13T20:26:18Z

Azure Pipelines successfully started running 1 pipeline(s).

geoffkizer · 2020-08-13T22:18:31Z

/azp run runtime-libraries outerloop

azure-pipelines · 2020-08-13T22:18:47Z

Azure Pipelines successfully started running 1 pipeline(s).

stephentoub

LGTM

… TcpClient

geoffkizer · 2020-08-15T02:44:50Z

I also modified SocketConnectionFactory to use the new ConnectAsync API.

geoffkizer · 2020-08-15T02:45:03Z

/azp run runtime-libraries outerloop

azure-pipelines · 2020-08-15T02:45:17Z

Azure Pipelines successfully started running 1 pipeline(s).

geoffkizer · 2020-08-15T05:32:04Z

/azp run runtime-libraries outerloop

azure-pipelines · 2020-08-15T05:32:20Z

Azure Pipelines successfully started running 1 pipeline(s).

geoffkizer · 2020-08-16T08:42:04Z

/azp run runtime-libraries outerloop

azure-pipelines · 2020-08-16T08:42:17Z

Azure Pipelines successfully started running 1 pipeline(s).

MartyIX · 2020-10-06T08:22:53Z

@geoffkizer Is public Task ConnectAsync(IPEndPoint remoteEP) missing on purpose in TcpClient ?

geoffkizer · 2020-10-06T15:20:31Z

I think it just never got added. Feel free to file an issue on it.

Dotnet-GitSync-Bot added area-System.Net.Sockets new-api-needs-documentation labels Aug 13, 2020

geoffkizer self-assigned this Aug 13, 2020

geoffkizer added this to the 5.0.0 milestone Aug 13, 2020

stephentoub reviewed Aug 13, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs Outdated
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs Outdated
Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs Outdated

antonfirsov reviewed Aug 13, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs Outdated

jaredpar mentioned this pull request Aug 13, 2020
OSX machines are de-provisioned during CI / PR runs leading to failures #34472
Closed

geoffkizer requested a review from a teamAugust 13, 2020 22:17

stephentoub reviewed Aug 14, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SocketTestHelper.cs Outdated

stephentoub reviewed Aug 14, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs Outdated

stephentoub approved these changes Aug 14, 2020
View reviewed changes

Geoffrey Kizer added 6 commits August 14, 2020 12:21

implement ConnectAsync overloads with CancellationToken on Socket and…
a37667c
… TcpClient

review feedback
33e18da

rework to avoid code duplication and handle sync completion better
51dad02

fix warning introduced by new APIs
ed69135

improve tests per PR feedback
f93dcb1

modify SocketConnectionFactory to use the new socket ConnectAsync method
0aa6f16

geoffkizer force-pushed the connectasynccancellation branch from 150219b to 0aa6f16Compare August 15, 2020 02:43

more test improvements
75dabca

revert last test changes
1ead0cb

geoffkizer merged commit 1341c35 into dotnet:masterAug 16, 2020

geoffkizer mentioned this pull request Aug 28, 2020
Socket API changes mega-issue #33418
Closed

roji mentioned this pull request Sep 20, 2020
Socket async cancellation and timeout during connection npgsql/npgsql#2860
Closed

MartyIX mentioned this pull request Oct 6, 2020
Missing System.Net.Sockets.TcpClient.Connect(IPEndPoint remoteEP) overload. #43111
Closed

geoffkizer deleted the connectasynccancellation branch November 7, 2020 23:40

ghost locked as resolved and limited conversation to collaborators Dec 8, 2020

Uh oh!

Conversation

geoffkizer commented Aug 13, 2020

Uh oh!

Dotnet-GitSync-Bot commented Aug 13, 2020

Uh oh!

ghost commented Aug 13, 2020

Uh oh!

geoffkizer commented Aug 13, 2020

Uh oh!

azure-pipelinesBot commented Aug 13, 2020

Uh oh!

stephentoub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonfirsov commented Aug 13, 2020

Uh oh!

Uh oh!

geoffkizer commented Aug 13, 2020

Uh oh!

azure-pipelinesBot commented Aug 13, 2020

Uh oh!

geoffkizer commented Aug 13, 2020

Uh oh!

azure-pipelinesBot commented Aug 13, 2020

Uh oh!

Uh oh!

Uh oh!

stephentoub left a comment

Choose a reason for hiding this comment

Uh oh!

geoffkizer commented Aug 15, 2020

Uh oh!

geoffkizer commented Aug 15, 2020

Uh oh!

azure-pipelinesBot commented Aug 15, 2020

Uh oh!

geoffkizer commented Aug 15, 2020

Uh oh!

azure-pipelinesBot commented Aug 15, 2020

Uh oh!

geoffkizer commented Aug 16, 2020

Uh oh!

azure-pipelinesBot commented Aug 16, 2020

Uh oh!

MartyIX commented Oct 6, 2020

Uh oh!

geoffkizer commented Oct 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants