Uh oh!
There was an error while loading. Please reload this page.
Type check the actual values during deserialization in polymorphic scenarios - #41323
Closed
devsko wants to merge 15 commits into
Closed
Type check the actual values during deserialization in polymorphic scenarios#41323devsko wants to merge 15 commits into
devsko wants to merge 15 commits into
Conversation
…into box-member-access
devsko
commented
Aug 25, 2020
ContributorAuthor
devsko
commented
Aug 25, 2020
ContributorAuthor
Added to #40914 again. Close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up from #40931
Fixes#41146.
This PR adds type checks to the property/field setter when a
JsonConvertercould potentially have returned an incompatible typed value.There should be no impact on deserialization performance in the majority of cases where these checks are unnecessary.
The behavior should not depend on the used
MemberAccessorimplementation. To accomplish this, aJsonExceptionis thrown when a direct assignment would throw anInvalidCastExceptionornullis assigned to a non-nullable value type (in this case calling the setter by reflection, silently assignsdefaultand doesn't throw at all).