Uh oh!
There was an error while loading. Please reload this page.
[release/5.0] Fix tailcall regression with compiled F# - #41331
Merged
Conversation
This change skips instantiating stubs for direct tailcalls and instead passes the inst argument directly to the target method. Fixes#40864
jeffschwMSFT
approved these changes
Aug 25, 2020
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a CR.
AndyAyersMS
approved these changes
Aug 25, 2020
jeffschwMSFT
commented
Aug 25, 2020
Member
Approved, please merge. |
jkotas
commented
Aug 25, 2020
Member
Test failure is known issue #40916 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41206 to release/5.0
/cc @jkotas
Customer Impact
Regression from 3.0. FSharp programs may hit stack overflow due to this bug.
Testing
Targeted test + jitstress and libraries jitstress runs
Risk