Skip to content

Clean up changes in #40914 - #41427

Merged
layomia merged 2 commits into
dotnet:masterfrom
layomia:polymorphic_converter_test_fixup
Aug 27, 2020
Merged

Clean up changes in #40914#41427
layomia merged 2 commits into
dotnet:masterfrom
layomia:polymorphic_converter_test_fixup

Conversation

@layomia

@layomialayomia commented Aug 27, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixup for #40914. More detail in #41366 (comment).

  • Prevents test issues due to non-deterministic reflection order on serialization.
  • Prevents a ~6% throughput regression when using custom converters on deserialization.

@layomialayomia added this to the 5.0.0 milestone Aug 27, 2020
@layomialayomia self-assigned this Aug 27, 2020
@devsko

devsko commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

Sorry, didn't know JsonTestHelper.

@layomialayomia changed the title Fixup JSON equality checks in polymorphic converter testsClean up changes in #40914Aug 27, 2020
@layomia

layomia commented Aug 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Sorry, didn't know JsonTestHelper.

No worries at all!

@layomialayomia mentioned this pull request Aug 27, 2020
Merged
ericstj
ericstj reviewed Aug 27, 2020
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfo.cs Outdated
@layomia
layomiaforce-pushed the polymorphic_converter_test_fixup branch from 7f6857b to 3141b60CompareAugust 27, 2020 21:16
jozkee
jozkee approved these changes Aug 27, 2020
View reviewed changes

@jozkeejozkee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@layomialayomia mentioned this pull request Aug 27, 2020
Closed
@layomia

layomia commented Aug 27, 2020

Copy link
Copy Markdown
ContributorAuthor

Test failure: #41485.

@layomialayomia added NO-SQUASH The PR should not be squashed and removed NO-SQUASH The PR should not be squashed labels Aug 27, 2020
@layomia
layomia merged commit fb753ae into dotnet:masterAug 27, 2020
@layomia
layomia deleted the polymorphic_converter_test_fixup branch August 27, 2020 22:55
@ghostghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj approved these changes
@jozkeejozkeejozkee approved these changes
@stevehartersteveharterAwaiting requested review from steveharter

Assignees

@layomialayomia

Labels

area-System.Text.Json

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@layomia@devsko@ericstj@jozkee