Uh oh!
There was an error while loading. Please reload this page.
Port nullability annotations to refs XmlDocument and XmlSerializer - #41474
Merged
3 commits merged intoAug 28, 2020
Merged
Conversation
ghost
commented
Aug 27, 2020
14 tasks
jeffhandley
approved these changes
Aug 28, 2020
jeffhandley
left a comment
Member
There was a problem hiding this comment.
LGTM but please get a second review
krwq
reviewed
Aug 28, 2020
Uh oh!
There was an error while loading. Please reload this page.
krwq
reviewed
Aug 28, 2020
| StringReader strreader = new StringReader(s); | ||
| XmlSerializer deserializerWithOutRootAttribute = ObjectStorage.GetXmlSerializer(_dataType); | ||
| return (deserializerWithOutRootAttribute.Deserialize(strreader)); | ||
| return (deserializerWithOutRootAttribute.Deserialize(strreader))!; |
Member
There was a problem hiding this comment.
also IMO we should file an issue to investigate if this should return nullable here and below
krwq
reviewed
Aug 28, 2020
Uh oh!
There was an error while loading. Please reload this page.
krwq
approved these changes
Aug 28, 2020
krwq
commented
Aug 28, 2020
Member
LGTM, please file an issue for the potential System.Data.Common issue (or TODO-NULLABLE) |
ghost
commented
Aug 28, 2020
Hello @jozkee! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2339
For System.Xml.XmlDocument all types were forwarded to ReaderWriter assembly so I only enabled nullability in the csprojs.
For System.Xml.XmlSerializer some types were forwarded to ReaderWriter but some other types were in place.