Skip to content

Fix leaking ICorProfilerCallback10 - #41791

Merged
davmason merged 1 commit into
dotnet:masterfrom
ww898:ww898-fix-leaking-ICorProfilerCallback10
Sep 3, 2020
Merged

Fix leaking ICorProfilerCallback10#41791
davmason merged 1 commit into
dotnet:masterfrom
ww898:ww898-fix-leaking-ICorProfilerCallback10

Conversation

@ww898

@ww898ww898 commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Somebody forget to update EEToProfInterfaceImpl::~EEToProfInterfaceImpl() after adding ICorProfilerCallback10. Could you please include the fix in 5.0.0-RC2 ASAP?

P.S. The issue is like #10756.

@ghost

ghost commented Sep 3, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@k15tfu

Copy link
Copy Markdown
Contributor

Well, it happened again. Thanks for PR.

cc @davmason

@davmasondavmason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@davmason
davmason merged commit d4cbb60 into dotnet:masterSep 3, 2020
@davmason

Copy link
Copy Markdown
Contributor

/backport to release/5.0-rc2

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/238491377

@ghostghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ww898@k15tfu@davmason@Dotnet-GitSync-Bot