Skip to content

[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938

Merged
antonfirsov merged 3 commits into
release/5.0-rc2from
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged

[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from
backport/pr-41745-to-release/5.0-rc2

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 7, 2020•
edited by danmoseley
Loading

Copy link
Copy Markdown
Contributor

Backport of #41745 to release/5.0-rc2

/cc @antonfirsov

Customer Impact

Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.
This was discovered during app-compat testing.

Testing

A (previously missing) test has been introduced for the case.

Risk

Low or none. The change is limited to the APM methods of TcpListener.

@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Sep 7, 2020
@antonfirsov

antonfirsov commented Sep 7, 2020

Copy link
Copy Markdown
Contributor

CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.

@antonfirsovantonfirsov added area-System.Net.Sockets and removed area-Infrastructure-coreclr Only use for closed issues labels Sep 7, 2020
@ghost

ghost commented Sep 7, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@antonfirsovantonfirsov added tenet-compatibility Incompatibility with previous versions or .NET Framework Servicing-consider Issue for next servicing release review labels Sep 7, 2020
danmoseley
danmoseley reviewed Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

// Give some time for the underlying OS operation to start:
Thread.Sleep(50);

@danmoseleydanmoseleySep 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.

@antonfirsovantonfirsovSep 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.

@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 8, 2020
@danmoseley

danmoseley commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

@antonfirsov OK to merge when green.

@danmoseley

danmoseley commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,

Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D

@danmoseley

danmoseley commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

I clicked rerun failed jobs.

@MattGal

MattGal commented Sep 8, 2020

Copy link
Copy Markdown
Member

@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,

Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D

Sounds like fairly typical network flakiness but taking a peek

@antonfirsov
antonfirsov merged commit 944d33e into release/5.0-rc2Sep 8, 2020
@jkotas
jkotas deleted the backport/pr-41745-to-release/5.0-rc2 branch September 8, 2020 20:51
@karelzkarelz added this to the 5.0.0 milestone Sep 10, 2020
@karelzkarelz mentioned this pull request Sep 10, 2020
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** by github-actions[bot] · Pull Request #41938 · dotnet/runtime · GitHub
Skip to content
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938
Merged
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 7, 2020•

edited by danmoseley

Loading

Copy link


Copy Markdown

Contributor
Backport of #41745 to release/5.0-rc2
/cc @antonfirsov
Customer Impact
Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.

This was discovered during app-compat testing.
Testing
A (previously missing) test has been introduced for the case.
Risk
Low or none. The change is limited to the APM methods of TcpListener.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Sep 7, 2020
@antonfirsov
antonfirsov
commented
Sep 7, 2020

Copy link


Copy Markdown

Contributor
CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.
@antonfirsovantonfirsov
added

area-System.Net.Sockets

and removed

area-Infrastructure-coreclr
Only use for closed issues
labels
Sep 7, 2020
@ghost
ghost
commented
Sep 7, 2020

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
@antonfirsovantonfirsov
added

tenet-compatibility
Incompatibility with previous versions or .NET Framework
Servicing-consider
Issue for next servicing release review
labels
Sep 7, 2020
danmoseley
danmoseley
reviewed
Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
 IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

 // Give some time for the underlying OS operation to start:
 Thread.Sleep(50);
@danmoseleydanmoseleySep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.
@antonfirsovantonfirsovSep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.
@leecowleecow
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 8, 2020
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@antonfirsov OK to merge when green.
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
I clicked rerun failed jobs.
@MattGal
MattGal
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
Sounds like fairly typical network flakiness but taking a peek
@antonfirsov
antonfirsov
merged commit 944d33e
into
release/5.0-rc2Sep 8, 2020
@jkotas
jkotas
deleted the

backport/pr-41745-to-release/5.0-rc2

branch
September 8, 2020 20:51
@karelzkarelz
added this to the 5.0.0 milestone
Sep 10, 2020
@karelzkarelz
mentioned this pull request
Sep 10, 2020

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** by github-actions[bot] · Pull Request #41938 · dotnet/runtime · GitHub
Skip to content
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938
Merged
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 7, 2020•

edited by danmoseley

Loading

Copy link


Copy Markdown

Contributor
Backport of #41745 to release/5.0-rc2
/cc @antonfirsov
Customer Impact
Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.

This was discovered during app-compat testing.
Testing
A (previously missing) test has been introduced for the case.
Risk
Low or none. The change is limited to the APM methods of TcpListener.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Sep 7, 2020
@antonfirsov
antonfirsov
commented
Sep 7, 2020

Copy link


Copy Markdown

Contributor
CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.
@antonfirsovantonfirsov
added

area-System.Net.Sockets

and removed

area-Infrastructure-coreclr
Only use for closed issues
labels
Sep 7, 2020
@ghost
ghost
commented
Sep 7, 2020

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
@antonfirsovantonfirsov
added

tenet-compatibility
Incompatibility with previous versions or .NET Framework
Servicing-consider
Issue for next servicing release review
labels
Sep 7, 2020
danmoseley
danmoseley
reviewed
Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
 IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

 // Give some time for the underlying OS operation to start:
 Thread.Sleep(50);
@danmoseleydanmoseleySep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.
@antonfirsovantonfirsovSep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.
@leecowleecow
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 8, 2020
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@antonfirsov OK to merge when green.
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
I clicked rerun failed jobs.
@MattGal
MattGal
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
Sounds like fairly typical network flakiness but taking a peek
@antonfirsov
antonfirsov
merged commit 944d33e
into
release/5.0-rc2Sep 8, 2020
@jkotas
jkotas
deleted the

backport/pr-41745-to-release/5.0-rc2

branch
September 8, 2020 20:51
@karelzkarelz
added this to the 5.0.0 milestone
Sep 10, 2020
@karelzkarelz
mentioned this pull request
Sep 10, 2020

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** by github-actions[bot] · Pull Request #41938 · dotnet/runtime · GitHub
Skip to content
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938
Merged
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 7, 2020•

edited by danmoseley

Loading

Copy link


Copy Markdown

Contributor
Backport of #41745 to release/5.0-rc2
/cc @antonfirsov
Customer Impact
Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.

This was discovered during app-compat testing.
Testing
A (previously missing) test has been introduced for the case.
Risk
Low or none. The change is limited to the APM methods of TcpListener.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Sep 7, 2020
@antonfirsov
antonfirsov
commented
Sep 7, 2020

Copy link


Copy Markdown

Contributor
CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.
@antonfirsovantonfirsov
added

area-System.Net.Sockets

and removed

area-Infrastructure-coreclr
Only use for closed issues
labels
Sep 7, 2020
@ghost
ghost
commented
Sep 7, 2020

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
@antonfirsovantonfirsov
added

tenet-compatibility
Incompatibility with previous versions or .NET Framework
Servicing-consider
Issue for next servicing release review
labels
Sep 7, 2020
danmoseley
danmoseley
reviewed
Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
 IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

 // Give some time for the underlying OS operation to start:
 Thread.Sleep(50);
@danmoseleydanmoseleySep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.
@antonfirsovantonfirsovSep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.
@leecowleecow
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 8, 2020
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@antonfirsov OK to merge when green.
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
I clicked rerun failed jobs.
@MattGal
MattGal
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
Sounds like fairly typical network flakiness but taking a peek
@antonfirsov
antonfirsov
merged commit 944d33e
into
release/5.0-rc2Sep 8, 2020
@jkotas
jkotas
deleted the

backport/pr-41745-to-release/5.0-rc2

branch
September 8, 2020 20:51
@karelzkarelz
added this to the 5.0.0 milestone
Sep 10, 2020
@karelzkarelz
mentioned this pull request
Sep 10, 2020

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** by github-actions[bot] · Pull Request #41938 · dotnet/runtime · GitHub
Skip to content
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938
Merged
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 7, 2020•

edited by danmoseley

Loading

Copy link


Copy Markdown

Contributor
Backport of #41745 to release/5.0-rc2
/cc @antonfirsov
Customer Impact
Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.

This was discovered during app-compat testing.
Testing
A (previously missing) test has been introduced for the case.
Risk
Low or none. The change is limited to the APM methods of TcpListener.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Sep 7, 2020
@antonfirsov
antonfirsov
commented
Sep 7, 2020

Copy link


Copy Markdown

Contributor
CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.
@antonfirsovantonfirsov
added

area-System.Net.Sockets

and removed

area-Infrastructure-coreclr
Only use for closed issues
labels
Sep 7, 2020
@ghost
ghost
commented
Sep 7, 2020

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
@antonfirsovantonfirsov
added

tenet-compatibility
Incompatibility with previous versions or .NET Framework
Servicing-consider
Issue for next servicing release review
labels
Sep 7, 2020
danmoseley
danmoseley
reviewed
Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
 IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

 // Give some time for the underlying OS operation to start:
 Thread.Sleep(50);
@danmoseleydanmoseleySep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.
@antonfirsovantonfirsovSep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.
@leecowleecow
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 8, 2020
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@antonfirsov OK to merge when green.
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
I clicked rerun failed jobs.
@MattGal
MattGal
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
Sounds like fairly typical network flakiness but taking a peek
@antonfirsov
antonfirsov
merged commit 944d33e
into
release/5.0-rc2Sep 8, 2020
@jkotas
jkotas
deleted the

backport/pr-41745-to-release/5.0-rc2

branch
September 8, 2020 20:51
@karelzkarelz
added this to the 5.0.0 milestone
Sep 10, 2020
@karelzkarelz
mentioned this pull request
Sep 10, 2020

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** by github-actions[bot] · Pull Request #41938 · dotnet/runtime · GitHub
Skip to content
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938
Merged
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 7, 2020•

edited by danmoseley

Loading

Copy link


Copy Markdown

Contributor
Backport of #41745 to release/5.0-rc2
/cc @antonfirsov
Customer Impact
Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.

This was discovered during app-compat testing.
Testing
A (previously missing) test has been introduced for the case.
Risk
Low or none. The change is limited to the APM methods of TcpListener.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Sep 7, 2020
@antonfirsov
antonfirsov
commented
Sep 7, 2020

Copy link


Copy Markdown

Contributor
CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.
@antonfirsovantonfirsov
added

area-System.Net.Sockets

and removed

area-Infrastructure-coreclr
Only use for closed issues
labels
Sep 7, 2020
@ghost
ghost
commented
Sep 7, 2020

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
@antonfirsovantonfirsov
added

tenet-compatibility
Incompatibility with previous versions or .NET Framework
Servicing-consider
Issue for next servicing release review
labels
Sep 7, 2020
danmoseley
danmoseley
reviewed
Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
 IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

 // Give some time for the underlying OS operation to start:
 Thread.Sleep(50);
@danmoseleydanmoseleySep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.
@antonfirsovantonfirsovSep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.
@leecowleecow
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 8, 2020
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@antonfirsov OK to merge when green.
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
I clicked rerun failed jobs.
@MattGal
MattGal
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
Sounds like fairly typical network flakiness but taking a peek
@antonfirsov
antonfirsov
merged commit 944d33e
into
release/5.0-rc2Sep 8, 2020
@jkotas
jkotas
deleted the

backport/pr-41745-to-release/5.0-rc2

branch
September 8, 2020 20:51
@karelzkarelz
added this to the 5.0.0 milestone
Sep 10, 2020
@karelzkarelz
mentioned this pull request
Sep 10, 2020

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** by github-actions[bot] · Pull Request #41938 · dotnet/runtime · GitHub
Skip to content
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938
Merged
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 7, 2020•

edited by danmoseley

Loading

Copy link


Copy Markdown

Contributor
Backport of #41745 to release/5.0-rc2
/cc @antonfirsov
Customer Impact
Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.

This was discovered during app-compat testing.
Testing
A (previously missing) test has been introduced for the case.
Risk
Low or none. The change is limited to the APM methods of TcpListener.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Sep 7, 2020
@antonfirsov
antonfirsov
commented
Sep 7, 2020

Copy link


Copy Markdown

Contributor
CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.
@antonfirsovantonfirsov
added

area-System.Net.Sockets

and removed

area-Infrastructure-coreclr
Only use for closed issues
labels
Sep 7, 2020
@ghost
ghost
commented
Sep 7, 2020

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
@antonfirsovantonfirsov
added

tenet-compatibility
Incompatibility with previous versions or .NET Framework
Servicing-consider
Issue for next servicing release review
labels
Sep 7, 2020
danmoseley
danmoseley
reviewed
Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
 IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

 // Give some time for the underlying OS operation to start:
 Thread.Sleep(50);
@danmoseleydanmoseleySep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.
@antonfirsovantonfirsovSep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.
@leecowleecow
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 8, 2020
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@antonfirsov OK to merge when green.
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
I clicked rerun failed jobs.
@MattGal
MattGal
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
Sounds like fairly typical network flakiness but taking a peek
@antonfirsov
antonfirsov
merged commit 944d33e
into
release/5.0-rc2Sep 8, 2020
@jkotas
jkotas
deleted the

backport/pr-41745-to-release/5.0-rc2

branch
September 8, 2020 20:51
@karelzkarelz
added this to the 5.0.0 milestone
Sep 10, 2020
@karelzkarelz
mentioned this pull request
Sep 10, 2020

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** by github-actions[bot] · Pull Request #41938 · dotnet/runtime · GitHub
Skip to content
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept*** - #41938
Merged
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Sep 8, 2020
Merged
[release/5.0-rc2] Restore exception compatibility in TcpListener.EndAccept***#41938
antonfirsov merged 3 commits into
release/5.0-rc2from 
backport/pr-41745-to-release/5.0-rc2
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
Sep 7, 2020•

edited by danmoseley

Loading

Copy link


Copy Markdown

Contributor
Backport of #41745 to release/5.0-rc2
/cc @antonfirsov
Customer Impact
Removes an unwanted breaking change (#41585), improving migration experience for for users of TcpListener.

This was discovered during app-compat testing.
Testing
A (previously missing) test has been introduced for the case.
Risk
Low or none. The change is limited to the APM methods of TcpListener.
@Dotnet-GitSync-BotDotnet-GitSync-Bot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Sep 7, 2020
@antonfirsov
antonfirsov
commented
Sep 7, 2020

Copy link


Copy Markdown

Contributor
CI failures seem to be Helix issues (failing to proceed after successful test run). None of them seemt obe related to System.Net.Sockets.
@antonfirsovantonfirsov
added

area-System.Net.Sockets

and removed

area-Infrastructure-coreclr
Only use for closed issues
labels
Sep 7, 2020
@ghost
ghost
commented
Sep 7, 2020

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/ncl

See info in area-owners.md if you want to be subscribed.
@antonfirsovantonfirsov
added

tenet-compatibility
Incompatibility with previous versions or .NET Framework
Servicing-consider
Issue for next servicing release review
labels
Sep 7, 2020
danmoseley
danmoseley
reviewed
Sep 8, 2020
View reviewed changes
Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/TcpListenerTest.cs
 IAsyncResult iar = listener.BeginAcceptSocket(callback: null, state: null);

 // Give some time for the underlying OS operation to start:
 Thread.Sleep(50);
@danmoseleydanmoseleySep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often see tests fail because of slow test machines, I wonder whether this will reliably be long enough.
@antonfirsovantonfirsovSep 8, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test the next call should throw ObjectDisposedException independently from timing, so slow machines should not bring an issue hopefully.
@leecowleecow
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Sep 8, 2020
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@antonfirsov OK to merge when green.
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
@danmoseley
danmoseley
commented
Sep 8, 2020

Copy link


Copy Markdown

Contributor
I clicked rerun failed jobs.
@MattGal
MattGal
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@dotnet/dnceng it seems Helix had some issues while running some of these legs. Eg.,
Worker 0: got error: Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 426, in _make_request
six.raise_from(e, None)
File "<string>", line 3, in raise_from
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 421, in _make_request
httplib_response = conn.getresponse()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 1346, in getresponse
response.begin()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 307, in begin
version, status, reason = self._read_status()
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/http/client.py", line 268, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 677, in urlopen
chunked=chunked,
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 428, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 336, in _raise_timeout
self, url, "Read timed out. (read timeout=%s)" % timeout_value
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/.azdo-env/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 767, in urlopen
**response_kw
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/connectionpool.py", line 727, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/root/.azdo-env/lib/python3.6/site-packages/urllib3/util/retry.py", line 439, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/25481974/Results/108910/Attachments (Caused by ReadTimeoutError("HTTPSConnectionPool(host='dev.azure.com', port=443): Read timed out. (read timeout=100)",))

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41938-merge-3162ef2a65a74a9bbe/System.Console.Manual.Tests/console.8d431e4d.log?sv=2019-02-02&se=2020-09-27T13%3A29%3A25Z&sr=c&sp=rl&sig=J9YhitvlHC%2FeeqT%2FUO0wn9EiCQrZq0R2oBOxMjzAVds%3D
Sounds like fairly typical network flakiness but taking a peek
@antonfirsov
antonfirsov
merged commit 944d33e
into
release/5.0-rc2Sep 8, 2020
@jkotas
jkotas
deleted the

backport/pr-41745-to-release/5.0-rc2

branch
September 8, 2020 20:51
@karelzkarelz
added this to the 5.0.0 milestone
Sep 10, 2020
@karelzkarelz
mentioned this pull request
Sep 10, 2020

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@antonfirsovantonfirsovantonfirsov left review comments
@geoffkizergeoffkizergeoffkizer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-System.Net.SocketsServicing-approvedApproved for servicing releasetenet-compatibilityIncompatibility with previous versions or .NET Framework

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@antonfirsov@danmoseley@MattGal@geoffkizer@leecow@karelz@Dotnet-GitSync-Bot