Skip to content

Fix ldtoken for generic RuntimeMethodHandle - #42112

Merged
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:issue-41674
Sep 11, 2020
Merged

Fix ldtoken for generic RuntimeMethodHandle#42112
jkotas merged 1 commit into
dotnet:masterfrom
jkotas:issue-41674

Conversation

@jkotas

@jkotasjkotas commented Sep 11, 2020

Copy link
Copy Markdown
Member

ldtoken for generic RuntimeMethodHandle in non-generic method triggered generic dictionary lookup due to normalization of MethodDescs for reflection. It lead to InvalidProgramException later.

Fixes#41674

@jkotasjkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.Reflection labels Sep 11, 2020
ldtoken for generic RuntimeMethodHandle in non-generic method triggered generic dictionary lookup due to normalization of MethodDescs for reflection. It lead to InvalidProgramException later.
Fixesdotnet#41674

@davidwrightondavidwrighton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@jkotas

Copy link
Copy Markdown
MemberAuthor

/backport to release/5.0-rc2

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/250453733

@ghostghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidProgramException when accessing struct IReadOnlyList<T> in Expression<T>

3 participants

@jkotas@davidwrighton@Dotnet-GitSync-Bot