Fix singlefilehost build in non-portable mode by omajid · Pull Request #42415 · dotnet/runtime

omajid · 2020-09-17T22:14:56Z

The singlefilehost needs to follow libraries build in terms of how it links to OpenSSL: if it's a non-portable build, the singlefilehost needs to link to OpenSSL via linker arguments.

The installer also needs to have FEATURE_DISTRO_AGNOSTIC_SSL defined just like it is defined for the libraries build.

Fixes: #41768

ghost · 2020-09-17T22:15:05Z

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

ghost · 2020-09-17T22:25:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

omajid · 2020-09-18T12:10:30Z

Should I look into adding a CI configuration that exercises runtime build in non-portable mode to catch such regressions earlier for next time around?

dagood · 2020-09-18T16:18:58Z

Should I look into adding a CI configuration that exercises runtime build in non-portable mode to catch such regressions earlier for next time around?

We're planning to do this with arcade-powered source-build. The plan is end-to-end, even--so it also validates dotnet/installer being able to take in a non-portable RID, etc. There's a bit more info at dotnet/source-build#1722.

That said, getting a non-portable config into dotnet/runtime would still be useful in the short term, because we obviously don't have arcade-powered source-build yet. 🙂

janvorli

LGTM, thank you!

janvorli · 2020-09-21T08:54:12Z

A nit - can you please remove this message?

The singilefilehost needs to follow the libraries build in terms of how it links to OpenSSL: if it's a non-portable build, the singlefilehost needs to link to OpenSSL via linker arguments. The installer also needs to have FEATURE_DISTRO_AGNOSTIC_SSL defined just like it is defined for the libraries build. Fixes: dotnet#41768

omajid · 2020-09-21T15:37:48Z

Thanks for the quick review and merging this!

janvorli · 2020-09-23T13:02:15Z

I have noticed that two test legs have failed. I have restarted them.

ghost · 2020-09-23T13:02:38Z

Hello @janvorli!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Backport dotnet/runtime#42415 and carry it as a patch for now.

Dotnet-GitSync-Bot added the area-Host label Sep 17, 2020

maryamariyan added the area-System.Security label Sep 17, 2020

maryamariyan removed the area-Host label Sep 17, 2020

omajid marked this pull request as ready for review September 18, 2020 12:10

omajid mentioned this pull request Sep 18, 2020
Fix hardcoded FEATURE_DISTRO_AGNOSTIC_SSL dotnet/source-build#1755
Merged

janvorli approved these changes Sep 21, 2020
View reviewed changes

omajid force-pushed the singlefilehost-non-portable-ssl branch from 7b213c3 to 3d325d4Compare September 21, 2020 15:09

janvorli approved these changes Sep 21, 2020
View reviewed changes

janvorli added the auto-merge label Sep 23, 2020

ghost merged commit eac3423 into dotnet:masterSep 23, 2020

omajid added a commit to omajid/dotnet-source-build that referenced this pull request Sep 23, 2020
Fix hardcoded FEATURE_DISTRO_AGNOSTIC_SSL
7aca930
Backport dotnet/runtime#42415 and carry it as a patch for now.

omajid added a commit to omajid/dotnet-source-build that referenced this pull request Sep 23, 2020
Fix hardcoded FEATURE_DISTRO_AGNOSTIC_SSL
547649b
Backport dotnet/runtime#42415 and carry it as a patch for now.

This was referenced Sep 24, 2020
singlefilehost doesn't link to system libunwind #42661
Closed
Re-enable support for using the system libunwind #42689
Merged

omajid mentioned this pull request Oct 9, 2020
./build.sh --portablebulid false fails #43219
Closed

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

This pull request was closed.

Navigation Menu

Uh oh!

Fix singlefilehost build in non-portable mode - #42415

Fix singlefilehost build in non-portable mode#42415
1 commit merged into
dotnet:masterfrom
omajid:singlefilehost-non-portable-ssl

omajid commented Sep 17, 2020•
edited
Loading

Uh oh!

ghost commented Sep 17, 2020

Uh oh!

ghost commented Sep 17, 2020

Uh oh!

omajid commented Sep 18, 2020

Uh oh!

dagood commented Sep 18, 2020

Uh oh!

janvorli left a comment

Uh oh!

janvorliSep 21, 2020

Uh oh!

omajidSep 21, 2020

Uh oh!

omajid commented Sep 21, 2020

Uh oh!

janvorli commented Sep 23, 2020

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

omajid commented Sep 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 17, 2020

Uh oh!

ghost commented Sep 17, 2020

Uh oh!

omajid commented Sep 18, 2020

Uh oh!

dagood commented Sep 18, 2020

Uh oh!

janvorli left a comment

Choose a reason for hiding this comment

Uh oh!

janvorliSep 21, 2020

Choose a reason for hiding this comment

Uh oh!

omajidSep 21, 2020

Choose a reason for hiding this comment

Uh oh!

omajid commented Sep 21, 2020

Uh oh!

janvorli commented Sep 23, 2020

Uh oh!

ghost commented Sep 23, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

omajid commented Sep 17, 2020•
edited
Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.