Fix a few Socket.SendFile issues by stephentoub · Pull Request #42535 · dotnet/runtime

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

stephentoub · 2020-09-21T16:35:31Z

The string argument in the single-argument overload should be nullable.
All overloads on Windows should allow a null file path, but they've been throwing an exception
On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

Fixes#42530
Fixes#42529
Fixes#41906

ghost · 2020-09-21T16:35:36Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

wfurt

LGTM with notes @geoffkizer already made.
the manual DangerousAddRef seems unfortunate.

- The string argument in the single-argument overload should be nullable. - All overloads on Windows should allow a null file path, but they've been throwing an exception - On Linux, data was silently truncated when sending a file larger than int.MaxValue with BeginSendFile.

eerhardt · 2020-09-23T14:03:21Z

 public int Send(System.ReadOnlySpan<byte> buffer, System.Net.Sockets.SocketFlags socketFlags, out System.Net.Sockets.SocketError errorCode) { throw null; }
 public bool SendAsync(System.Net.Sockets.SocketAsyncEventArgs e) { throw null; }
- public void SendFile(string fileName) { }
+ public void SendFile(string? fileName) { }


I thought we decided in #32675 (comment) that this should be non-null. Calling SendFile(null) won't do anything, so the assumption is you should pass in a fileName.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.

We did, but issuing a warning doesn't actually solve any problems here, and it leads to an inconsistency with the other overload. It's not harmful to pass null, it's always been allowed on .NET Framework, etc., so we may as well gain the consistency, avoid potential noisy warnings, and allow null.

If we are moving this to be nullable, to be consistent, we should annotate the BeginSendFile overload as nullable as well.
I thought I did. I'll fix it.

(The docs are also explicit about null being allowed.)

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Dotnet-GitSync-Bot added the area-System.Net.Sockets label Sep 21, 2020

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

geoffkizer reviewed Sep 21, 2020
View reviewed changes

Comment threadsrc/libraries/System.Net.Sockets/tests/FunctionalTests/SendFile.cs Outdated

wfurt approved these changes Sep 22, 2020
View reviewed changes

stephentoub added 2 commits September 22, 2020 15:17

Address PR feedback
ce02c8f

stephentoub force-pushed the fixsendfile branch from 28f74a1 to ce02c8fCompare September 22, 2020 19:26

stephentoub merged commit 2734a38 into dotnet:masterSep 23, 2020

stephentoub deleted the fixsendfile branch September 23, 2020 13:23

eerhardt reviewed Sep 23, 2020
View reviewed changes

stephentoub mentioned this pull request Sep 23, 2020
Fix nullable annotation on Socket.BeginSendFile #42623
Merged

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

Uh oh!

Conversation

stephentoub commented Sep 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

stephentoub commented Sep 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

stephentoub commented Sep 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

stephentoub commented Sep 21, 2020•
edited
Loading

stephentoub commented Sep 21, 2020•
edited
Loading

stephentoub commented Sep 21, 2020•
edited
Loading

stephentoub commented Sep 21, 2020•
edited
Loading