Validate ref/src parameter names by ericstj · Pull Request #43838 · dotnet/runtime

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

ericstj · 2020-10-26T18:52:57Z

No description provided.

ghost · 2020-10-26T18:53:01Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

stephentoub · 2020-10-26T19:57:50Z

 public static System.Numerics.Vector<T> Multiply<T>(System.Numerics.Vector<T> left, T right) where T : struct { throw null; }
 public static System.Numerics.Vector<T> Multiply<T>(T left, System.Numerics.Vector<T> right) where T : struct { throw null; }
- public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> source1, System.Numerics.Vector<System.Double> source2) { throw null; }
+ public static System.Numerics.Vector<System.Single> Narrow(System.Numerics.Vector<System.Double> low, System.Numerics.Vector<System.Double> high) { throw null; }


cc: @tannergooding

I'm fine with this as long as we are fine with the breaking change.
That being said, lower and upper may be better names than low and high here and would match the names we are using in the newer hardware intrinsics.

I don't think we should be revisiting names at this point. We should choose either src or ref as the winners. So far we've felt that choosing src as the winner is slightly less breaking since a compile time break is easier to deal with than runtime break.

safern

🎉 -- as long we're fine with the breaking changes.

Mono used a different name which was more consistent with the rest of the API.

ericstj · 2020-11-06T23:55:52Z

@terrajobst do you support this change? Note a few places where I made parameter name changes in the implementation, or in both implementation/ref to match mono (which chose more consistent parameter names).

ericstj · 2020-11-06T23:57:10Z

+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
+ public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }


These changed both in ref and src to match Mono.

terrajobst

I'm onboard with these kind of changes as it's inline with the kind of breaks we want to be able to do in .NET Core. The proposed changes seems fine.

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

ericstj · 2020-11-12T01:12:10Z

I only have one question: it seems we're sometimes choosing ref and sometimes choosing src as the winner. Not that there is a problem but how did we choose? What makes more sense?

I preferred src over ref since they tended to have better names and it's less breaking (ref changes only break recompile). There were exceptions. Mentioned #43838 (comment), #43838 (comment), #43838 (comment), and changes in crypto that made things consistent with other similar APIs in the same assembly.

ericstj · 2020-11-12T01:13:12Z

/azp run runtime

azure-pipelines · 2020-11-12T01:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…mpatOptional

ericstj · 2020-11-12T01:35:01Z

Looks like @stephentoub's changes in #43834 broke this. I'll fix those up as well.

terrajobst · 2020-11-13T03:37:11Z

Awesome. Thanks!

ericstj · 2021-10-14T22:43:49Z

Doc : dotnet/docs#26519

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

Validate ref/src parameter names
7838480

ericstj requested review from Anipik, stephentoub and terrajobst October 26, 2020 18:52

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Oct 26, 2020

ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Oct 26, 2020

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 26, 2020

stephentoub reviewed Oct 26, 2020
View reviewed changes

stephentoub approved these changes Oct 26, 2020
View reviewed changes

stephentoub reviewed Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated

Fix a few more parameter name mismatches
c59c247

safern approved these changes Oct 26, 2020
View reviewed changes

Anipik approved these changes Oct 26, 2020
View reviewed changes

ericstj requested a review from bartonjs October 26, 2020 22:58

bartonjs approved these changes Oct 26, 2020
View reviewed changes

Comment threadsrc/libraries/System.Security.Permissions/src/System/Data/Common/DBDataPermission.cs Outdated

ericstj added 2 commits October 26, 2020 17:46

Make Attribute.GetCustomAttributes params consistent
0cd45d4
Mono used a different name which was more consistent with the rest of the API.

Make StreamWriter.WriteLine(ROS<char>) consistent with base
051406b

ericstj force-pushed the apiCompatOptional branch from 53241af to 051406bCompare October 27, 2020 00:47

runfoappBot mentioned this pull request Oct 27, 2020
SelfContained_NetCoreApp3_CompatMode_SingleFile_APITests failed in CI #43917
Closed

ericstj commented Nov 6, 2020
View reviewed changes

terrajobst approved these changes Nov 12, 2020
View reviewed changes

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto apiCo…
09429d3
…mpatOptional

Fix FileStream Begin* parameters
7ee58ce

ericstj merged commit 8ebd0d4 into dotnet:masterNov 12, 2020

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

ericstj added this to the 6.0.0 milestone Sep 29, 2021

ericstj self-assigned this Sep 30, 2021

ericstj removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 14, 2021

		public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType) { throw null; }
		public static System.Attribute[] GetCustomAttributes(System.Reflection.MemberInfo element, System.Type attributeType, bool inherit) { throw null; }

Uh oh!

Conversation

ericstj commented Oct 26, 2020

Uh oh!

ghost commented Oct 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

safern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ericstj commented Nov 6, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terrajobst left a comment

Choose a reason for hiding this comment

Uh oh!

ericstj commented Nov 12, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericstj commented Nov 12, 2020

Uh oh!

azure-pipelinesBot commented Nov 12, 2020

Uh oh!

ericstj commented Nov 12, 2020

Uh oh!

terrajobst commented Nov 13, 2020

Uh oh!

ericstj commented Oct 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

ericstj commented Oct 26, 2020

Uh oh!

ghost commented Oct 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

safern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ericstj commented Nov 6, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

terrajobst left a comment

Choose a reason for hiding this comment

Uh oh!

ericstj commented Nov 12, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericstj commented Nov 12, 2020

Uh oh!

azure-pipelinesBot commented Nov 12, 2020

Uh oh!

ericstj commented Nov 12, 2020

Uh oh!

terrajobst commented Nov 13, 2020

Uh oh!

ericstj commented Nov 12, 2020•
edited
Loading

ericstj commented Nov 12, 2020•
edited
Loading

ericstj commented Nov 12, 2020•
edited
Loading