Uh oh!
There was an error while loading. Please reload this page.
Replace net6.0 TargetFramework Equality Conditions with msbuild intrinsic functions - #43857
Conversation
ghost
commented
Oct 26, 2020
Tagging subscribers to this area: @safern, @ViktorHofer |
safern
commented
Oct 26, 2020
Are there any implications on not removing the platform part of the tfm from it and passing it down to the SDK? |
ViktorHofer
left a comment
There was a problem hiding this comment.
I believe we should instead use these intrinsic functions: dotnet/msbuild#5171 (comment).
Anipik
commented
Oct 26, 2020
There shouldnt be any, i have a blueprint which almost 90% of things going right. |
Not the SDK but one impact: we can finally revert dotnet/arcade@bd2a2b0 as we will then have distinct identities. That said, if |
Anipik
commented
Oct 26, 2020
We should also remove the
|
Yes we should do that as well (either in this PR or a follow-up one) but only for >= net5.0 configurations. For older ones we probably need to use EndsWith(...) or |
Anipik
commented
Oct 26, 2020
I will throw up follow up for this one. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
….SystemEvents.csproj Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
commented
Oct 28, 2020
Which is fine as long as the TargetFramework isn't overloaded. There is room for improvement here as there are several projects that condition on |
Working Towards #43646
The
'$(TargetFramework)' == 'net6.0'conditions are meant for all platforms. This currently works because we remove the platform string from the tfm.We will be no longer doing that hence we are changes the condition to $(TargetFramework.StartsWith('net6.0'))
I have done this for the
!=as well.