Uh oh!
There was an error while loading. Please reload this page.
Remove LazyInitializer usage from corelib - #44409
Merged
Merged
Conversation
stephentoub
requested review from
EgorBo, akoeplinger, marek-safar, steveisok and vargaz
as code ownersNovember 9, 2020 14:37
Dotnet-GitSync-Bot
commented
Nov 9, 2020
Collaborator
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoubforce-pushed
the
lazyinit
branch
2 times, most recently
from
November 9, 2020 15:12
a98ef10 to
f51f5aaCompareUh oh!
There was an error while loading. Please reload this page.
stephentoubforce-pushed
the
lazyinit
branch
2 times, most recently
from
November 11, 2020 02:50
fe54006 to
5d706e5Comparejkotas
reviewed
Nov 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
jkotas
reviewed
Nov 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
It's fine for higher layers, but in corelib we don't want to forcibly prevent LazyInitializer from being trimmed nor pay the overheads of additional cached delegates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's fine for higher layers, but in corelib we don't want to forcibly prevent LazyInitializer from being trimmed nor pay the overheads of additional cached delegates.
cc: @jkotas