Uh oh!
There was an error while loading. Please reload this page.
Add ICorDebugHeapValue4 -- CreatePinnedHandle - #44471
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
sdmaclea
commented
Nov 10, 2020
ContributorAuthor
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chuckries
approved these changes
Nov 10, 2020
sdmacleaforce-pushed
the
createPinnedHandle
branch
from
November 10, 2020 20:32
b33db21 to
a122ca3Comparekouvel
commented
Nov 10, 2020
Contributor
Thanks @sdmaclea! LGTM, though I'm not too familiar with adding APIs in this area. |
hoyosjs
approved these changes
Nov 10, 2020
ghost
commented
Nov 10, 2020
Tagging subscribers to this area: @tommcdon DetailsIssue meta data
|
sdmaclea
commented
Nov 11, 2020
ContributorAuthor
@kouvel I expect when you have the rest of the tiered JIT, data breakpoint deadlock fix finished. You will backport the whole fix to 5.0 servicing branch. |
kouvel
commented
Nov 11, 2020
Contributor
Yep about to put up a PR for my side shortly, will port both once that's in |
sdmaclea added a commit
to sdmaclea/runtime
that referenced
this pull request
Nov 11, 2020
* Add ICorDebugHeapValue4 * Add EnableGCNotificationEvents deprecation comment
sdmaclea added a commit
that referenced
this pull request
Nov 24, 2020
#44563) * Add ICorDebugHeapValue4 -- CreatePinnedHandle (#44471) * Add ICorDebugHeapValue4 * Add EnableGCNotificationEvents deprecation comment * Drop support for IID_ICorDebugProcess10 and fix thread suspend logic (#44549) * Stop providing IID_ICorDebugProcess10 Prevent older VS versions from setting managed data breakpoints. * Simplify the thread collision logic to prevent deadlock This is a simplification of #44539 as proposed by @kouvel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.