Uh oh!
There was an error while loading. Please reload this page.
Upgrade global.json to 5.0-alpha1 SDK - #445
Conversation
Uh oh!
There was an error while loading. Please reload this page.
ViktorHofer
commented
Dec 4, 2019
The Rhel6 errors are because of dotnet/installer#5539 not being merged into master yet where a rhel.6 removal commit was reverted. |
7e0df9a to
15343f6Compareericstj
commented
Dec 4, 2019
I'm guessing all-configurations leg is failing because new SDK might be missing the known frameworks for past netcoreapps? That's where I would reccomend investigating. |
ViktorHofer
commented
Dec 5, 2019
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
commented
Dec 5, 2019
/azp run runtime-libraries |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
commented
Dec 5, 2019
/azp run runtime-coreclr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
commented
Dec 5, 2019
/azp run runtime-installer |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
commented
Dec 5, 2019
This is ready, pls can somebody approve. |
ericstj
left a comment
There was a problem hiding this comment.
Minor comment you can merge if green
| --> | ||
| <Target Name="_SetRuntimeFrameworksForTestAssemblies" | ||
| Condition="'$(SelfContained)' != 'true'" | ||
| Condition="'$(SelfContained)' != 'true' and '$(MSBuildProjectExtension)' != '.depproj'" |
| </ItemGroup> | ||
| <!-- Mark framework references from previous netcoreapp tfms >= 3.0 as copy-local. --> | ||
| <Target Name="_FrameworkReferencesToPrivate" |
There was a problem hiding this comment.
Instead I’d just do this for all items in depproj targets.
There was a problem hiding this comment.
Can you elaborate? Not sure I follow. Do you mean to actually Define an ItemDefintionGroup for reference?
There was a problem hiding this comment.
If you mean you would do it for all targets, I would rather not as we include netstandard2.0 here as well which just creates noise in the ref folder, ie dotnet-XmlGenerator.
There was a problem hiding this comment.
I meant that the purpose of DepProj is to copy. It flows these items to content here:
Line 95 in 8f67999
This is effectively doing the same thing you're trying to do (force to copy). If that wasn't working for framework references we should fix it there.
There was a problem hiding this comment.
Actually I investigated why this wasn't working with the depproj/binplacing logic. I will submit a follow-up PR when I have some cycles to fix it there.
We need the 5.0 SDK to use new VSTest features and we should start using it anyway. Opening this PR to test what will eventually break.