Skip to content

[mono] Fix warnings on OSX, re-enable -Werror on CI with CMake - #44747

Merged
CoffeeFlux merged 14 commits into
dotnet:masterfrom
CoffeeFlux:fix-warnings-cmake
Nov 26, 2020
Merged

[mono] Fix warnings on OSX, re-enable -Werror on CI with CMake#44747
CoffeeFlux merged 14 commits into
dotnet:masterfrom
CoffeeFlux:fix-warnings-cmake

Conversation

@CoffeeFlux

@CoffeeFluxCoffeeFlux commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

Some warnings snuck in after we lost this in the CMake transition. Contributes to #41357

@ghost

ghost commented Nov 16, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Details

Issue Details
Description:

Some warnings snuck in after we lost this in the CMake transition. Contributes to #41357

Author:CoffeeFlux
Assignees:-
Labels:

area-VM-meta-mono

Milestone:-

@monojenkinsmonojenkins mentioned this pull request Nov 16, 2020
Merged
lambdageek
lambdageek reviewed Nov 16, 2020
View reviewed changes
Comment threadsrc/mono/mono/sgen/sgen-descriptor.c Outdated
lambdageek
lambdageek reviewed Nov 16, 2020
View reviewed changes
Comment threadsrc/mono/mono/sgen/sgen-descriptor.c Outdated
lambdageek
lambdageek reviewed Nov 16, 2020
View reviewed changes
Comment threadsrc/mono/mono/sgen/sgen-descriptor.c Outdated
lambdageek
lambdageek reviewed Nov 16, 2020
View reviewed changes
Comment threadsrc/mono/mono.proj Outdated
@lateralusX
lateralusXforce-pushed the fix-warnings-cmake branch 2 times, most recently from fae910c to 6a90ad6CompareNovember 20, 2020 15:35
@CoffeeFlux

CoffeeFlux commented Nov 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Blocked on remaining eventpipe warnings.

@lateralusX

lateralusX commented Nov 20, 2020

Copy link
Copy Markdown
Member

eventpipe warnings and osx build should be fixed.

@CoffeeFluxCoffeeFlux mentioned this pull request Nov 20, 2020
Closed
@lateralusX

lateralusX commented Nov 24, 2020

Copy link
Copy Markdown
Member

@CoffeeFlux Any plan on resolving the last wasm issue? I will probably need the eventpipe change for another PR during the week.

CoffeeFluxand others added 9 commits November 25, 2020 11:46
@CoffeeFlux
Ifdef out removed icalls on netcore
6f43cab
@CoffeeFlux
Fix format string for cross builds
24c090b
desc here is based on the pointer size of the target, whereas void* is based on the host
@CoffeeFlux
Re-enable -WError on CI for OSX and Wasm
c8b4082
This got lost in the CMake transition
@lateralusX@CoffeeFlux
Improve ep_rt_thread_id_t handling.
123425a
@CoffeeFlux
Make types_str local to mono_fdhandle_insert
c1f7bd1
@lateralusX@CoffeeFlux
Fix OSX build error.
538833b
@lateralusX@CoffeeFlux
Align os thread id to uint64_t.
2de71da
@CoffeeFlux@lambdageek
Update src/mono/mono/sgen/sgen-descriptor.c
cadb503
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
@CoffeeFlux@lambdageek
Update src/mono/mono/sgen/sgen-descriptor.c
7512b62
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
CoffeeFluxand others added 4 commits November 25, 2020 11:46
@CoffeeFlux@lambdageek
Update src/mono/mono/sgen/sgen-descriptor.c
6b5449f
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
@CoffeeFlux
Revert "Make types_str local to mono_fdhandle_insert"
4ac4672
This reverts commit 04f56efcb8e9d33dca12f831f9c05591c649678c.
@CoffeeFlux
Put types_str under appropriate ifdef
85ea6fa
@CoffeeFlux
Disable Werror on wasm
9a46919
@CoffeeFluxCoffeeFlux changed the title [mono] Fix warnings on OSX and wasm, re-enable -Werror on CI with CMake[mono] Fix warnings on OSX, re-enable -Werror on CI with CMakeNov 25, 2020
@CoffeeFlux

CoffeeFlux commented Nov 25, 2020

Copy link
Copy Markdown
ContributorAuthor

I'll handle wasm separately. The remaining issue looks weird and I don't have time to investigate right now.

@runfoapprunfoappBot mentioned this pull request Nov 25, 2020
Closed
@CoffeeFlux

CoffeeFlux commented Nov 26, 2020

Copy link
Copy Markdown
ContributorAuthor

It looks like none of the failures are build-related other than Android, which is hung rather than erroring.

@CoffeeFlux
CoffeeFlux merged commit 96fe6f3 into dotnet:masterNov 26, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek left review comments
@lateralusXlateralusXlateralusX left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@BrzVladBrzVladAwaiting requested review from BrzVlad
@marek-safarmarek-safarAwaiting requested review from marek-safar
@nariccnariccAwaiting requested review from naricc
@thaystgthaystgAwaiting requested review from thaystg
+1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-meta-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CoffeeFlux@lateralusX@vargaz@lambdageek@akoeplinger@Dotnet-GitSync-Bot