Skip to content

Fix regression in XDocumentType - #44868

Merged
krwq merged 1 commit into
dotnet:masterfrom
krwq:fix_44489
Nov 19, 2020
Merged

Fix regression in XDocumentType#44868
krwq merged 1 commit into
dotnet:masterfrom
krwq:fix_44489

Conversation

@krwq

@krwqkrwq commented Nov 18, 2020

Copy link
Copy Markdown
Member

Fixes: #44489

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @buyaa-n, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Details

Issue Details
Description:

Fixes regression in: #44489

Author:krwq
Assignees:stephentoub, Jozkee, buyaa-n
Labels:

area-System.Xml

Milestone:-

@stephentoub

Copy link
Copy Markdown
Member

/azp list

@stephentoub

Copy link
Copy Markdown
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jeffhandley

Copy link
Copy Markdown
Member

@krwq Please include these changes into our accumulated list of nullable annotation changes in 6.0.

@jozkeejozkee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source changes LGTM.

@krwqkrwq added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 19, 2020
@krwq

krwq commented Nov 19, 2020

Copy link
Copy Markdown
MemberAuthor

The failures don't seem to be related, merging

@krwq
krwq merged commit a7040b0 into dotnet:masterNov 19, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 19, 2020
@ericstjericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Sep 29, 2021
@ericstjericstj added this to the 6.0.0 milestone Sep 29, 2021
@ericstjericstj assigned krwq and unassigned stephentoub, jozkee and buyaa-nSep 30, 2021
@jeffhandleyjeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Xmlbreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression in SimpleConstructors test inside System.Xml.Linq.TreeManipulation.Tests

6 participants

@krwq@stephentoub@jeffhandley@jozkee@ericstj@buyaa-n