Enable format-job for windows

[kunalspathak]

Revert changes in #40035 and #40517 and re-enable format job for Windows.

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[kunalspathak]

The build job that produces configure_commands.json file fails for windows. I also see weird failures around:

The application to execute does not exist: 'D:/a/1/s/artifacts/bin/coreclr/windows.x64.Debug/DacTableGen/DacTableGen.dll'

@sandreenko or @BruceForstall - any idea? Also the build-runtime.cmd command takes around 20 minutes to complete where as on linux it completes in few minutes.

Linux

src/coreclr/build-runtime.sh x64 Checked configureonly -cmakeargs -DCMAKE_EXPORT_COMPILE_COMMANDS=1

Windows:

src\coreclr\build-runtime.cnd x64 Checked usenmakemakefiles

Can we invoke this command consistently?

[BruceForstall]

These build scripts have changed dramatically recently. It may be that the formatting job uses script functionality that was only used for the formatting job, which is not a good way to keep it working over time. Maybe there's a way to invoke the build scripts in a more standard way (or at least have only minimal build script requirements for the formatting job).

Otherwise, I have no real insight into how that json file gets created or how the formatting job uses it.

[kunalspathak]

These build scripts have changed dramatically recently. It may be that the formatting job uses script functionality that was only used for the formatting job, which is not a good way to keep it working over time. Maybe there's a way to invoke the build scripts in a more standard way (or at least have only minimal build script requirements for the formatting job).

Otherwise, I have no real insight into how that json file gets created or how the formatting job uses it.

In that case, I don't think I have time to figure out the right command for this. Do you know anyone who can help or else I can just close this PR and re-open it when I get time to figure that out.

[sandreenko]

In that case, I don't think I have time to figure out the right command for this. Do you know anyone who can help or else I can just close this PR and re-open it when I get time to figure that out.

I think this work can be postponed, we have been living with a Linux formatting job only and can continue it for a while.