Uh oh!
There was an error while loading. Please reload this page.
[release/5.0] Browser support for Debugger::Break. - #45038
Merged
Conversation
lewing
requested review from
CoffeeFlux, SamMonoRT, lambdageek, marek-safar and vargaz
as code ownersNovember 20, 2020 23:29
ghost
commented
Nov 20, 2020
Tagging subscribers to this area: @thaystg Issue Detailsbackport of #44305 to release/5.0 /cc @thaystg Customer ImpactAddresses VS Feedback ticket where using System.Diagnostics.Debug.Debugger.Break would cause a runtime assertion rather than a breakpoint. The trivial fix connects the exiting functionality to the correct debugger endpoint. Fixes #44210 TestingVerified manually and includes a debugger test for basic functionality. RiskVery low. Connects existing code.
|
lewing
commented
Nov 21, 2020
MemberAuthor
Approved in tactics email. |
steveisok
self-requested a review
November 21, 2020 00:56
steveisok
approved these changes
Nov 21, 2020
lewing
commented
Nov 23, 2020
MemberAuthor
The change is wasm specific the multiple lane failures/timeouts are not related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #44305 to release/5.0
/cc @thaystg
Customer Impact
Addresses VS Feedback ticket where using System.Diagnostics.Debugger.Break would cause a runtime assertion rather than a breakpoint. The trivial fix connects the existing functionality to the correct debugger endpoint.
Fixes#44210
Testing
Verified manually and includes a debugger test for basic functionality.
Risk
Very low. Connects existing code.