Uh oh!
There was an error while loading. Please reload this page.
renaming clrcompression --> System.IO.Compression.Native - #45713
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…s. Same as Globalization - without `lib` prefix
9da9039 to
3ca8f5cCompareUh oh!
There was an error while loading. Please reload this page.
3ca8f5c to
cd39845Compared04a11d to
ea583deCompare| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
VS did something that I cannot see or undo in the editor. I will revert the whole file in git.
Uh oh!
There was an error while loading. Please reload this page.
CoffeeFlux
commented
Dec 8, 2020
Mono changes LGTM. Thanks! |
VSadov
commented
Dec 8, 2020
Thanks!!! |
ericstj
commented
Jan 15, 2021
FYI: This name change broke an application : #47029. IMHO that app is doing a bad thing, hopefully we'll fix that app. It's not completely unlikely that others might make a similar mistake. Any reason you chose the System.* convention here? |
VSadov
commented
Jan 15, 2021
It was already called |
ericstj
commented
Jan 15, 2021
I think we give it a "lib" prefix on those other platforms. |
Yes, there is a convention about prefix (lib on Unix, none on Windows) and extensions (.dll, .so, .dylib). They were applied according to platform. There is also prior art in the naming of Actually it still has that name for the purpose of PInvoke targets. We redirect these pinvokes to the implementation linked into coreclr, but a standalone |
ericstj
commented
Jan 15, 2021
I don't think we ever shipped that. System.IO.Compression.Native.dll is the first native binary to use the convention System.*.dll on windows. |
We have a lot "System.*.Native." on Unix. The question of "lib" prefix did come up in PR discussions, but it appeared more consistent to not have it on Windows: #45713 (comment) |
Superhost PR follow-up
Re: #44505 (comment)
For the most part a search/replace change.