Skip to content

Add a blurb on the x86 calling convention to clr-abi.md - #45807

Merged
jkoritzinsky merged 4 commits into
dotnet:masterfrom
jkoritzinsky:clr-abi-updates
Dec 9, 2020
Merged

Add a blurb on the x86 calling convention to clr-abi.md#45807
jkoritzinsky merged 4 commits into
dotnet:masterfrom
jkoritzinsky:clr-abi-updates

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Dec 8, 2020

Copy link
Copy Markdown
Member

Add some information about the x86 calling convention based on my learnings from #39294

@jkoritzinskyjkoritzinsky added documentation Documentation bug or enhancement, does not impact product or test code area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 8, 2020
@jkoritzinskyjkoritzinsky added this to the 6.0.0 milestone Dec 8, 2020
sandreenko
sandreenko reviewed Dec 8, 2020
View reviewed changes
Comment threaddocs/design/coreclr/botr/clr-abi.md Outdated
Comment threaddocs/design/coreclr/botr/clr-abi.md Outdated
jkoritzinskyand others added 2 commits December 8, 2020 15:37
@jkoritzinskySergey Andreenko
Update docs/design/coreclr/botr/clr-abi.md
0d42a07
Co-authored-by: Sergey Andreenko <seandree@microsoft.com>
@jkoritzinsky
Add specific callout about how the managed and native x86 calling con…
4ffeab1
…ventions differ.
jkotas
jkotas reviewed Dec 8, 2020
View reviewed changes
Comment threaddocs/design/coreclr/botr/clr-abi.md Outdated
sandreenko
sandreenko approved these changes Dec 9, 2020
View reviewed changes

@sandreenkosandreenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this.

@jkoritzinsky
jkoritzinsky merged commit d5a9b9d into dotnet:masterDec 9, 2020
@jkoritzinsky
jkoritzinsky deleted the clr-abi-updates branch December 9, 2020 00:43
@ghostghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
+1 more reviewer
@sandreenkosandreenkosandreenko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIdocumentationDocumentation bug or enhancement, does not impact product or test code

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jkoritzinsky@jkotas@sandreenko