Skip to content

Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hrrrrustic wants to merge 3 commits into from
Closed

Methods "readonly" annotation #46675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a830287
Small annotation part for pr init
hrrrrustic Jan 6, 2021
a9cbfef
remaining changes
hrrrrustic Apr 26, 2021
a729883
remove redundant marking in auto getters
hrrrrustic Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Unix/Interop.Errors.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
_rawErrno = -1;
}

internal Error Error
internal readonly Error Error
{
get { return _error; }
}
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
internal ulong _length;
internal IntPtr _data;

internal int Copy(byte[] destination, int offset)
internal readonly int Copy(byte[] destination, int offset)
{
Debug.Assert(destination != null, "target destination cannot be null");
Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
return sourceLength;
}

internal byte[] ToByteArray()
internal readonly byte[] ToByteArray()
{
if (_data == IntPtr.Zero || _length == 0)
{
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
return destination;
}

internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
default;

Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
internal short wSecond;
internal short wMilliseconds;

public override string ToString()
public override readonly string ToString()
{
return "[SYSTEMTIME: "
+ wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
internal IntPtr pbData;
internal int cUnusedBits;

internal byte[] ToByteArray()
internal readonly byte[] ToByteArray()
{
int numBytes = cbData;
byte[] data = new byte[numBytes];
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
public int cbData;
public IntPtr pbData;

public string? OID
public readonly string? OID
{
get
{
return Marshal.PtrToStringAnsi(pszOID);
}
}

public string? Name
public readonly string? Name
{
get
{
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
public int right;
public int bottom;

public Size Size => new Size(right - left, bottom - top);
public readonly Size Size => new Size(right - left, bottom - top);
}
}
}
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
internal long TicksSince1601;
#pragma warning restore CS0649

internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
}
}
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
internal IntPtr address;
internal int addressLength;

internal IPAddress MarshalIPAddress()
internal readonly IPAddress MarshalIPAddress()
{
// Determine the address family used to create the IPAddress.
AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
dwHighDateTime = (uint)(fileTime >> 32);
}

internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
}
}
}
8 changes: 4 additions & 4 deletions src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
internal ushort Second;
internal ushort Milliseconds;

internal bool Equals(in SYSTEMTIME other) =>
internal readonly bool Equals(in SYSTEMTIME other) =>
Year == other.Year &&
Month == other.Month &&
DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
internal fixed char TimeZoneKeyName[128];
internal byte DynamicDaylightTimeDisabled;

internal string GetTimeZoneKeyName()
internal readonly string GetTimeZoneKeyName()
{
fixed (char* p = TimeZoneKeyName)
return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
*pTo = *(TIME_ZONE_INFORMATION*)pFrom;
}

internal string GetStandardName()
internal readonly string GetStandardName()
{
fixed (char* p = StandardName)
return new string(p);
}

internal string GetDaylightName()
internal readonly string GetDaylightName()
{
fixed (char* p = DaylightName)
return new string(p);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
public uint EaSize;

private char _fileName;
public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

/// <summary>
/// Gets the next info pointer or null if there are no more.
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
public uint grfStateBits;
public uint reserved;

public string? GetName() => Marshal.PtrToStringUni(pwcsName);
public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

/// <summary>
/// Caller is responsible for freeing the name memory.
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
private IntPtr dwLower;
private IntPtr dwUpper;

public bool IsZero
public readonly bool IsZero
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
dwUpper = IntPtr.Zero;
}

public override string ToString()
public override readonly string ToString()
{
{ return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
}
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Common/src/System/MutableDecimal.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

public bool IsNegative
{
get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
}

public int Scale
{
get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
}

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Methods "readonly" annotation by hrrrrustic · Pull Request #46675 · dotnet/runtime · GitHub
Skip to content
Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


Methods "readonly" annotation
#46675
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a830287

Small annotation part for pr init


hrrrrustic Jan 6, 2021
a9cbfef

remaining changes


hrrrrustic Apr 26, 2021
a729883

remove redundant marking in auto getters


hrrrrustic Apr 26, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Unix/Interop.Errors.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
 _rawErrno = -1;
 }

 internal Error Error
 internal readonly Error Error
 {
 get { return _error; }
 }
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
 internal ulong _length;
 internal IntPtr _data;

 internal int Copy(byte[] destination, int offset)
 internal readonly int Copy(byte[] destination, int offset)
 {
 Debug.Assert(destination != null, "target destination cannot be null");
 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
 return sourceLength;
 }

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 if (_data == IntPtr.Zero || _length == 0)
 {
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
 return destination;
 }

 internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
 default;

Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
 internal short wSecond;
 internal short wMilliseconds;

 public override string ToString()
 public override readonly string ToString()
 {
 return "[SYSTEMTIME: "
 + wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
 internal IntPtr pbData;
 internal int cUnusedBits;

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 int numBytes = cbData;
 byte[] data = new byte[numBytes];
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
 public int cbData;
 public IntPtr pbData;

 public string? OID
 public readonly string? OID
 {
 get
 {
 return Marshal.PtrToStringAnsi(pszOID);
 }
 }

 public string? Name
 public readonly string? Name
 {
 get
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
 public int right;
 public int bottom;

 public Size Size => new Size(right - left, bottom - top);
 public readonly Size Size => new Size(right - left, bottom - top);
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
 internal long TicksSince1601;
#pragma warning restore CS0649

 internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
 internal IntPtr address;
 internal int addressLength;

 internal IPAddress MarshalIPAddress()
 internal readonly IPAddress MarshalIPAddress()
 {
 // Determine the address family used to create the IPAddress.
 AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
 dwHighDateTime = (uint)(fileTime >> 32);
 }

 internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 }
 }
}

8 changes: 4 additions & 4 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
 internal ushort Second;
 internal ushort Milliseconds;

 internal bool Equals(in SYSTEMTIME other) =>
 internal readonly bool Equals(in SYSTEMTIME other) =>
 Year == other.Year &&
 Month == other.Month &&
 DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
 internal fixed char TimeZoneKeyName[128];
 internal byte DynamicDaylightTimeDisabled;

 internal string GetTimeZoneKeyName()
 internal readonly string GetTimeZoneKeyName()
 {
 fixed (char* p = TimeZoneKeyName)
 return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
 *pTo = *(TIME_ZONE_INFORMATION*)pFrom;
 }

 internal string GetStandardName()
 internal readonly string GetStandardName()
 {
 fixed (char* p = StandardName)
 return new string(p);
 }

 internal string GetDaylightName()
 internal readonly string GetDaylightName()
 {
 fixed (char* p = DaylightName)
 return new string(p);
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
 public uint EaSize;

 private char _fileName;
 public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
 public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

 /// <summary>
 /// Gets the next info pointer or null if there are no more.
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
 public uint grfStateBits;
 public uint reserved;

 public string? GetName() => Marshal.PtrToStringUni(pwcsName);
 public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

 /// <summary>
 /// Caller is responsible for freeing the name memory.
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
 private IntPtr dwLower;
 private IntPtr dwUpper;

 public bool IsZero
 public readonly bool IsZero
 {
 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
 dwUpper = IntPtr.Zero;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 { return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
 }
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/System/MutableDecimal.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

 public bool IsNegative
 {
 get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
 set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
 }

 public int Scale
 {
 get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
 set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
 }

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Methods "readonly" annotation by hrrrrustic · Pull Request #46675 · dotnet/runtime · GitHub
Skip to content
Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


Methods "readonly" annotation
#46675
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a830287

Small annotation part for pr init


hrrrrustic Jan 6, 2021
a9cbfef

remaining changes


hrrrrustic Apr 26, 2021
a729883

remove redundant marking in auto getters


hrrrrustic Apr 26, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Unix/Interop.Errors.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
 _rawErrno = -1;
 }

 internal Error Error
 internal readonly Error Error
 {
 get { return _error; }
 }
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
 internal ulong _length;
 internal IntPtr _data;

 internal int Copy(byte[] destination, int offset)
 internal readonly int Copy(byte[] destination, int offset)
 {
 Debug.Assert(destination != null, "target destination cannot be null");
 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
 return sourceLength;
 }

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 if (_data == IntPtr.Zero || _length == 0)
 {
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
 return destination;
 }

 internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
 default;

Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
 internal short wSecond;
 internal short wMilliseconds;

 public override string ToString()
 public override readonly string ToString()
 {
 return "[SYSTEMTIME: "
 + wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
 internal IntPtr pbData;
 internal int cUnusedBits;

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 int numBytes = cbData;
 byte[] data = new byte[numBytes];
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
 public int cbData;
 public IntPtr pbData;

 public string? OID
 public readonly string? OID
 {
 get
 {
 return Marshal.PtrToStringAnsi(pszOID);
 }
 }

 public string? Name
 public readonly string? Name
 {
 get
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
 public int right;
 public int bottom;

 public Size Size => new Size(right - left, bottom - top);
 public readonly Size Size => new Size(right - left, bottom - top);
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
 internal long TicksSince1601;
#pragma warning restore CS0649

 internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
 internal IntPtr address;
 internal int addressLength;

 internal IPAddress MarshalIPAddress()
 internal readonly IPAddress MarshalIPAddress()
 {
 // Determine the address family used to create the IPAddress.
 AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
 dwHighDateTime = (uint)(fileTime >> 32);
 }

 internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 }
 }
}

8 changes: 4 additions & 4 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
 internal ushort Second;
 internal ushort Milliseconds;

 internal bool Equals(in SYSTEMTIME other) =>
 internal readonly bool Equals(in SYSTEMTIME other) =>
 Year == other.Year &&
 Month == other.Month &&
 DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
 internal fixed char TimeZoneKeyName[128];
 internal byte DynamicDaylightTimeDisabled;

 internal string GetTimeZoneKeyName()
 internal readonly string GetTimeZoneKeyName()
 {
 fixed (char* p = TimeZoneKeyName)
 return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
 *pTo = *(TIME_ZONE_INFORMATION*)pFrom;
 }

 internal string GetStandardName()
 internal readonly string GetStandardName()
 {
 fixed (char* p = StandardName)
 return new string(p);
 }

 internal string GetDaylightName()
 internal readonly string GetDaylightName()
 {
 fixed (char* p = DaylightName)
 return new string(p);
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
 public uint EaSize;

 private char _fileName;
 public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
 public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

 /// <summary>
 /// Gets the next info pointer or null if there are no more.
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
 public uint grfStateBits;
 public uint reserved;

 public string? GetName() => Marshal.PtrToStringUni(pwcsName);
 public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

 /// <summary>
 /// Caller is responsible for freeing the name memory.
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
 private IntPtr dwLower;
 private IntPtr dwUpper;

 public bool IsZero
 public readonly bool IsZero
 {
 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
 dwUpper = IntPtr.Zero;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 { return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
 }
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/System/MutableDecimal.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

 public bool IsNegative
 {
 get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
 set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
 }

 public int Scale
 {
 get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
 set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
 }

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Methods "readonly" annotation by hrrrrustic · Pull Request #46675 · dotnet/runtime · GitHub
Skip to content
Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


Methods "readonly" annotation
#46675
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a830287

Small annotation part for pr init


hrrrrustic Jan 6, 2021
a9cbfef

remaining changes


hrrrrustic Apr 26, 2021
a729883

remove redundant marking in auto getters


hrrrrustic Apr 26, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Unix/Interop.Errors.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
 _rawErrno = -1;
 }

 internal Error Error
 internal readonly Error Error
 {
 get { return _error; }
 }
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
 internal ulong _length;
 internal IntPtr _data;

 internal int Copy(byte[] destination, int offset)
 internal readonly int Copy(byte[] destination, int offset)
 {
 Debug.Assert(destination != null, "target destination cannot be null");
 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
 return sourceLength;
 }

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 if (_data == IntPtr.Zero || _length == 0)
 {
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
 return destination;
 }

 internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
 default;

Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
 internal short wSecond;
 internal short wMilliseconds;

 public override string ToString()
 public override readonly string ToString()
 {
 return "[SYSTEMTIME: "
 + wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
 internal IntPtr pbData;
 internal int cUnusedBits;

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 int numBytes = cbData;
 byte[] data = new byte[numBytes];
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
 public int cbData;
 public IntPtr pbData;

 public string? OID
 public readonly string? OID
 {
 get
 {
 return Marshal.PtrToStringAnsi(pszOID);
 }
 }

 public string? Name
 public readonly string? Name
 {
 get
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
 public int right;
 public int bottom;

 public Size Size => new Size(right - left, bottom - top);
 public readonly Size Size => new Size(right - left, bottom - top);
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
 internal long TicksSince1601;
#pragma warning restore CS0649

 internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
 internal IntPtr address;
 internal int addressLength;

 internal IPAddress MarshalIPAddress()
 internal readonly IPAddress MarshalIPAddress()
 {
 // Determine the address family used to create the IPAddress.
 AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
 dwHighDateTime = (uint)(fileTime >> 32);
 }

 internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 }
 }
}

8 changes: 4 additions & 4 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
 internal ushort Second;
 internal ushort Milliseconds;

 internal bool Equals(in SYSTEMTIME other) =>
 internal readonly bool Equals(in SYSTEMTIME other) =>
 Year == other.Year &&
 Month == other.Month &&
 DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
 internal fixed char TimeZoneKeyName[128];
 internal byte DynamicDaylightTimeDisabled;

 internal string GetTimeZoneKeyName()
 internal readonly string GetTimeZoneKeyName()
 {
 fixed (char* p = TimeZoneKeyName)
 return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
 *pTo = *(TIME_ZONE_INFORMATION*)pFrom;
 }

 internal string GetStandardName()
 internal readonly string GetStandardName()
 {
 fixed (char* p = StandardName)
 return new string(p);
 }

 internal string GetDaylightName()
 internal readonly string GetDaylightName()
 {
 fixed (char* p = DaylightName)
 return new string(p);
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
 public uint EaSize;

 private char _fileName;
 public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
 public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

 /// <summary>
 /// Gets the next info pointer or null if there are no more.
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
 public uint grfStateBits;
 public uint reserved;

 public string? GetName() => Marshal.PtrToStringUni(pwcsName);
 public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

 /// <summary>
 /// Caller is responsible for freeing the name memory.
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
 private IntPtr dwLower;
 private IntPtr dwUpper;

 public bool IsZero
 public readonly bool IsZero
 {
 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
 dwUpper = IntPtr.Zero;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 { return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
 }
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/System/MutableDecimal.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

 public bool IsNegative
 {
 get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
 set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
 }

 public int Scale
 {
 get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
 set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
 }

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Methods "readonly" annotation by hrrrrustic · Pull Request #46675 · dotnet/runtime · GitHub
Skip to content
Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


Methods "readonly" annotation
#46675
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a830287

Small annotation part for pr init


hrrrrustic Jan 6, 2021
a9cbfef

remaining changes


hrrrrustic Apr 26, 2021
a729883

remove redundant marking in auto getters


hrrrrustic Apr 26, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Unix/Interop.Errors.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
 _rawErrno = -1;
 }

 internal Error Error
 internal readonly Error Error
 {
 get { return _error; }
 }
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
 internal ulong _length;
 internal IntPtr _data;

 internal int Copy(byte[] destination, int offset)
 internal readonly int Copy(byte[] destination, int offset)
 {
 Debug.Assert(destination != null, "target destination cannot be null");
 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
 return sourceLength;
 }

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 if (_data == IntPtr.Zero || _length == 0)
 {
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
 return destination;
 }

 internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
 default;

Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
 internal short wSecond;
 internal short wMilliseconds;

 public override string ToString()
 public override readonly string ToString()
 {
 return "[SYSTEMTIME: "
 + wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
 internal IntPtr pbData;
 internal int cUnusedBits;

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 int numBytes = cbData;
 byte[] data = new byte[numBytes];
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
 public int cbData;
 public IntPtr pbData;

 public string? OID
 public readonly string? OID
 {
 get
 {
 return Marshal.PtrToStringAnsi(pszOID);
 }
 }

 public string? Name
 public readonly string? Name
 {
 get
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
 public int right;
 public int bottom;

 public Size Size => new Size(right - left, bottom - top);
 public readonly Size Size => new Size(right - left, bottom - top);
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
 internal long TicksSince1601;
#pragma warning restore CS0649

 internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
 internal IntPtr address;
 internal int addressLength;

 internal IPAddress MarshalIPAddress()
 internal readonly IPAddress MarshalIPAddress()
 {
 // Determine the address family used to create the IPAddress.
 AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
 dwHighDateTime = (uint)(fileTime >> 32);
 }

 internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 }
 }
}

8 changes: 4 additions & 4 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
 internal ushort Second;
 internal ushort Milliseconds;

 internal bool Equals(in SYSTEMTIME other) =>
 internal readonly bool Equals(in SYSTEMTIME other) =>
 Year == other.Year &&
 Month == other.Month &&
 DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
 internal fixed char TimeZoneKeyName[128];
 internal byte DynamicDaylightTimeDisabled;

 internal string GetTimeZoneKeyName()
 internal readonly string GetTimeZoneKeyName()
 {
 fixed (char* p = TimeZoneKeyName)
 return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
 *pTo = *(TIME_ZONE_INFORMATION*)pFrom;
 }

 internal string GetStandardName()
 internal readonly string GetStandardName()
 {
 fixed (char* p = StandardName)
 return new string(p);
 }

 internal string GetDaylightName()
 internal readonly string GetDaylightName()
 {
 fixed (char* p = DaylightName)
 return new string(p);
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
 public uint EaSize;

 private char _fileName;
 public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
 public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

 /// <summary>
 /// Gets the next info pointer or null if there are no more.
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
 public uint grfStateBits;
 public uint reserved;

 public string? GetName() => Marshal.PtrToStringUni(pwcsName);
 public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

 /// <summary>
 /// Caller is responsible for freeing the name memory.
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
 private IntPtr dwLower;
 private IntPtr dwUpper;

 public bool IsZero
 public readonly bool IsZero
 {
 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
 dwUpper = IntPtr.Zero;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 { return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
 }
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/System/MutableDecimal.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

 public bool IsNegative
 {
 get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
 set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
 }

 public int Scale
 {
 get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
 set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
 }

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Methods "readonly" annotation by hrrrrustic · Pull Request #46675 · dotnet/runtime · GitHub
Skip to content
Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


Methods "readonly" annotation
#46675
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a830287

Small annotation part for pr init


hrrrrustic Jan 6, 2021
a9cbfef

remaining changes


hrrrrustic Apr 26, 2021
a729883

remove redundant marking in auto getters


hrrrrustic Apr 26, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Unix/Interop.Errors.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
 _rawErrno = -1;
 }

 internal Error Error
 internal readonly Error Error
 {
 get { return _error; }
 }
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
 internal ulong _length;
 internal IntPtr _data;

 internal int Copy(byte[] destination, int offset)
 internal readonly int Copy(byte[] destination, int offset)
 {
 Debug.Assert(destination != null, "target destination cannot be null");
 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
 return sourceLength;
 }

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 if (_data == IntPtr.Zero || _length == 0)
 {
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
 return destination;
 }

 internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
 default;

Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
 internal short wSecond;
 internal short wMilliseconds;

 public override string ToString()
 public override readonly string ToString()
 {
 return "[SYSTEMTIME: "
 + wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
 internal IntPtr pbData;
 internal int cUnusedBits;

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 int numBytes = cbData;
 byte[] data = new byte[numBytes];
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
 public int cbData;
 public IntPtr pbData;

 public string? OID
 public readonly string? OID
 {
 get
 {
 return Marshal.PtrToStringAnsi(pszOID);
 }
 }

 public string? Name
 public readonly string? Name
 {
 get
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
 public int right;
 public int bottom;

 public Size Size => new Size(right - left, bottom - top);
 public readonly Size Size => new Size(right - left, bottom - top);
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
 internal long TicksSince1601;
#pragma warning restore CS0649

 internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
 internal IntPtr address;
 internal int addressLength;

 internal IPAddress MarshalIPAddress()
 internal readonly IPAddress MarshalIPAddress()
 {
 // Determine the address family used to create the IPAddress.
 AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
 dwHighDateTime = (uint)(fileTime >> 32);
 }

 internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 }
 }
}

8 changes: 4 additions & 4 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
 internal ushort Second;
 internal ushort Milliseconds;

 internal bool Equals(in SYSTEMTIME other) =>
 internal readonly bool Equals(in SYSTEMTIME other) =>
 Year == other.Year &&
 Month == other.Month &&
 DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
 internal fixed char TimeZoneKeyName[128];
 internal byte DynamicDaylightTimeDisabled;

 internal string GetTimeZoneKeyName()
 internal readonly string GetTimeZoneKeyName()
 {
 fixed (char* p = TimeZoneKeyName)
 return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
 *pTo = *(TIME_ZONE_INFORMATION*)pFrom;
 }

 internal string GetStandardName()
 internal readonly string GetStandardName()
 {
 fixed (char* p = StandardName)
 return new string(p);
 }

 internal string GetDaylightName()
 internal readonly string GetDaylightName()
 {
 fixed (char* p = DaylightName)
 return new string(p);
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
 public uint EaSize;

 private char _fileName;
 public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
 public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

 /// <summary>
 /// Gets the next info pointer or null if there are no more.
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
 public uint grfStateBits;
 public uint reserved;

 public string? GetName() => Marshal.PtrToStringUni(pwcsName);
 public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

 /// <summary>
 /// Caller is responsible for freeing the name memory.
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
 private IntPtr dwLower;
 private IntPtr dwUpper;

 public bool IsZero
 public readonly bool IsZero
 {
 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
 dwUpper = IntPtr.Zero;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 { return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
 }
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/System/MutableDecimal.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

 public bool IsNegative
 {
 get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
 set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
 }

 public int Scale
 {
 get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
 set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
 }

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Methods "readonly" annotation by hrrrrustic · Pull Request #46675 · dotnet/runtime · GitHub
Skip to content
Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


Methods "readonly" annotation
#46675
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a830287

Small annotation part for pr init


hrrrrustic Jan 6, 2021
a9cbfef

remaining changes


hrrrrustic Apr 26, 2021
a729883

remove redundant marking in auto getters


hrrrrustic Apr 26, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Unix/Interop.Errors.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
 _rawErrno = -1;
 }

 internal Error Error
 internal readonly Error Error
 {
 get { return _error; }
 }
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
 internal ulong _length;
 internal IntPtr _data;

 internal int Copy(byte[] destination, int offset)
 internal readonly int Copy(byte[] destination, int offset)
 {
 Debug.Assert(destination != null, "target destination cannot be null");
 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
 return sourceLength;
 }

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 if (_data == IntPtr.Zero || _length == 0)
 {
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
 return destination;
 }

 internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
 default;

Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
 internal short wSecond;
 internal short wMilliseconds;

 public override string ToString()
 public override readonly string ToString()
 {
 return "[SYSTEMTIME: "
 + wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
 internal IntPtr pbData;
 internal int cUnusedBits;

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 int numBytes = cbData;
 byte[] data = new byte[numBytes];
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
 public int cbData;
 public IntPtr pbData;

 public string? OID
 public readonly string? OID
 {
 get
 {
 return Marshal.PtrToStringAnsi(pszOID);
 }
 }

 public string? Name
 public readonly string? Name
 {
 get
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
 public int right;
 public int bottom;

 public Size Size => new Size(right - left, bottom - top);
 public readonly Size Size => new Size(right - left, bottom - top);
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
 internal long TicksSince1601;
#pragma warning restore CS0649

 internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
 internal IntPtr address;
 internal int addressLength;

 internal IPAddress MarshalIPAddress()
 internal readonly IPAddress MarshalIPAddress()
 {
 // Determine the address family used to create the IPAddress.
 AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
 dwHighDateTime = (uint)(fileTime >> 32);
 }

 internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 }
 }
}

8 changes: 4 additions & 4 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
 internal ushort Second;
 internal ushort Milliseconds;

 internal bool Equals(in SYSTEMTIME other) =>
 internal readonly bool Equals(in SYSTEMTIME other) =>
 Year == other.Year &&
 Month == other.Month &&
 DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
 internal fixed char TimeZoneKeyName[128];
 internal byte DynamicDaylightTimeDisabled;

 internal string GetTimeZoneKeyName()
 internal readonly string GetTimeZoneKeyName()
 {
 fixed (char* p = TimeZoneKeyName)
 return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
 *pTo = *(TIME_ZONE_INFORMATION*)pFrom;
 }

 internal string GetStandardName()
 internal readonly string GetStandardName()
 {
 fixed (char* p = StandardName)
 return new string(p);
 }

 internal string GetDaylightName()
 internal readonly string GetDaylightName()
 {
 fixed (char* p = DaylightName)
 return new string(p);
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
 public uint EaSize;

 private char _fileName;
 public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
 public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

 /// <summary>
 /// Gets the next info pointer or null if there are no more.
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
 public uint grfStateBits;
 public uint reserved;

 public string? GetName() => Marshal.PtrToStringUni(pwcsName);
 public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

 /// <summary>
 /// Caller is responsible for freeing the name memory.
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
 private IntPtr dwLower;
 private IntPtr dwUpper;

 public bool IsZero
 public readonly bool IsZero
 {
 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
 dwUpper = IntPtr.Zero;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 { return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
 }
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/System/MutableDecimal.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

 public bool IsNegative
 {
 get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
 set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
 }

 public int Scale
 {
 get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
 set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
 }

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Methods "readonly" annotation by hrrrrustic · Pull Request #46675 · dotnet/runtime · GitHub
Skip to content
Methods "readonly" annotation#46675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


Methods "readonly" annotation
#46675
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a830287

Small annotation part for pr init


hrrrrustic Jan 6, 2021
a9cbfef

remaining changes


hrrrrustic Apr 26, 2021
a729883

remove redundant marking in auto getters


hrrrrustic Apr 26, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Unix/Interop.Errors.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -130,7 +130,7 @@ internal ErrorInfo(Error error)
 _rawErrno = -1;
 }

 internal Error Error
 internal readonly Error Error
 {
 get { return _error; }
 }
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Unix/System.Net.Security.Native/Interop.GssBuffer.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ internal struct GssBuffer : IDisposable
 internal ulong _length;
 internal IntPtr _data;

 internal int Copy(byte[] destination, int offset)
 internal readonly int Copy(byte[] destination, int offset)
 {
 Debug.Assert(destination != null, "target destination cannot be null");
 Debug.Assert((offset >= 0 && offset < destination.Length) || destination.Length == 0, "invalid offset " + offset);
Expand All@@ -38,7 +38,7 @@ internal int Copy(byte[] destination, int offset)
 return sourceLength;
 }

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 if (_data == IntPtr.Zero || _length == 0)
 {
Expand All@@ -51,7 +51,7 @@ internal byte[] ToByteArray()
 return destination;
 }

 internal unsafe ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 internal unsafe readonly ReadOnlySpan<byte> Span => (_data != IntPtr.Zero && _length != 0) ?
 new ReadOnlySpan<byte>(_data.ToPointer(), checked((int)_length)) :
 default;

Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.PERF_INFO.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,7 @@ internal struct SYSTEMTIME
 internal short wSecond;
 internal short wMilliseconds;

 public override string ToString()
 public override readonly string ToString()
 {
 return "[SYSTEMTIME: "
 + wDay.ToString(CultureInfo.CurrentCulture) + "/" + wMonth.ToString(CultureInfo.CurrentCulture) + "/" + wYear.ToString(CultureInfo.CurrentCulture)
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.CRYPT_BIT_BLOB.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ internal struct CRYPT_BIT_BLOB
 internal IntPtr pbData;
 internal int cUnusedBits;

 internal byte[] ToByteArray()
 internal readonly byte[] ToByteArray()
 {
 int numBytes = cbData;
 byte[] data = new byte[numBytes];
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/Crypt32/Interop.FindOidInfo.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,15 @@ internal struct CRYPT_OID_INFO
 public int cbData;
 public IntPtr pbData;

 public string? OID
 public readonly string? OID
 {
 get
 {
 return Marshal.PtrToStringAnsi(pszOID);
 }
 }

 public string? Name
 public readonly string? Name
 {
 get
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Gdi32/Interop.RECT.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ public struct RECT
 public int right;
 public int bottom;

 public Size Size => new Size(right - left, bottom - top);
 public readonly Size Size => new Size(right - left, bottom - top);
 }
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Interop.LongFileTime.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ internal struct LongFileTime
 internal long TicksSince1601;
#pragma warning restore CS0649

 internal DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 internal readonly DateTimeOffset ToDateTimeOffset() => new DateTimeOffset(DateTime.FromFileTimeUtc(TicksSince1601));
 }
}

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/IpHlpApi/Interop.NetworkInformation.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ internal struct IpSocketAddress
 internal IntPtr address;
 internal int addressLength;

 internal IPAddress MarshalIPAddress()
 internal readonly IPAddress MarshalIPAddress()
 {
 // Determine the address family used to create the IPAddress.
 AddressFamily family = (addressLength > Internals.SocketAddress.IPv4AddressSize)
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.FILE_TIME.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@ internal FILE_TIME(long fileTime)
 dwHighDateTime = (uint)(fileTime >> 32);
 }

 internal long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 internal readonly long ToTicks() => ((long)dwHighDateTime << 32) + dwLowDateTime;
 internal readonly DateTime ToDateTimeUtc() => DateTime.FromFileTimeUtc(ToTicks());
 internal readonly DateTimeOffset ToDateTimeOffset() => DateTimeOffset.FromFileTime(ToTicks());
 }
 }
}

8 changes: 4 additions & 4 deletions
src/libraries/Common/src/Interop/Windows/Kernel32/Interop.TimeZone.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ internal struct SYSTEMTIME
 internal ushort Second;
 internal ushort Milliseconds;

 internal bool Equals(in SYSTEMTIME other) =>
 internal readonly bool Equals(in SYSTEMTIME other) =>
 Year == other.Year &&
 Month == other.Month &&
 DayOfWeek == other.DayOfWeek &&
Expand All@@ -42,7 +42,7 @@ internal unsafe struct TIME_DYNAMIC_ZONE_INFORMATION
 internal fixed char TimeZoneKeyName[128];
 internal byte DynamicDaylightTimeDisabled;

 internal string GetTimeZoneKeyName()
 internal readonly string GetTimeZoneKeyName()
 {
 fixed (char* p = TimeZoneKeyName)
 return new string(p);
Expand All@@ -68,13 +68,13 @@ internal TIME_ZONE_INFORMATION(in TIME_DYNAMIC_ZONE_INFORMATION dtzi)
 *pTo = *(TIME_ZONE_INFORMATION*)pFrom;
 }

 internal string GetStandardName()
 internal readonly string GetStandardName()
 {
 fixed (char* p = StandardName)
 return new string(p);
 }

 internal string GetDaylightName()
 internal readonly string GetDaylightName()
 {
 fixed (char* p = DaylightName)
 return new string(p);
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/NtDll/Interop.FILE_FULL_DIR_INFORMATION.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public struct FILE_FULL_DIR_INFORMATION
 public uint EaSize;

 private char _fileName;
 public unsafe ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }
 public unsafe readonly ReadOnlySpan<char> FileName { get { fixed (char* c = &_fileName) { return new ReadOnlySpan<char>(c, (int)FileNameLength / sizeof(char)); } } }

 /// <summary>
 /// Gets the next info pointer or null if there are no more.
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/Common/src/Interop/Windows/Ole32/Interop.STATSTG.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ internal struct STATSTG
 public uint grfStateBits;
 public uint reserved;

 public string? GetName() => Marshal.PtrToStringUni(pwcsName);
 public readonly string? GetName() => Marshal.PtrToStringUni(pwcsName);

 /// <summary>
 /// Caller is responsible for freeing the name memory.
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct CredHandle
 private IntPtr dwLower;
 private IntPtr dwUpper;

 public bool IsZero
 public readonly bool IsZero
 {
 [MethodImpl(MethodImplOptions.AggressiveInlining)]
 get
Expand All@@ -38,7 +38,7 @@ internal void SetToInvalid()
 dwUpper = IntPtr.Zero;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 { return dwLower.ToString("x") + ":" + dwUpper.ToString("x"); }
 }
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/Common/src/System/MutableDecimal.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal struct MutableDecimal

 public bool IsNegative
 {
 get { return (Flags & SignMask) != 0; }
readonly get { return (Flags & SignMask) != 0; }
 set { Flags = (Flags & ~SignMask) | (value ? SignMask : 0); }
 }

 public int Scale
 {
 get { return (byte)(Flags >> ScaleShift); }
readonly get { return (byte)(Flags >> ScaleShift); }
 set { Flags = (Flags & ~ScaleMask) | ((uint)value << ScaleShift); }
 }

Expand Down
Loading