') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); More arities for tuple returning zip extension method by huoyaoyuan · Pull Request #47147 · dotnet/runtime · GitHub
Skip to content

More arities for tuple returning zip extension method - #47147

Merged
eiriktsarpalis merged 10 commits into
dotnet:masterfrom
huoyaoyuan:zip-tuple
Jan 19, 2021
Merged

More arities for tuple returning zip extension method#47147
eiriktsarpalis merged 10 commits into
dotnet:masterfrom
huoyaoyuan:zip-tuple

Conversation

@huoyaoyuan

@huoyaoyuanhuoyaoyuan commented Jan 19, 2021

Copy link
Copy Markdown
Member

Closes#43702

It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.

@ghost

ghost commented Jan 19, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Jan 19, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #43702

It grows exponentially for test exhaustiveness. I'm just focusing on the third parameter.

Author:huoyaoyuan
Assignees:-
Labels:

area-System.Linq, new-api-needs-documentation

Milestone:-

eiriktsarpalis
eiriktsarpalis reviewed Jan 19, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq/tests/ZipTests.cs Outdated
eiriktsarpalis
eiriktsarpalis approved these changes Jan 19, 2021
View reviewed changes

@eiriktsarpaliseiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution!

stephentoub
stephentoub reviewed Jan 19, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq/src/System/Linq/Zip.cs Outdated
stephentoub
stephentoub reviewed Jan 19, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq/tests/ZipTests.cs Outdated
stephentoub
stephentoub reviewed Jan 19, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq/tests/ZipTests.cs Outdated
stephentoub
stephentoub reviewed Jan 19, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq/tests/ZipTests.cs Outdated
stephentoub
stephentoub reviewed Jan 19, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq.Queryable/src/System/Linq/CachedReflection.cs
public static MethodInfo Zip_TFirst_TSecond_TThird_3(Type TFirst, Type TSecond, Type TThird) =>
(s_Zip_TFirst_TSecond_TThird_3 ??
(s_Zip_TFirst_TSecond_TThird_3 = new Func<IQueryable<object>, IEnumerable<object>, IEnumerable<object>, IQueryable<(object, object, object)>>(Queryable.Zip).GetMethodInfo().GetGenericMethodDefinition()))
.MakeGenericMethod(TFirst, TSecond, TThird);

@stephentoubstephentoubJan 19, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment saying ??= could be used to simplify this, but I see you're just following the pattern used in a bunch of other cases above. We can clean it up later.

huoyaoyuan
huoyaoyuan commented Jan 19, 2021
View reviewed changes

@huoyaoyuanhuoyaoyuan left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR feedbacks

@huoyaoyuan@stephentoub@eiriktsarpalis
PR feedbacks
e751e70
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
@eiriktsarpalis

eiriktsarpalis commented Jan 19, 2021

Copy link
Copy Markdown
Member

Thanks for the contribution!

@eiriktsarpalis
eiriktsarpalis merged commit 6fb9985 into dotnet:masterJan 19, 2021
@Logerfo

Logerfo commented Jan 19, 2021

Copy link
Copy Markdown

Thank you! In which runtime version is this feature supposed to be available?

@eiriktsarpalis

eiriktsarpalis commented Jan 19, 2021

Copy link
Copy Markdown
Member

That would be released with .NET 6 next November.

@huoyaoyuan
huoyaoyuan deleted the zip-tuple branch January 19, 2021 16:07
@eiriktsarpaliseiriktsarpalis mentioned this pull request Jan 21, 2021
Closed
6 tasks
@ghostghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes

Assignees

No one assigned

Labels

area-System.Linqnew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

More arities for tuple returning zip extension method

4 participants

@huoyaoyuan@eiriktsarpalis@Logerfo@stephentoub