[browser] Fix System.Delegate.DynamicInvoke method can not be resolved by kjpou1 · Pull Request #47519 · dotnet/runtime

kjpou1 · 2021-01-27T10:13:05Z

When building an app using <PublishTrimmed>true</PublishTrimmed> the linker is linking out System.Delegate.DynamicInvoke
Call Delegate Invoke directly

Remove dependency on System.Delegate.DynamicInvoke

Explicitly provide the declaring type to GetMethodFromHandle in GetCallSignature

Fixes error resolving generic method handles.

 Error: System.ArgumentException: Cannot resolve method Int32 Invoke(Int32, Int32) because the declaring type of the method handle System.Func`3[T1,T2,TResult] is generic. Explicitly provide the declaring type to GetMethodFromHandle.

Add method to retrieve the Invoke method of the delegate

Added delegate tests.

Fix#47516

- When building an app using <PublishTrimmed>true</PublishTrimmed> the linker is linking out System.Delegate.DynamicInvoke - Add this to the linker trim exclusions.

ghost · 2021-01-27T10:13:09Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

ghost · 2021-01-27T10:13:54Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

When building an app using true the linker is linking out System.Delegate.DynamicInvoke
Add this to the linker trim exclusions.

Author:	kjpou1
Assignees:	kjpou1
Labels:	`arch-wasm`
Milestone:	-

``` resource System.Private.Runtime.InteropServices.JavaScript.xml in System.Private.Runtime.InteropServices.JavaScript, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a : warning IL2007: Could not resolve assembly 'System.Private.CoreLib' [/src/libraries/System.Private.Runtime.InteropServices.JavaScript/src/System.Private.Runtime.InteropServices.JavaScript.csproj] 1 Warning(s) 0 Error(s) ```

…fix-delegate-trimming

…voke

- Explicitly provide the declaring type to GetMethodFromHandle in GetCallSignature - Fixes error resolving generic method handles. ``` Error: System.ArgumentException: Cannot resolve method Int32 Invoke(Int32, Int32) because the declaring type of the method handle System.Func`3[T1,T2,TResult] is generic. Explicitly provide the declaring type to GetMethodFromHandle. ```

… a Function

…fix-delegate-trimming

kjpou1 · 2021-02-04T12:42:46Z

@marek-safar @lewing @radical

…fix-delegate-trimming # Conflicts: # src/libraries/System.Private.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs

[browser] Fix System.Delegate.DynamicInvoke method can not be resolved
377a8e4
- When building an app using <PublishTrimmed>true</PublishTrimmed> the linker is linking out System.Delegate.DynamicInvoke - Add this to the linker trim exclusions.

kjpou1 requested review from eerhardt, lewing, marek-safar and steveisok January 27, 2021 10:13

kjpou1 self-assigned this Jan 27, 2021

kjpou1 added the arch-wasm WebAssembly architecture label Jan 27, 2021

kjpou1 added the area-System.Runtime.InteropServices label Jan 27, 2021

kjpou1 added this to the 6.0.0 milestone Jan 27, 2021

marek-safar reviewed Jan 27, 2021
View reviewed changes

Comment threadsrc/libraries/System.Private.Runtime.InteropServices.JavaScript/src/ILLink/ILLinkTrim.xml Outdated

marek-safar reviewed Jan 27, 2021
View reviewed changes

Comment threadsrc/libraries/System.Private.Runtime.InteropServices.JavaScript/src/ILLink/ILLinkTrim.xml Outdated

Address review comment for assembly name
ddb0485

kjpou1 requested a review from marek-safar January 27, 2021 13:57

eerhardt reviewed Jan 27, 2021
View reviewed changes

Comment threadsrc/libraries/System.Private.Runtime.InteropServices.JavaScript/src/ILLink/ILLinkTrim.xml Outdated

kjpou1 added 7 commits January 29, 2021 05:16

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto wasm-…
e6e8d34
…fix-delegate-trimming

[browser] Remove linker trim exclusions for System.Delegate.DynamicIn…
ab9ae20
…voke

Add method to retrieve the Invoke method of the delegate
255be2f

Create another test module for Delegate tests
7203cbf

Add MarshalFunctionReturnAction that marshals an Action delegate from…
cbbcbd9
… a Function

More tests, Actions and Delegate methods
7145696

kjpou1 requested a review from eerhardt January 29, 2021 11:06

lewing requested review from kg, lambdageek and radical January 30, 2021 03:58

kjpou1 added 2 commits February 1, 2021 05:19

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto wasm-…
fb8247d
…fix-delegate-trimming

Add multi cast tests
1c65efd

kjpou1 added 2 commits February 1, 2021 07:10

Add anon and lamda del test
019c642

Add tests for marshaling TypedArray from different delegates.
7f964e9

This was referenced Feb 1, 2021
System.Threading.Tasks.Tests timed out on net5.0-Linux-Debug-arm64-Mono_release #42024
Closed
Inability to unzip assets during build on Unix x64 #32805
Closed

radical reviewed Feb 1, 2021
View reviewed changes

Comment threadsrc/mono/wasm/runtime/binding_support.js

radical reviewed Feb 1, 2021
View reviewed changes

kjpou1 added 7 commits February 2, 2021 05:16

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto wasm-…
6a61e70
…fix-delegate-trimming

Address review comment. Remove unused variable argsroot.
5571af1

Remove extra assert as per review
823b67c

Address review of switched expected
28db172

As per review comment Rename all Marshal method names to Invoke
58548c6

Add more array type tests for delegates.
81a375a

Combine Delegate tests and Multi Cast delegate tests
a19b8ca

kjpou1 requested a review from radical February 2, 2021 10:54

kjpou1 mentioned this pull request Feb 5, 2021
Wasm marshaler API for user-defined types; migrate Uri and DateTime to new API #47640
Closed

kjpou1 added 2 commits February 10, 2021 06:01

Merge branch 'master' ofhttps://github.com/dotnet/runtimeinto wasm-…
6ac1cb8
…fix-delegate-trimming # Conflicts: # src/libraries/System.Private.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs

Fix accessor after merge conflict
b1f78ad

marek-safar approved these changes Feb 10, 2021
View reviewed changes

marek-safar merged commit eab1b43 into dotnet:masterFeb 10, 2021

kjpou1 deleted the wasm-fix-delegate-trimming branch February 10, 2021 10:49

runfoappBot mentioned this pull request Feb 10, 2021
slicebuffers_success variant tests failing sporadically #47734
Closed

ghost locked as resolved and limited conversation to collaborators Mar 12, 2021

Navigation Menu

Uh oh!

[browser] Fix System.Delegate.DynamicInvoke method can not be resolved - #47519

[browser] Fix System.Delegate.DynamicInvoke method can not be resolved#47519
marek-safar merged 23 commits into
dotnet:masterfrom
kjpou1:wasm-fix-delegate-trimming

kjpou1 commented Jan 27, 2021•
edited
Loading

Uh oh!

ghost commented Jan 27, 2021

Uh oh!

ghost commented Jan 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kjpou1 commented Feb 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

kjpou1 commented Jan 27, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 27, 2021

Uh oh!

ghost commented Jan 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kjpou1 commented Feb 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kjpou1 commented Jan 27, 2021•
edited
Loading