Fix Socket test failure ClosedDuringOperation_Throws_ObjectDisposedExceptionOrSocketException

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.

[antonfirsov]

Fixes#47561.

#47229 introduced a test with a timing race. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

@geoffkizer@wfurt PTAL

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47561.

There is a timing race in the test. In sync case Dispose may happen before the operation is started. (Thread pool starvation defers Task.Run() stuff in SocketTestHelper?)

Author:	antonfirsov
Assignees:	-
Labels:	area-System.Net.Sockets
Milestone:	-

[antonfirsov]

Test failure is #43928.

[wfurt]

why the msDelay chages hare. I don't see it used laster. Also the seems generally problematic as the time needed can vary greatly across platforms. Would it work if we simply accept either exception if we feel that should be expected?

[antonfirsov]

I don't see it used later.

The test is being retried 10 times in the sync case, doubling the delay time on each failure:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveFrom.cs

Line 118 in 7adf3db

awaitRetryHelper.ExecuteAsync(()=>RunTestAsync(),maxAttempts:10,retryWhen: e =>eisXunitException);

the time needed can vary greatly across platforms

The retry mechanism is here to address this. Most of the times the test will succeed within the 100ms delay. On slow platforms / high CI load, first attempts will fail with an ObjectDisposedException, but eventually one of the subsequent retries will observe a SocketException

I adapted this practice from an existing test introduced in dotnet/corefx#38804:

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs

Lines 938 to 943 in 7adf3db

	// We try this a couple of times to deal with a timing race: if the Dispose happens
	// before the operation is started, the peer won't see a ConnectionReset SocketException and we won't
	// see a SocketException either.
	intmsDelay=100;
	awaitRetryHelper.ExecuteAsync(async()=>
	{

[geoffkizer]

I hate that the test param is named closeOrDispose, that's a terrible name for a bool param. But that predates this PR so not something to block on.