Add Enumerable.TryGetNonEnumeratedCount (Implements #27183) by eiriktsarpalis · Pull Request #48239 · dotnet/runtime

eiriktsarpalis · 2021-02-12T20:17:37Z

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

eiriktsarpalis · 2021-02-12T20:17:37Z

Fix#27183.

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27183.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

eiriktsarpalis · 2021-02-12T20:17:37Z

Fix#27183.

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27183.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

eiriktsarpalis · 2021-02-12T20:17:37Z

Fix#27183.

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27183.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

eiriktsarpalis · 2021-02-12T20:17:37Z

Fix#27183.

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27183.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

eiriktsarpalis · 2021-02-12T20:17:37Z

Fix#27183.

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27183.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

eiriktsarpalis · 2021-02-12T20:17:37Z

Fix#27183.

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27183.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

eiriktsarpalis · 2021-02-12T20:17:37Z

Fix#27183.

ghost · 2021-02-12T20:17:40Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27183.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Linq`
Milestone:	6.0.0

ghost · 2021-02-12T20:17:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

stephentoub

Other than the build breaks, LGTM.

stephentoub · 2021-02-14T00:25:31Z

 {
 int itemCount;
- if (EnumerableHelpers.TryGetCount(items, out itemCount))
+ if (System.Linq.Enumerable.TryGetNonEnumeratedCount(items, out itemCount))


Nit: using System.Linq;

I wanted to avoid bringing all the enumerable methods into scope since this is a System.Collections namespace.

alrz · 2021-02-15T04:51:39Z

+ /// The method is typically a constant-time operation, but ultimately this depends on the complexity
+ /// characteristics of the underlying collection implementation.
+ /// </remarks>
+ public static bool TryGetNonEnumeratedCount<TSource>(this IEnumerable<TSource> source, out int count)


This doesn't need to be generic? if it does, I think a non-generic overload would also make sense.
(roslyn is considering using this method as part of list pattern lowering, we probably don't want to skip it for IEnumerable see https://github.com/dotnet/csharplang/blob/master/meetings/2021/LDM-2021-02-03.md).

We could do that, however it becomes more difficult to check for generic interfaces, which would require some form of reflection.

which would require some form of reflection.
That's definitely a no-go because the point of using this is performance. Perhaps those generic interfaces need a non-generic base with Count prop. IMO TryGetNonEnumeratedCount shouldn't care about TSource.

eiriktsarpalis · 2021-02-15T17:15:10Z

Linker test build failures seem unrelated to the change.

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

implement Enumerable.TryGetEnumeratingCount
378fc7c

eiriktsarpalis added the area-System.Linq label Feb 12, 2021

eiriktsarpalis added this to the 6.0.0 milestone Feb 12, 2021

eiriktsarpalis self-assigned this Feb 12, 2021

ghost added the new-api-needs-documentation label Feb 12, 2021

eiriktsarpalis commented Feb 12, 2021
View reviewed changes

Comment threadsrc/libraries/System.Linq/src/System/Linq/Count.cs

eiriktsarpalis changed the title ~~Add Enumerable.TryGetEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)Feb 12, 2021

stephentoub reviewed Feb 12, 2021
View reviewed changes

eiriktsarpalis added 4 commits February 12, 2021 21:28

address feedback
6b140e6

update consistency tests
39fd614

Replace EnumerableHelpers.TryGetCount with new method
7b2f59c

Rename to method name as approved
4f8023a

eiriktsarpalis changed the title ~~Add Enumerable.TryGetNonEnumeratingCount (Implements #27183)~~Add Enumerable.TryGetNonEnumeratedCount (Implements #27183)Feb 13, 2021

stephentoub approved these changes Feb 14, 2021
View reviewed changes

alrz reviewed Feb 15, 2021
View reviewed changes

make method is renamed in all projects
331fd78

eiriktsarpalis merged commit d687544 into dotnet:masterFeb 15, 2021

eiriktsarpalis deleted the enumerable-trygetnonenumeratingcount branch February 15, 2021 17:15

This was referenced Feb 15, 2021
Add LINQ APIs for Index and Range (#28776) #47950
Closed
Developers have their top System.Linq feature requests implemented #47231
Closed

ghost locked as resolved and limited conversation to collaborators Mar 17, 2021

Uh oh!

Conversation

eiriktsarpalis commented Feb 12, 2021

Uh oh!

ghost commented Feb 12, 2021

Uh oh!

ghost commented Feb 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephentoub left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alrzFeb 15, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eiriktsarpalis commented Feb 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

eiriktsarpalis commented Feb 12, 2021

Uh oh!

ghost commented Feb 12, 2021

Uh oh!

ghost commented Feb 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephentoub left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alrzFeb 15, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eiriktsarpalis commented Feb 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

alrzFeb 15, 2021•
edited
Loading

alrzFeb 15, 2021•
edited
Loading

alrzFeb 15, 2021•
edited
Loading