Skip to content

Make sure event generation is incremental - #48903

Merged
hoyosjs merged 1 commit into
dotnet:mainfrom
hoyosjs:juhoyosa/make-eventing-incremental
Mar 9, 2021
Merged

Make sure event generation is incremental#48903
hoyosjs merged 1 commit into
dotnet:mainfrom
hoyosjs:juhoyosa/make-eventing-incremental

Conversation

@hoyosjs

@hoyosjshoyosjs commented Mar 1, 2021

Copy link
Copy Markdown
Member

@agocke this is what you were seeing. After this there's only some issues with an RC file embedding.

@hoyosjshoyosjs added the area-Infrastructure-coreclr Only use for closed issues label Mar 1, 2021
@hoyosjshoyosjs self-assigned this Mar 1, 2021
@ghost

ghost commented Mar 1, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

@agocke this is what you were seeing. After this there's only some issues with an RC file embedding.

Author:hoyosjs
Assignees:hoyosjs
Labels:

area-Infrastructure-coreclr

Milestone:-

@runfoapprunfoappBot mentioned this pull request Mar 1, 2021
Open
@hoyosjs

hoyosjs commented Mar 2, 2021

Copy link
Copy Markdown
MemberAuthor

Related to #47022

@ViktorHofer

ViktorHofer commented Mar 3, 2021

Copy link
Copy Markdown
Member

@directhex@akoeplinger@vargaz could someone of you please take a look at this cmake incrementality fix? We are currently short on cmake experts on our team :)

@agocke

agocke commented Mar 6, 2021

Copy link
Copy Markdown
Member

Why do we have to have explicit timestamp files? Are they just dummy files that we keep for other steps to depend on?

I presume there are other outputs and you just preferred not to relist all of them as dependencies?

@hoyosjs

hoyosjs commented Mar 6, 2021

Copy link
Copy Markdown
MemberAuthor

It's a common pattern in CMake to have a single output to represent the running of a target, and let it be a timestamp cmake generates. This is particularly common for places where you have a binary, and you modify it (so you don't generate what looks like a cycle). Also makes the "needs to run" comparison trivial. Yes, you could use byproducts and outputs, but this just felt easier and standard to do this.

agocke
agocke approved these changes Mar 6, 2021
View reviewed changes

@agockeagocke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mac test failures don't look related to me

@hoyosjs

hoyosjs commented Mar 9, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run

@azure-pipelines

azure-pipelinesBot commented Mar 9, 2021

Copy link
Copy Markdown
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ghost

ghost commented Mar 9, 2021

Copy link
Copy Markdown

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@hoyosjs

hoyosjs commented Mar 9, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Mar 9, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@hoyosjs

hoyosjs commented Mar 9, 2021

Copy link
Copy Markdown
MemberAuthor

This change doesn't affect Mono.

@hoyosjs
hoyosjs merged commit f7072ec into dotnet:mainMar 9, 2021
@hoyosjs
hoyosjs deleted the juhoyosa/make-eventing-incremental branch March 9, 2021 22:13
thaystg added a commit to thaystg/runtime that referenced this pull request Mar 10, 2021
@thaystg
Merge remote-tracking branch 'upstream/main' into thays_fix_49193
18f2c88
* upstream/main: (83 commits)
Fix a crash in llvm if the sreg of a setret is not set because the methods ends with a throw. (dotnet#49122)
[macOS-arm64] Disable failing libraries tests (dotnet#49400)
improve PriorityQueue documentation (dotnet#49392)
[wasm] Fix debugger tests (dotnet#49206)
[mono] Fix the emission of EnumEqualityComparer instances into the corlib AOT image. (dotnet#49402)
jitutils M2M renaming reaction (dotnet#49430)
WinHttpHandler: Read HTTP/2 trailing headers
[RyuJIT] Make casthelpers cold for sealed classes (dotnet#49295)
JIT: Non-void ThrowHelpers (dotnet#48589)
Update package index for servicing (dotnet#49417)
Remove unnecessary check on polymorphic serialization (dotnet#48464)
Remove release build cron triggers from jitstress jobs (dotnet#49333)
[main] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/runtime-assets (dotnet#49359)
Implement AppleCryptoNative_X509GetRawData using SecCertificateCopyData
[AndroidCrypto] Support a zero-length salt for HMACs. (dotnet#49384)
Use managed implementation of pbkdf2 for Android's one-shot implementation. (dotnet#49314)
Make 303 redirects do GET like Net Framework (dotnet#49095)
Make sure event generation is incremental (dotnet#48903)
Add amd and Surface arm64 perf runs (dotnet#49389)
Enregister EH var that are single def (dotnet#47307)
...
@ghostghost locked as resolved and limited conversation to collaborators Apr 8, 2021
@karelzkarelz added this to the 6.0.0 milestone May 20, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@agockeagockeagocke approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@sywhangsywhangAwaiting requested review from sywhang

Assignees

@hoyosjshoyosjs

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hoyosjs@ViktorHofer@agocke@karelz