Skip to content

Implement Enumerable.*By methods (DistinctBy, ExceptBy, IntersectBy, UnionBy, MinBy, MaxBy) - #50335

Merged
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:distinct-by
Apr 9, 2021
Merged

Implement Enumerable.*By methods (DistinctBy, ExceptBy, IntersectBy, UnionBy, MinBy, MaxBy)#50335
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:distinct-by

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Mar 28, 2021

Copy link
Copy Markdown
Member

Fix#27687.

Note that the implementation does not include the following overloads:

publicstaticIEnumerable<TSource>ExceptBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector);publicstaticIEnumerable<TSource>ExceptBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector,IEqualityComparer<TKey>?comparer);publicstaticIEnumerable<TSource>IntersectBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector);publicstaticIEnumerable<TSource>IntersectBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector,IEqualityComparer<TKey>?comparer);

I have decided to remove them since they were causing type inference issues and can be expressed trivially in terms of the other ExceptBy and IntersectBy overloads.

@eiriktsarpaliseiriktsarpalis added this to the 6.0.0 milestone Mar 28, 2021
@eiriktsarpaliseiriktsarpalis self-assigned this Mar 28, 2021
@ghost

ghost commented Mar 28, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Mar 28, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #27687.

Note that the implementation does not include the following overloads:

publicstaticIEnumerable<TSource>ExceptBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector);publicstaticIEnumerable<TSource>ExceptBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector,IEqualityComparer<TKey>?comparer);publicstaticIEnumerable<TSource>IntersectBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector);publicstaticIEnumerable<TSource>IntersectBy<TSource,TKey>(thisIEnumerable<TSource>first,IEnumerable<TSource>second,Func<TSource,TKey>keySelector,IEqualityComparer<TKey>?comparer);

I have decided to remove them since they were causing type inference issues and can be expressed trivially in terms of the other ExceptBy and IntersectBy overloads.

Author:eiriktsarpalis
Assignees:eiriktsarpalis
Labels:

area-System.Linq

Milestone:6.0.0

stephentoub
stephentoub reviewed Mar 29, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq/src/System/Linq/Distinct.cs Outdated
@eiriktsarpaliseiriktsarpalis mentioned this pull request Mar 29, 2021
Closed
6 tasks
stephentoub
stephentoub approved these changes Apr 9, 2021
View reviewed changes
Comment threadsrc/libraries/System.Linq/src/System/Linq/Distinct.cs Outdated
Comment threadsrc/libraries/System.Linq/src/System/Linq/Max.cs
Comment threadsrc/libraries/System.Linq/src/System/Linq/Distinct.cs
@eiriktsarpalis@stephentoub
Update src/libraries/System.Linq/src/System/Linq/Distinct.cs
c9d275b
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@eiriktsarpalis
eiriktsarpalis merged commit abd01f5 into dotnet:mainApr 9, 2021
@eiriktsarpalis
eiriktsarpalis deleted the distinct-by branch April 9, 2021 21:32
cleoold added a commit to cleoold/types-linq that referenced this pull request May 6, 2021
@cleoold
Rename max_by() and min_by() to maxima_by() and minima_by()
c86d31f
The new linq api introduces MaxBy() and MinBy() dotnet/runtime#50335 which are different from morelinq's impl which I was referencing. To avoid conflicts, rename the my methods.
maxima_by() sounds like a more appropriate name..
Also except_by() according to the link is interesting...
@ghostghost locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo left review comments
@stephentoubstephentoubstephentoub approved these changes
@layomialayomiaAwaiting requested review from layomia

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Linqnew-api-needs-documentation

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Add Enumerable.*By operators (DistinctBy, ExceptBy, IntersectBy, UnionBy, MinBy, MaxBy)

3 participants

@eiriktsarpalis@EgorBo@stephentoub