Uh oh!
There was an error while loading. Please reload this page.
Simplify mibc usage in the build - #50536
Conversation
davidwrighton
commented
Apr 1, 2021
- Produce a merged mibc with all scenarios squished together
- Properly attach the mibc data to the incremental build for System.Private.CoreLib
- This can't be done for the framework here. It will require mibc integration in the SDK
- Enable pgo optimization in checked builds
- Enable pgo optimization in framework compile for outerloop runs
ghost
commented
Apr 1, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
davidwrighton
commented
Apr 1, 2021
@dotnet/crossgen-contrib once #50364 is merged, I'm going to run a test pass to verify everything is working with this. |
There was a problem hiding this comment.
Should EnableNgenOptimization be renamed?
There was a problem hiding this comment.
Do we want to produce some warnings when no MIBC data is available? Or, alternatively, should we print the files that were found or at least the number of files found? Especially for lab runs this might simplify various investigations.
There was a problem hiding this comment.
The build log will contain the list of mibc files processed as part of the standard output from the dotnet-pgo tool. Also, it will fail if there isn't any input data.
AndyAyersMS
commented
Apr 1, 2021
This is flowing the same PGO data into Checked as it does into Release, right? |
davidwrighton
commented
Apr 2, 2021
Yes. We only produce one set of data. |
- Produce a merged mibc with all scenarios squished together - Properly attach the mibc data to the incremental build for System.Private.CoreLib - This can't be done for the framework here. It will require mibc integration in the SDK - Enable pgo optimization in checked builds - Enable pgo optimization in framework compile for outerloop runs
33c01b0 to
5633627Compare