JIT: Improve inliner (constant feeds constant test, foldable calls) by EgorBo · Pull Request #50784 · dotnet/runtime

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

EgorBo · 2021-04-06T14:30:56Z

Contribution to @tannergooding's work in #50675

staticvoidTest(){CheckHW();}staticvoidCheckHW(){if(!Avx2.IsSupported){Console.WriteLine("No AVX2 :(");}}

Current codegen for Test:

G_M24707_IG01:  4883EC28 subrsp,40G_M24707_IG02:  E8EF5CFEFF call CheckHW() ;; <-- not inlined90nopG_M24707_IG03:  4883C428 addrsp,40 C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate callsite is boring. Multiplier increased to 2.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=2.3; threshold=126; Native estimate for function size exceeds threshold for inlining 26.8 > 12.6 (multiplier = 2.3)

New codegen for Test:

G_M24707_IG01: G_M24707_IG02:  C3 ret; weight= 79 : state 40 [ call ]; weight= 25 : state 45 [ brtrue.s ]; weight= 66 : state 102 [ ldstr ]; weight= 79 : state 40 [ call ]; weight= 19 : state 42 [ ret ]; ; Inline candidate looks like a wrapper method. Multiplier increased to 1.; Inline candidate has an arg that feeds a constant test. Multiplier increased to 2.; Inline candidate has 1 call(s) which is guaranteed to be folded; Inline candidate has const arg that feeds a conditional. Multiplier increased to 5.; Inline candidate callsite is boring. Multiplier increased to 6.3.; calleeNativeSizeEstimate=268; callsiteNativeSizeEstimate=55; benefit multiplier=6.3; threshold=346; Native estimate for function size is within threshold for inlining 26.8 <= 34.6 (multiplier = 6.3)

As far as I understand we're going to switch to "PGO-based policy" for inliner in future but maybe some of these pieces will be useful there too?

tannergooding · 2021-04-06T15:23:22Z


 // ------ Callee Information -------

+INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)


For some future PR, we could also track the intrinsic id here.
This would allow us to determine, at least the following interesting pieces:
Number of intrinsic calls
Number of hardware intrinsic calls
Number of Type.op_Equality calls
There may be other interesting bits as well, but these are at least ones that have one or more of:
significantly decreased cost (hwintrinsics are instructions not calls)
additional optimizations (many intrinsics have CSE support)
potential dead code elimination (type equality checks, particularly where T : struct)

AndyAyersMS · 2021-04-14T16:22:42Z

This is now going to require making String.Length a new-style intrinsic.

EgorBo · 2021-05-04T21:56:36Z

Will re-think this one in a new PR.

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021

Improve classic inliner with foldable calls
b06d502

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2021

tannergooding reviewed Apr 6, 2021
View reviewed changes

Comment threadsrc/coreclr/jit/fgbasic.cpp Outdated

tannergooding reviewed Apr 6, 2021
View reviewed changes

EgorBo added 3 commits April 6, 2021 18:24

Update fgbasic.cpp
f25b371

Update fgbasic.cpp
753e517

Update fgbasic.cpp
82d07a0

EgorBo marked this pull request as ready for review April 7, 2021 20:33

AndyAyersMS approved these changes Apr 9, 2021
View reviewed changes

EgorBo mentioned this pull request Apr 9, 2021
Regression in Crossgen2 Throughput #51006
Closed

JulieLeeMSFT assigned EgorBo Apr 15, 2021

JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021

EgorBo closed this May 4, 2021

EgorBo mentioned this pull request May 13, 2021
[JIT] Improve inliner: new heuristics, rely on PGO data #52708
Merged

ghost locked as resolved and limited conversation to collaborators Jun 3, 2021


		// ------ Callee Information -------

		INLINE_OBSERVATION(FOLDABLE_CALL, bool, "foldable call", INFORMATION, CALLEE)

Uh oh!

Conversation

EgorBo commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tannergoodingApr 6, 2021

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Apr 14, 2021

Uh oh!

EgorBo commented May 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

EgorBo commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tannergoodingApr 6, 2021

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Apr 14, 2021

Uh oh!

EgorBo commented May 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

EgorBo commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tannergoodingApr 6, 2021

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Apr 14, 2021

Uh oh!

EgorBo commented May 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

EgorBo commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tannergoodingApr 6, 2021

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Apr 14, 2021

Uh oh!

EgorBo commented May 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

EgorBo commented Apr 6, 2021•
edited
Loading

EgorBo commented Apr 6, 2021•
edited
Loading

EgorBo commented Apr 6, 2021•
edited
Loading

EgorBo commented Apr 6, 2021•
edited
Loading

EgorBo commented Apr 6, 2021•
edited
Loading

EgorBo commented Apr 6, 2021•
edited
Loading