Uh oh!
There was an error while loading. Please reload this page.
[wasm] Remove unncessary check for EMSDK_PATH - #50810
Merged
Merged
Conversation
We check for `emsdk` is much more granular way now, and at the points where it will actually be used. So, remove these stale early checks for `emsdk`. Fixesdotnet#50801
ghost
commented
Apr 6, 2021
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWe check for Fixes #50801
|
pranavkm
commented
Apr 6, 2021
Contributor
There's a few other changes since preview3 that are missing in main: https://github.com/dotnet/runtime/compare/main...pranavkm-patch-1?quick_pull=1. Do you need any of the other changes too? |
radical
commented
Apr 6, 2021
MemberAuthor
nope. The other changes are improvements in |
radekdoulik
approved these changes
Apr 7, 2021
lewing
approved these changes
Apr 7, 2021
thaystg added a commit
to thaystg/runtime
that referenced
this pull request
Apr 7, 2021
* upstream/main: (568 commits) [wasm] Set __DistroRid on Windows to browser-wasm (dotnet#50842) [wasm] Fix order of include paths, to have the obj dir first (dotnet#50303) [wasm] Fix debug build of AOT cross compiler (dotnet#50418) Fix outdated comment (dotnet#50834) [wasm][tests] Add properties to allow passing args to xharness (dotnet#50678) Vectorized common String.Split() paths (dotnet#38001) Fix binplacing symbol files. (dotnet#50819) Move type check to after the null ref branch in out marshalling of blittable classes. (dotnet#50735) Remove extraneous CMake version requirement. (dotnet#50805) [wasm] Remove unncessary condition for EMSDK (dotnet#50810) Add loop alignment stats to JitLogCsv (dotnet#50624) Resolve ILLink warnings in System.Diagnostics.DiagnosticSource (dotnet#50265) Avoid unnecessary closures/delegates in Process (dotnet#50496) Fix for field layout verification across version bubble boundary (dotnet#50364) JIT: Enable CSE for VectorX.Create (dotnet#50644) [main] Update dependencies from mono/linker (dotnet#50779) [mono] More domain cleanup (dotnet#50771) Race condition in Mock reference tracker runtime with GC. (dotnet#50804) Remove IAssemblyName (and various fusion remnants) (dotnet#50755) Disable failing test for GCStress. (dotnet#50828) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We check for
emsdkin a much more granular way now, and at the pointswhere it will actually be used. So, remove these stale early checks for
emsdk.Fixes#50801