Uh oh!
There was an error while loading. Please reload this page.
change GC committed bytes unit to MB - #51031
Merged
sywhang merged 2 commits intoApr 10, 2021
Merged
Conversation
davidfowl
approved these changes
Apr 9, 2021
davidfowl
left a comment
Member
There was a problem hiding this comment.
Should change the other ones to use 1_000_000 as well
davidfowl
commented
Apr 10, 2021
Member
cc @stephentoub for the test failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the unit of this counter to MB as discussed here.
cc @davidfowl