System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hrrrrustic wants to merge 2 commits into from
Closed

System.Data readonly annotation #51785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad8d89
readonly annotation
hrrrrustic Apr 12, 2021
33167cd
common
hrrrrustic Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
_tag = 0;
}

public bool HasTarget
public readonly bool HasTarget
{
get
{
return ((_tag != 0) && (_weak.IsAlive));
}
}

public int Tag
public readonly int Tag
{
get
{
return _tag;
}
}

public object? Target
public readonly object? Target
{
get
{
Expand Down
438 changes: 219 additions & 219 deletions src/libraries/System.Data.Common/ref/System.Data.Common.cs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
this.FactoryInstance = factoryInstance;
}

internal string FactoryTypeAssemblyQualifiedName { get; }
internal readonly string FactoryTypeAssemblyQualifiedName { get; }

/// <summary>
/// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
/// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
/// </summary>
internal DbProviderFactory? FactoryInstance { get; }
internal readonly DbProviderFactory? FactoryInstance { get; }
}

private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Data.Common/src/System/Data/DataSet.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
HasChanges = 0;
}

internal int HasChanges { get; set; }
internal int HasChanges { readonly get; set; }

internal bool this[int index]
{
Expand Down
10 changes: 5 additions & 5 deletions src/libraries/System.Data.Common/src/System/Data/Range.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
_isNotNull = true;
}

public int Count => IsNull ? 0 : _max - _min + 1;
public readonly int Count => IsNull ? 0 : _max - _min + 1;

public bool IsNull => !_isNotNull;
public readonly bool IsNull => !_isNotNull;

public int Max
public readonly int Max
{
get
{
Expand All@@ -33,7 +33,7 @@ public int Max
}
}

public int Min
public readonly int Min
{
get
{
Expand All@@ -42,7 +42,7 @@ public int Min
}
}

internal void CheckNull()
internal readonly void CheckNull()
{
if (IsNull)
{
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Data.Common/src/System/Data/RbTree.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
return hasCurrent;
}

public K Current
public readonly K Current
{
get
{
Expand Down
22 changes: 11 additions & 11 deletions src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
/// <summary>
/// Gets whether or not <see cref='Value'/> is null.
/// </summary>
public bool IsNull => _value is null;
public readonly bool IsNull => _value is null;

// property: Value
/// <summary>
/// Gets or sets the value of the SQL binary object retrieved.
/// </summary>
public byte[] Value
public readonly byte[] Value
{
get
{
Expand All@@ -73,7 +73,7 @@ public byte[] Value
}

// class indexer
public byte this[int index]
public readonly byte this[int index]
{
get
{
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
/// <summary>
/// Gets the length in bytes of <see cref='Value'/>.
/// </summary>
public int Length
public readonly int Length
{
get
{
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
/// <summary>
/// Returns a string describing a <see cref='SqlBinary'/> object.
/// </summary>
public override string ToString() =>
public override readonly string ToString() =>
_value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

// Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
}

// Alternative method for conversions.
public SqlGuid ToSqlGuid()
public readonly SqlGuid ToSqlGuid()
{
return (SqlGuid)this;
}
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
// or a value greater than zero if this > object.
// null is considered to be less than any instance.
// If object is not of same type, this method throws an ArgumentException.
public int CompareTo(object? value)
public readonly int CompareTo(object? value)
{
if (value is SqlBinary)
{
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
}

public int CompareTo(SqlBinary value)
public readonly int CompareTo(SqlBinary value)
{
// If both Null, consider them equal.
// Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
}

// Compares this instance with a specified object
public override bool Equals(object? value)
public override readonly bool Equals(object? value)
{
if (!(value is SqlBinary))
{
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
return ulValue;
}
// For hashing purpose
public override int GetHashCode()
public override readonly int GetHashCode()
{
if (_value is null)
return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
return HashByteArray(_value, cbLen);
}

XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

void IXmlSerializable.ReadXml(XmlReader reader)
{
Expand Down
40 changes: 20 additions & 20 deletions src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
/// <summary>
/// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
/// </summary>
public bool IsNull
public readonly bool IsNull
{
get { return m_value == x_Null; }
}
Expand All@@ -62,7 +62,7 @@ public bool IsNull
/// <summary>
/// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
/// </summary>
public bool Value
public readonly bool Value
{
get
{
Expand All@@ -78,15 +78,15 @@ public bool Value
/// <summary>
/// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
/// </summary>
public bool IsTrue
public readonly bool IsTrue
{
get { return m_value == x_True; }
}

/// <summary>
/// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
/// </summary>
public bool IsFalse
public readonly bool IsFalse
{
get { return m_value == x_False; }
}
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


// property: ByteValue
public byte ByteValue
public readonly byte ByteValue
{
get
{
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
}
}

public override string ToString()
public override readonly string ToString()
{
return IsNull ? SQLResource.NullString : Value.ToString();
}
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

// Alternative method for conversions.

public SqlByte ToSqlByte()
public readonly SqlByte ToSqlByte()
{
return (SqlByte)this;
}

public SqlDouble ToSqlDouble()
public readonly SqlDouble ToSqlDouble()
{
return (SqlDouble)this;
}

public SqlInt16 ToSqlInt16()
public readonly SqlInt16 ToSqlInt16()
{
return (SqlInt16)this;
}

public SqlInt32 ToSqlInt32()
public readonly SqlInt32 ToSqlInt32()
{
return (SqlInt32)this;
}

public SqlInt64 ToSqlInt64()
public readonly SqlInt64 ToSqlInt64()
{
return (SqlInt64)this;
}

public SqlMoney ToSqlMoney()
public readonly SqlMoney ToSqlMoney()
{
return (SqlMoney)this;
}

public SqlDecimal ToSqlDecimal()
public readonly SqlDecimal ToSqlDecimal()
{
return (SqlDecimal)this;
}

public SqlSingle ToSqlSingle()
public readonly SqlSingle ToSqlSingle()
{
return (SqlSingle)this;
}

public SqlString ToSqlString()
public readonly SqlString ToSqlString()
{
return (SqlString)this;
}
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
// or a value greater than zero if this > object.
// null is considered to be less than any instance.
// If object is not of same type, this method throws an ArgumentException.
public int CompareTo(object? value)
public readonly int CompareTo(object? value)
{
if (value is SqlBoolean)
{
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
}

public int CompareTo(SqlBoolean value)
public readonly int CompareTo(SqlBoolean value)
{
// If both Null, consider them equal.
// Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
}

// Compares this instance with a specified object
public override bool Equals(object? value)
public override readonly bool Equals(object? value)
{
if (!(value is SqlBoolean))
{
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
}

// For hashing purpose
public override int GetHashCode()
public override readonly int GetHashCode()
{
return IsNull ? 0 : Value.GetHashCode();
}

XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

void IXmlSerializable.ReadXml(XmlReader reader)
{
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
2
commits into

from

 Closed


System.Data readonly annotation
#51785
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8ad8d89

readonly annotation


hrrrrustic Apr 12, 2021
33167cd

common


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
 _tag = 0;
 }

 public bool HasTarget
 public readonly bool HasTarget
 {
 get
 {
 return ((_tag != 0) && (_weak.IsAlive));
 }
 }

 public int Tag
 public readonly int Tag
 {
 get
 {
 return _tag;
 }
 }

 public object? Target
 public readonly object? Target
 {
 get
 {
Expand Down

438 changes: 219 additions & 219 deletions
src/libraries/System.Data.Common/ref/System.Data.Common.cs

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
 this.FactoryInstance = factoryInstance;
 }

 internal string FactoryTypeAssemblyQualifiedName { get; }
 internal readonly string FactoryTypeAssemblyQualifiedName { get; }

 /// <summary>
 /// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
 /// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
 /// </summary>
 internal DbProviderFactory? FactoryInstance { get; }
 internal readonly DbProviderFactory? FactoryInstance { get; }
 }

 private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/DataSet.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
 HasChanges = 0;
 }

 internal int HasChanges { get; set; }
 internal int HasChanges { readonly get; set; }

 internal bool this[int index]
 {
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Data.Common/src/System/Data/Range.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
 _isNotNull = true;
 }

 public int Count => IsNull ? 0 : _max - _min + 1;
 public readonly int Count => IsNull ? 0 : _max - _min + 1;

 public bool IsNull => !_isNotNull;
 public readonly bool IsNull => !_isNotNull;

 public int Max
 public readonly int Max
 {
 get
 {
Expand All@@ -33,7 +33,7 @@ public int Max
 }
 }

 public int Min
 public readonly int Min
 {
 get
 {
Expand All@@ -42,7 +42,7 @@ public int Min
 }
 }

 internal void CheckNull()
 internal readonly void CheckNull()
 {
 if (IsNull)
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/RbTree.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
 return hasCurrent;
 }

 public K Current
 public readonly K Current
 {
 get
 {
Expand Down

22 changes: 11 additions & 11 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
 /// <summary>
 /// Gets whether or not <see cref='Value'/> is null.
 /// </summary>
 public bool IsNull => _value is null;
 public readonly bool IsNull => _value is null;

 // property: Value
 /// <summary>
 /// Gets or sets the value of the SQL binary object retrieved.
 /// </summary>
 public byte[] Value
 public readonly byte[] Value
 {
 get
 {
Expand All@@ -73,7 +73,7 @@ public byte[] Value
 }

 // class indexer
 public byte this[int index]
 public readonly byte this[int index]
 {
 get
 {
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
 /// <summary>
 /// Gets the length in bytes of <see cref='Value'/>.
 /// </summary>
 public int Length
 public readonly int Length
 {
 get
 {
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
 /// <summary>
 /// Returns a string describing a <see cref='SqlBinary'/> object.
 /// </summary>
 public override string ToString() =>
 public override readonly string ToString() =>
 _value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

 // Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
 }

 // Alternative method for conversions.
 public SqlGuid ToSqlGuid()
 public readonly SqlGuid ToSqlGuid()
 {
 return (SqlGuid)this;
 }
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBinary)
 {
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
 }

 public int CompareTo(SqlBinary value)
 public readonly int CompareTo(SqlBinary value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBinary))
 {
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
 return ulValue;
 }
 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 if (_value is null)
 return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
 return HashByteArray(_value, cbLen);
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down

40 changes: 20 additions & 20 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
 /// </summary>
 public bool IsNull
 public readonly bool IsNull
 {
 get { return m_value == x_Null; }
 }
Expand All@@ -62,7 +62,7 @@ public bool IsNull
 /// <summary>
 /// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
 /// </summary>
 public bool Value
 public readonly bool Value
 {
 get
 {
Expand All@@ -78,15 +78,15 @@ public bool Value
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
 /// </summary>
 public bool IsTrue
 public readonly bool IsTrue
 {
 get { return m_value == x_True; }
 }

 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
 /// </summary>
 public bool IsFalse
 public readonly bool IsFalse
 {
 get { return m_value == x_False; }
 }
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


 // property: ByteValue
 public byte ByteValue
 public readonly byte ByteValue
 {
 get
 {
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
 }
 }

 public override string ToString()
 public override readonly string ToString()
 {
 return IsNull ? SQLResource.NullString : Value.ToString();
 }
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

 // Alternative method for conversions.

 public SqlByte ToSqlByte()
 public readonly SqlByte ToSqlByte()
 {
 return (SqlByte)this;
 }

 public SqlDouble ToSqlDouble()
 public readonly SqlDouble ToSqlDouble()
 {
 return (SqlDouble)this;
 }

 public SqlInt16 ToSqlInt16()
 public readonly SqlInt16 ToSqlInt16()
 {
 return (SqlInt16)this;
 }

 public SqlInt32 ToSqlInt32()
 public readonly SqlInt32 ToSqlInt32()
 {
 return (SqlInt32)this;
 }

 public SqlInt64 ToSqlInt64()
 public readonly SqlInt64 ToSqlInt64()
 {
 return (SqlInt64)this;
 }

 public SqlMoney ToSqlMoney()
 public readonly SqlMoney ToSqlMoney()
 {
 return (SqlMoney)this;
 }

 public SqlDecimal ToSqlDecimal()
 public readonly SqlDecimal ToSqlDecimal()
 {
 return (SqlDecimal)this;
 }

 public SqlSingle ToSqlSingle()
 public readonly SqlSingle ToSqlSingle()
 {
 return (SqlSingle)this;
 }

 public SqlString ToSqlString()
 public readonly SqlString ToSqlString()
 {
 return (SqlString)this;
 }
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBoolean)
 {
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
 }

 public int CompareTo(SqlBoolean value)
 public readonly int CompareTo(SqlBoolean value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBoolean))
 {
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
 }

 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return IsNull ? 0 : Value.GetHashCode();
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
2
commits into

from

 Closed


System.Data readonly annotation
#51785
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8ad8d89

readonly annotation


hrrrrustic Apr 12, 2021
33167cd

common


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
 _tag = 0;
 }

 public bool HasTarget
 public readonly bool HasTarget
 {
 get
 {
 return ((_tag != 0) && (_weak.IsAlive));
 }
 }

 public int Tag
 public readonly int Tag
 {
 get
 {
 return _tag;
 }
 }

 public object? Target
 public readonly object? Target
 {
 get
 {
Expand Down

438 changes: 219 additions & 219 deletions
src/libraries/System.Data.Common/ref/System.Data.Common.cs

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
 this.FactoryInstance = factoryInstance;
 }

 internal string FactoryTypeAssemblyQualifiedName { get; }
 internal readonly string FactoryTypeAssemblyQualifiedName { get; }

 /// <summary>
 /// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
 /// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
 /// </summary>
 internal DbProviderFactory? FactoryInstance { get; }
 internal readonly DbProviderFactory? FactoryInstance { get; }
 }

 private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/DataSet.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
 HasChanges = 0;
 }

 internal int HasChanges { get; set; }
 internal int HasChanges { readonly get; set; }

 internal bool this[int index]
 {
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Data.Common/src/System/Data/Range.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
 _isNotNull = true;
 }

 public int Count => IsNull ? 0 : _max - _min + 1;
 public readonly int Count => IsNull ? 0 : _max - _min + 1;

 public bool IsNull => !_isNotNull;
 public readonly bool IsNull => !_isNotNull;

 public int Max
 public readonly int Max
 {
 get
 {
Expand All@@ -33,7 +33,7 @@ public int Max
 }
 }

 public int Min
 public readonly int Min
 {
 get
 {
Expand All@@ -42,7 +42,7 @@ public int Min
 }
 }

 internal void CheckNull()
 internal readonly void CheckNull()
 {
 if (IsNull)
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/RbTree.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
 return hasCurrent;
 }

 public K Current
 public readonly K Current
 {
 get
 {
Expand Down

22 changes: 11 additions & 11 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
 /// <summary>
 /// Gets whether or not <see cref='Value'/> is null.
 /// </summary>
 public bool IsNull => _value is null;
 public readonly bool IsNull => _value is null;

 // property: Value
 /// <summary>
 /// Gets or sets the value of the SQL binary object retrieved.
 /// </summary>
 public byte[] Value
 public readonly byte[] Value
 {
 get
 {
Expand All@@ -73,7 +73,7 @@ public byte[] Value
 }

 // class indexer
 public byte this[int index]
 public readonly byte this[int index]
 {
 get
 {
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
 /// <summary>
 /// Gets the length in bytes of <see cref='Value'/>.
 /// </summary>
 public int Length
 public readonly int Length
 {
 get
 {
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
 /// <summary>
 /// Returns a string describing a <see cref='SqlBinary'/> object.
 /// </summary>
 public override string ToString() =>
 public override readonly string ToString() =>
 _value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

 // Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
 }

 // Alternative method for conversions.
 public SqlGuid ToSqlGuid()
 public readonly SqlGuid ToSqlGuid()
 {
 return (SqlGuid)this;
 }
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBinary)
 {
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
 }

 public int CompareTo(SqlBinary value)
 public readonly int CompareTo(SqlBinary value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBinary))
 {
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
 return ulValue;
 }
 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 if (_value is null)
 return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
 return HashByteArray(_value, cbLen);
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down

40 changes: 20 additions & 20 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
 /// </summary>
 public bool IsNull
 public readonly bool IsNull
 {
 get { return m_value == x_Null; }
 }
Expand All@@ -62,7 +62,7 @@ public bool IsNull
 /// <summary>
 /// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
 /// </summary>
 public bool Value
 public readonly bool Value
 {
 get
 {
Expand All@@ -78,15 +78,15 @@ public bool Value
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
 /// </summary>
 public bool IsTrue
 public readonly bool IsTrue
 {
 get { return m_value == x_True; }
 }

 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
 /// </summary>
 public bool IsFalse
 public readonly bool IsFalse
 {
 get { return m_value == x_False; }
 }
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


 // property: ByteValue
 public byte ByteValue
 public readonly byte ByteValue
 {
 get
 {
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
 }
 }

 public override string ToString()
 public override readonly string ToString()
 {
 return IsNull ? SQLResource.NullString : Value.ToString();
 }
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

 // Alternative method for conversions.

 public SqlByte ToSqlByte()
 public readonly SqlByte ToSqlByte()
 {
 return (SqlByte)this;
 }

 public SqlDouble ToSqlDouble()
 public readonly SqlDouble ToSqlDouble()
 {
 return (SqlDouble)this;
 }

 public SqlInt16 ToSqlInt16()
 public readonly SqlInt16 ToSqlInt16()
 {
 return (SqlInt16)this;
 }

 public SqlInt32 ToSqlInt32()
 public readonly SqlInt32 ToSqlInt32()
 {
 return (SqlInt32)this;
 }

 public SqlInt64 ToSqlInt64()
 public readonly SqlInt64 ToSqlInt64()
 {
 return (SqlInt64)this;
 }

 public SqlMoney ToSqlMoney()
 public readonly SqlMoney ToSqlMoney()
 {
 return (SqlMoney)this;
 }

 public SqlDecimal ToSqlDecimal()
 public readonly SqlDecimal ToSqlDecimal()
 {
 return (SqlDecimal)this;
 }

 public SqlSingle ToSqlSingle()
 public readonly SqlSingle ToSqlSingle()
 {
 return (SqlSingle)this;
 }

 public SqlString ToSqlString()
 public readonly SqlString ToSqlString()
 {
 return (SqlString)this;
 }
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBoolean)
 {
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
 }

 public int CompareTo(SqlBoolean value)
 public readonly int CompareTo(SqlBoolean value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBoolean))
 {
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
 }

 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return IsNull ? 0 : Value.GetHashCode();
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
2
commits into

from

 Closed


System.Data readonly annotation
#51785
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8ad8d89

readonly annotation


hrrrrustic Apr 12, 2021
33167cd

common


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
 _tag = 0;
 }

 public bool HasTarget
 public readonly bool HasTarget
 {
 get
 {
 return ((_tag != 0) && (_weak.IsAlive));
 }
 }

 public int Tag
 public readonly int Tag
 {
 get
 {
 return _tag;
 }
 }

 public object? Target
 public readonly object? Target
 {
 get
 {
Expand Down

438 changes: 219 additions & 219 deletions
src/libraries/System.Data.Common/ref/System.Data.Common.cs

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
 this.FactoryInstance = factoryInstance;
 }

 internal string FactoryTypeAssemblyQualifiedName { get; }
 internal readonly string FactoryTypeAssemblyQualifiedName { get; }

 /// <summary>
 /// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
 /// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
 /// </summary>
 internal DbProviderFactory? FactoryInstance { get; }
 internal readonly DbProviderFactory? FactoryInstance { get; }
 }

 private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/DataSet.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
 HasChanges = 0;
 }

 internal int HasChanges { get; set; }
 internal int HasChanges { readonly get; set; }

 internal bool this[int index]
 {
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Data.Common/src/System/Data/Range.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
 _isNotNull = true;
 }

 public int Count => IsNull ? 0 : _max - _min + 1;
 public readonly int Count => IsNull ? 0 : _max - _min + 1;

 public bool IsNull => !_isNotNull;
 public readonly bool IsNull => !_isNotNull;

 public int Max
 public readonly int Max
 {
 get
 {
Expand All@@ -33,7 +33,7 @@ public int Max
 }
 }

 public int Min
 public readonly int Min
 {
 get
 {
Expand All@@ -42,7 +42,7 @@ public int Min
 }
 }

 internal void CheckNull()
 internal readonly void CheckNull()
 {
 if (IsNull)
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/RbTree.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
 return hasCurrent;
 }

 public K Current
 public readonly K Current
 {
 get
 {
Expand Down

22 changes: 11 additions & 11 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
 /// <summary>
 /// Gets whether or not <see cref='Value'/> is null.
 /// </summary>
 public bool IsNull => _value is null;
 public readonly bool IsNull => _value is null;

 // property: Value
 /// <summary>
 /// Gets or sets the value of the SQL binary object retrieved.
 /// </summary>
 public byte[] Value
 public readonly byte[] Value
 {
 get
 {
Expand All@@ -73,7 +73,7 @@ public byte[] Value
 }

 // class indexer
 public byte this[int index]
 public readonly byte this[int index]
 {
 get
 {
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
 /// <summary>
 /// Gets the length in bytes of <see cref='Value'/>.
 /// </summary>
 public int Length
 public readonly int Length
 {
 get
 {
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
 /// <summary>
 /// Returns a string describing a <see cref='SqlBinary'/> object.
 /// </summary>
 public override string ToString() =>
 public override readonly string ToString() =>
 _value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

 // Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
 }

 // Alternative method for conversions.
 public SqlGuid ToSqlGuid()
 public readonly SqlGuid ToSqlGuid()
 {
 return (SqlGuid)this;
 }
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBinary)
 {
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
 }

 public int CompareTo(SqlBinary value)
 public readonly int CompareTo(SqlBinary value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBinary))
 {
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
 return ulValue;
 }
 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 if (_value is null)
 return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
 return HashByteArray(_value, cbLen);
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down

40 changes: 20 additions & 20 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
 /// </summary>
 public bool IsNull
 public readonly bool IsNull
 {
 get { return m_value == x_Null; }
 }
Expand All@@ -62,7 +62,7 @@ public bool IsNull
 /// <summary>
 /// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
 /// </summary>
 public bool Value
 public readonly bool Value
 {
 get
 {
Expand All@@ -78,15 +78,15 @@ public bool Value
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
 /// </summary>
 public bool IsTrue
 public readonly bool IsTrue
 {
 get { return m_value == x_True; }
 }

 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
 /// </summary>
 public bool IsFalse
 public readonly bool IsFalse
 {
 get { return m_value == x_False; }
 }
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


 // property: ByteValue
 public byte ByteValue
 public readonly byte ByteValue
 {
 get
 {
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
 }
 }

 public override string ToString()
 public override readonly string ToString()
 {
 return IsNull ? SQLResource.NullString : Value.ToString();
 }
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

 // Alternative method for conversions.

 public SqlByte ToSqlByte()
 public readonly SqlByte ToSqlByte()
 {
 return (SqlByte)this;
 }

 public SqlDouble ToSqlDouble()
 public readonly SqlDouble ToSqlDouble()
 {
 return (SqlDouble)this;
 }

 public SqlInt16 ToSqlInt16()
 public readonly SqlInt16 ToSqlInt16()
 {
 return (SqlInt16)this;
 }

 public SqlInt32 ToSqlInt32()
 public readonly SqlInt32 ToSqlInt32()
 {
 return (SqlInt32)this;
 }

 public SqlInt64 ToSqlInt64()
 public readonly SqlInt64 ToSqlInt64()
 {
 return (SqlInt64)this;
 }

 public SqlMoney ToSqlMoney()
 public readonly SqlMoney ToSqlMoney()
 {
 return (SqlMoney)this;
 }

 public SqlDecimal ToSqlDecimal()
 public readonly SqlDecimal ToSqlDecimal()
 {
 return (SqlDecimal)this;
 }

 public SqlSingle ToSqlSingle()
 public readonly SqlSingle ToSqlSingle()
 {
 return (SqlSingle)this;
 }

 public SqlString ToSqlString()
 public readonly SqlString ToSqlString()
 {
 return (SqlString)this;
 }
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBoolean)
 {
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
 }

 public int CompareTo(SqlBoolean value)
 public readonly int CompareTo(SqlBoolean value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBoolean))
 {
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
 }

 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return IsNull ? 0 : Value.GetHashCode();
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
2
commits into

from

 Closed


System.Data readonly annotation
#51785
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8ad8d89

readonly annotation


hrrrrustic Apr 12, 2021
33167cd

common


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
 _tag = 0;
 }

 public bool HasTarget
 public readonly bool HasTarget
 {
 get
 {
 return ((_tag != 0) && (_weak.IsAlive));
 }
 }

 public int Tag
 public readonly int Tag
 {
 get
 {
 return _tag;
 }
 }

 public object? Target
 public readonly object? Target
 {
 get
 {
Expand Down

438 changes: 219 additions & 219 deletions
src/libraries/System.Data.Common/ref/System.Data.Common.cs

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
 this.FactoryInstance = factoryInstance;
 }

 internal string FactoryTypeAssemblyQualifiedName { get; }
 internal readonly string FactoryTypeAssemblyQualifiedName { get; }

 /// <summary>
 /// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
 /// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
 /// </summary>
 internal DbProviderFactory? FactoryInstance { get; }
 internal readonly DbProviderFactory? FactoryInstance { get; }
 }

 private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/DataSet.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
 HasChanges = 0;
 }

 internal int HasChanges { get; set; }
 internal int HasChanges { readonly get; set; }

 internal bool this[int index]
 {
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Data.Common/src/System/Data/Range.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
 _isNotNull = true;
 }

 public int Count => IsNull ? 0 : _max - _min + 1;
 public readonly int Count => IsNull ? 0 : _max - _min + 1;

 public bool IsNull => !_isNotNull;
 public readonly bool IsNull => !_isNotNull;

 public int Max
 public readonly int Max
 {
 get
 {
Expand All@@ -33,7 +33,7 @@ public int Max
 }
 }

 public int Min
 public readonly int Min
 {
 get
 {
Expand All@@ -42,7 +42,7 @@ public int Min
 }
 }

 internal void CheckNull()
 internal readonly void CheckNull()
 {
 if (IsNull)
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/RbTree.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
 return hasCurrent;
 }

 public K Current
 public readonly K Current
 {
 get
 {
Expand Down

22 changes: 11 additions & 11 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
 /// <summary>
 /// Gets whether or not <see cref='Value'/> is null.
 /// </summary>
 public bool IsNull => _value is null;
 public readonly bool IsNull => _value is null;

 // property: Value
 /// <summary>
 /// Gets or sets the value of the SQL binary object retrieved.
 /// </summary>
 public byte[] Value
 public readonly byte[] Value
 {
 get
 {
Expand All@@ -73,7 +73,7 @@ public byte[] Value
 }

 // class indexer
 public byte this[int index]
 public readonly byte this[int index]
 {
 get
 {
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
 /// <summary>
 /// Gets the length in bytes of <see cref='Value'/>.
 /// </summary>
 public int Length
 public readonly int Length
 {
 get
 {
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
 /// <summary>
 /// Returns a string describing a <see cref='SqlBinary'/> object.
 /// </summary>
 public override string ToString() =>
 public override readonly string ToString() =>
 _value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

 // Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
 }

 // Alternative method for conversions.
 public SqlGuid ToSqlGuid()
 public readonly SqlGuid ToSqlGuid()
 {
 return (SqlGuid)this;
 }
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBinary)
 {
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
 }

 public int CompareTo(SqlBinary value)
 public readonly int CompareTo(SqlBinary value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBinary))
 {
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
 return ulValue;
 }
 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 if (_value is null)
 return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
 return HashByteArray(_value, cbLen);
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down

40 changes: 20 additions & 20 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
 /// </summary>
 public bool IsNull
 public readonly bool IsNull
 {
 get { return m_value == x_Null; }
 }
Expand All@@ -62,7 +62,7 @@ public bool IsNull
 /// <summary>
 /// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
 /// </summary>
 public bool Value
 public readonly bool Value
 {
 get
 {
Expand All@@ -78,15 +78,15 @@ public bool Value
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
 /// </summary>
 public bool IsTrue
 public readonly bool IsTrue
 {
 get { return m_value == x_True; }
 }

 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
 /// </summary>
 public bool IsFalse
 public readonly bool IsFalse
 {
 get { return m_value == x_False; }
 }
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


 // property: ByteValue
 public byte ByteValue
 public readonly byte ByteValue
 {
 get
 {
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
 }
 }

 public override string ToString()
 public override readonly string ToString()
 {
 return IsNull ? SQLResource.NullString : Value.ToString();
 }
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

 // Alternative method for conversions.

 public SqlByte ToSqlByte()
 public readonly SqlByte ToSqlByte()
 {
 return (SqlByte)this;
 }

 public SqlDouble ToSqlDouble()
 public readonly SqlDouble ToSqlDouble()
 {
 return (SqlDouble)this;
 }

 public SqlInt16 ToSqlInt16()
 public readonly SqlInt16 ToSqlInt16()
 {
 return (SqlInt16)this;
 }

 public SqlInt32 ToSqlInt32()
 public readonly SqlInt32 ToSqlInt32()
 {
 return (SqlInt32)this;
 }

 public SqlInt64 ToSqlInt64()
 public readonly SqlInt64 ToSqlInt64()
 {
 return (SqlInt64)this;
 }

 public SqlMoney ToSqlMoney()
 public readonly SqlMoney ToSqlMoney()
 {
 return (SqlMoney)this;
 }

 public SqlDecimal ToSqlDecimal()
 public readonly SqlDecimal ToSqlDecimal()
 {
 return (SqlDecimal)this;
 }

 public SqlSingle ToSqlSingle()
 public readonly SqlSingle ToSqlSingle()
 {
 return (SqlSingle)this;
 }

 public SqlString ToSqlString()
 public readonly SqlString ToSqlString()
 {
 return (SqlString)this;
 }
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBoolean)
 {
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
 }

 public int CompareTo(SqlBoolean value)
 public readonly int CompareTo(SqlBoolean value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBoolean))
 {
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
 }

 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return IsNull ? 0 : Value.GetHashCode();
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
2
commits into

from

 Closed


System.Data readonly annotation
#51785
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8ad8d89

readonly annotation


hrrrrustic Apr 12, 2021
33167cd

common


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
 _tag = 0;
 }

 public bool HasTarget
 public readonly bool HasTarget
 {
 get
 {
 return ((_tag != 0) && (_weak.IsAlive));
 }
 }

 public int Tag
 public readonly int Tag
 {
 get
 {
 return _tag;
 }
 }

 public object? Target
 public readonly object? Target
 {
 get
 {
Expand Down

438 changes: 219 additions & 219 deletions
src/libraries/System.Data.Common/ref/System.Data.Common.cs

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
 this.FactoryInstance = factoryInstance;
 }

 internal string FactoryTypeAssemblyQualifiedName { get; }
 internal readonly string FactoryTypeAssemblyQualifiedName { get; }

 /// <summary>
 /// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
 /// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
 /// </summary>
 internal DbProviderFactory? FactoryInstance { get; }
 internal readonly DbProviderFactory? FactoryInstance { get; }
 }

 private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/DataSet.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
 HasChanges = 0;
 }

 internal int HasChanges { get; set; }
 internal int HasChanges { readonly get; set; }

 internal bool this[int index]
 {
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Data.Common/src/System/Data/Range.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
 _isNotNull = true;
 }

 public int Count => IsNull ? 0 : _max - _min + 1;
 public readonly int Count => IsNull ? 0 : _max - _min + 1;

 public bool IsNull => !_isNotNull;
 public readonly bool IsNull => !_isNotNull;

 public int Max
 public readonly int Max
 {
 get
 {
Expand All@@ -33,7 +33,7 @@ public int Max
 }
 }

 public int Min
 public readonly int Min
 {
 get
 {
Expand All@@ -42,7 +42,7 @@ public int Min
 }
 }

 internal void CheckNull()
 internal readonly void CheckNull()
 {
 if (IsNull)
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/RbTree.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
 return hasCurrent;
 }

 public K Current
 public readonly K Current
 {
 get
 {
Expand Down

22 changes: 11 additions & 11 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
 /// <summary>
 /// Gets whether or not <see cref='Value'/> is null.
 /// </summary>
 public bool IsNull => _value is null;
 public readonly bool IsNull => _value is null;

 // property: Value
 /// <summary>
 /// Gets or sets the value of the SQL binary object retrieved.
 /// </summary>
 public byte[] Value
 public readonly byte[] Value
 {
 get
 {
Expand All@@ -73,7 +73,7 @@ public byte[] Value
 }

 // class indexer
 public byte this[int index]
 public readonly byte this[int index]
 {
 get
 {
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
 /// <summary>
 /// Gets the length in bytes of <see cref='Value'/>.
 /// </summary>
 public int Length
 public readonly int Length
 {
 get
 {
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
 /// <summary>
 /// Returns a string describing a <see cref='SqlBinary'/> object.
 /// </summary>
 public override string ToString() =>
 public override readonly string ToString() =>
 _value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

 // Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
 }

 // Alternative method for conversions.
 public SqlGuid ToSqlGuid()
 public readonly SqlGuid ToSqlGuid()
 {
 return (SqlGuid)this;
 }
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBinary)
 {
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
 }

 public int CompareTo(SqlBinary value)
 public readonly int CompareTo(SqlBinary value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBinary))
 {
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
 return ulValue;
 }
 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 if (_value is null)
 return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
 return HashByteArray(_value, cbLen);
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down

40 changes: 20 additions & 20 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
 /// </summary>
 public bool IsNull
 public readonly bool IsNull
 {
 get { return m_value == x_Null; }
 }
Expand All@@ -62,7 +62,7 @@ public bool IsNull
 /// <summary>
 /// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
 /// </summary>
 public bool Value
 public readonly bool Value
 {
 get
 {
Expand All@@ -78,15 +78,15 @@ public bool Value
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
 /// </summary>
 public bool IsTrue
 public readonly bool IsTrue
 {
 get { return m_value == x_True; }
 }

 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
 /// </summary>
 public bool IsFalse
 public readonly bool IsFalse
 {
 get { return m_value == x_False; }
 }
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


 // property: ByteValue
 public byte ByteValue
 public readonly byte ByteValue
 {
 get
 {
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
 }
 }

 public override string ToString()
 public override readonly string ToString()
 {
 return IsNull ? SQLResource.NullString : Value.ToString();
 }
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

 // Alternative method for conversions.

 public SqlByte ToSqlByte()
 public readonly SqlByte ToSqlByte()
 {
 return (SqlByte)this;
 }

 public SqlDouble ToSqlDouble()
 public readonly SqlDouble ToSqlDouble()
 {
 return (SqlDouble)this;
 }

 public SqlInt16 ToSqlInt16()
 public readonly SqlInt16 ToSqlInt16()
 {
 return (SqlInt16)this;
 }

 public SqlInt32 ToSqlInt32()
 public readonly SqlInt32 ToSqlInt32()
 {
 return (SqlInt32)this;
 }

 public SqlInt64 ToSqlInt64()
 public readonly SqlInt64 ToSqlInt64()
 {
 return (SqlInt64)this;
 }

 public SqlMoney ToSqlMoney()
 public readonly SqlMoney ToSqlMoney()
 {
 return (SqlMoney)this;
 }

 public SqlDecimal ToSqlDecimal()
 public readonly SqlDecimal ToSqlDecimal()
 {
 return (SqlDecimal)this;
 }

 public SqlSingle ToSqlSingle()
 public readonly SqlSingle ToSqlSingle()
 {
 return (SqlSingle)this;
 }

 public SqlString ToSqlString()
 public readonly SqlString ToSqlString()
 {
 return (SqlString)this;
 }
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBoolean)
 {
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
 }

 public int CompareTo(SqlBoolean value)
 public readonly int CompareTo(SqlBoolean value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBoolean))
 {
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
 }

 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return IsNull ? 0 : Value.GetHashCode();
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
2
commits into

from

 Closed


System.Data readonly annotation
#51785
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8ad8d89

readonly annotation


hrrrrustic Apr 12, 2021
33167cd

common


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
 _tag = 0;
 }

 public bool HasTarget
 public readonly bool HasTarget
 {
 get
 {
 return ((_tag != 0) && (_weak.IsAlive));
 }
 }

 public int Tag
 public readonly int Tag
 {
 get
 {
 return _tag;
 }
 }

 public object? Target
 public readonly object? Target
 {
 get
 {
Expand Down

438 changes: 219 additions & 219 deletions
src/libraries/System.Data.Common/ref/System.Data.Common.cs

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
 this.FactoryInstance = factoryInstance;
 }

 internal string FactoryTypeAssemblyQualifiedName { get; }
 internal readonly string FactoryTypeAssemblyQualifiedName { get; }

 /// <summary>
 /// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
 /// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
 /// </summary>
 internal DbProviderFactory? FactoryInstance { get; }
 internal readonly DbProviderFactory? FactoryInstance { get; }
 }

 private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/DataSet.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
 HasChanges = 0;
 }

 internal int HasChanges { get; set; }
 internal int HasChanges { readonly get; set; }

 internal bool this[int index]
 {
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Data.Common/src/System/Data/Range.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
 _isNotNull = true;
 }

 public int Count => IsNull ? 0 : _max - _min + 1;
 public readonly int Count => IsNull ? 0 : _max - _min + 1;

 public bool IsNull => !_isNotNull;
 public readonly bool IsNull => !_isNotNull;

 public int Max
 public readonly int Max
 {
 get
 {
Expand All@@ -33,7 +33,7 @@ public int Max
 }
 }

 public int Min
 public readonly int Min
 {
 get
 {
Expand All@@ -42,7 +42,7 @@ public int Min
 }
 }

 internal void CheckNull()
 internal readonly void CheckNull()
 {
 if (IsNull)
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/RbTree.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
 return hasCurrent;
 }

 public K Current
 public readonly K Current
 {
 get
 {
Expand Down

22 changes: 11 additions & 11 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
 /// <summary>
 /// Gets whether or not <see cref='Value'/> is null.
 /// </summary>
 public bool IsNull => _value is null;
 public readonly bool IsNull => _value is null;

 // property: Value
 /// <summary>
 /// Gets or sets the value of the SQL binary object retrieved.
 /// </summary>
 public byte[] Value
 public readonly byte[] Value
 {
 get
 {
Expand All@@ -73,7 +73,7 @@ public byte[] Value
 }

 // class indexer
 public byte this[int index]
 public readonly byte this[int index]
 {
 get
 {
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
 /// <summary>
 /// Gets the length in bytes of <see cref='Value'/>.
 /// </summary>
 public int Length
 public readonly int Length
 {
 get
 {
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
 /// <summary>
 /// Returns a string describing a <see cref='SqlBinary'/> object.
 /// </summary>
 public override string ToString() =>
 public override readonly string ToString() =>
 _value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

 // Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
 }

 // Alternative method for conversions.
 public SqlGuid ToSqlGuid()
 public readonly SqlGuid ToSqlGuid()
 {
 return (SqlGuid)this;
 }
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBinary)
 {
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
 }

 public int CompareTo(SqlBinary value)
 public readonly int CompareTo(SqlBinary value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBinary))
 {
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
 return ulValue;
 }
 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 if (_value is null)
 return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
 return HashByteArray(_value, cbLen);
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down

40 changes: 20 additions & 20 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
 /// </summary>
 public bool IsNull
 public readonly bool IsNull
 {
 get { return m_value == x_Null; }
 }
Expand All@@ -62,7 +62,7 @@ public bool IsNull
 /// <summary>
 /// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
 /// </summary>
 public bool Value
 public readonly bool Value
 {
 get
 {
Expand All@@ -78,15 +78,15 @@ public bool Value
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
 /// </summary>
 public bool IsTrue
 public readonly bool IsTrue
 {
 get { return m_value == x_True; }
 }

 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
 /// </summary>
 public bool IsFalse
 public readonly bool IsFalse
 {
 get { return m_value == x_False; }
 }
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


 // property: ByteValue
 public byte ByteValue
 public readonly byte ByteValue
 {
 get
 {
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
 }
 }

 public override string ToString()
 public override readonly string ToString()
 {
 return IsNull ? SQLResource.NullString : Value.ToString();
 }
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

 // Alternative method for conversions.

 public SqlByte ToSqlByte()
 public readonly SqlByte ToSqlByte()
 {
 return (SqlByte)this;
 }

 public SqlDouble ToSqlDouble()
 public readonly SqlDouble ToSqlDouble()
 {
 return (SqlDouble)this;
 }

 public SqlInt16 ToSqlInt16()
 public readonly SqlInt16 ToSqlInt16()
 {
 return (SqlInt16)this;
 }

 public SqlInt32 ToSqlInt32()
 public readonly SqlInt32 ToSqlInt32()
 {
 return (SqlInt32)this;
 }

 public SqlInt64 ToSqlInt64()
 public readonly SqlInt64 ToSqlInt64()
 {
 return (SqlInt64)this;
 }

 public SqlMoney ToSqlMoney()
 public readonly SqlMoney ToSqlMoney()
 {
 return (SqlMoney)this;
 }

 public SqlDecimal ToSqlDecimal()
 public readonly SqlDecimal ToSqlDecimal()
 {
 return (SqlDecimal)this;
 }

 public SqlSingle ToSqlSingle()
 public readonly SqlSingle ToSqlSingle()
 {
 return (SqlSingle)this;
 }

 public SqlString ToSqlString()
 public readonly SqlString ToSqlString()
 {
 return (SqlString)this;
 }
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBoolean)
 {
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
 }

 public int CompareTo(SqlBoolean value)
 public readonly int CompareTo(SqlBoolean value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBoolean))
 {
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
 }

 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return IsNull ? 0 : Value.GetHashCode();
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
System.Data readonly annotation#51785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
2
commits into

from

 Closed


System.Data readonly annotation
#51785
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8ad8d89

readonly annotation


hrrrrustic Apr 12, 2021
33167cd

common


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,23 +40,23 @@ public void RemoveTarget()
 _tag = 0;
 }

 public bool HasTarget
 public readonly bool HasTarget
 {
 get
 {
 return ((_tag != 0) && (_weak.IsAlive));
 }
 }

 public int Tag
 public readonly int Tag
 {
 get
 {
 return _tag;
 }
 }

 public object? Target
 public readonly object? Target
 {
 get
 {
Expand Down

438 changes: 219 additions & 219 deletions
src/libraries/System.Data.Common/ref/System.Data.Common.cs

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,13 +23,13 @@ internal ProviderRegistration(string factoryTypeAssemblyQualifiedName, DbProvide
 this.FactoryInstance = factoryInstance;
 }

 internal string FactoryTypeAssemblyQualifiedName { get; }
 internal readonly string FactoryTypeAssemblyQualifiedName { get; }

 /// <summary>
 /// The cached instance of the type in <see cref="FactoryTypeAssemblyQualifiedName"/>. If null, this registration is seen as a deferred registration
 /// and <see cref="FactoryTypeAssemblyQualifiedName"/> is checked the first time when this registration is requested through GetFactory().
 /// </summary>
 internal DbProviderFactory? FactoryInstance { get; }
 internal readonly DbProviderFactory? FactoryInstance { get; }
 }

 private static readonly ConcurrentDictionary<string, ProviderRegistration> _registeredFactories = new ConcurrentDictionary<string, ProviderRegistration>();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/DataSet.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1259,7 +1259,7 @@ internal TableChanges(int rowCount)
 HasChanges = 0;
 }

 internal int HasChanges { get; set; }
 internal int HasChanges { readonly get; set; }

 internal bool this[int index]
 {
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Data.Common/src/System/Data/Range.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,11 +20,11 @@ public Range(int min, int max)
 _isNotNull = true;
 }

 public int Count => IsNull ? 0 : _max - _min + 1;
 public readonly int Count => IsNull ? 0 : _max - _min + 1;

 public bool IsNull => !_isNotNull;
 public readonly bool IsNull => !_isNotNull;

 public int Max
 public readonly int Max
 {
 get
 {
Expand All@@ -33,7 +33,7 @@ public int Max
 }
 }

 public int Min
 public readonly int Min
 {
 get
 {
Expand All@@ -42,7 +42,7 @@ public int Min
 }
 }

 internal void CheckNull()
 internal readonly void CheckNull()
 {
 if (IsNull)
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Data.Common/src/System/Data/RbTree.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2090,7 +2090,7 @@ public bool MoveNext()
 return hasCurrent;
 }

 public K Current
 public readonly K Current
 {
 get
 {
Expand Down

22 changes: 11 additions & 11 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBinary.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,13 +51,13 @@ internal SqlBinary(byte[]? value, bool ignored)
 /// <summary>
 /// Gets whether or not <see cref='Value'/> is null.
 /// </summary>
 public bool IsNull => _value is null;
 public readonly bool IsNull => _value is null;

 // property: Value
 /// <summary>
 /// Gets or sets the value of the SQL binary object retrieved.
 /// </summary>
 public byte[] Value
 public readonly byte[] Value
 {
 get
 {
Expand All@@ -73,7 +73,7 @@ public byte[] Value
 }

 // class indexer
 public byte this[int index]
 public readonly byte this[int index]
 {
 get
 {
Expand All@@ -89,7 +89,7 @@ public byte this[int index]
 /// <summary>
 /// Gets the length in bytes of <see cref='Value'/>.
 /// </summary>
 public int Length
 public readonly int Length
 {
 get
 {
Expand DownExpand Up@@ -118,7 +118,7 @@ public int Length
 /// <summary>
 /// Returns a string describing a <see cref='SqlBinary'/> object.
 /// </summary>
 public override string ToString() =>
 public override readonly string ToString() =>
 _value is null ? SQLResource.NullString : "SqlBinary(" + _value.Length.ToString(CultureInfo.InvariantCulture) + ")";

 // Unary operators
Expand DownExpand Up@@ -324,7 +324,7 @@ public static SqlBoolean GreaterThanOrEqual(SqlBinary x, SqlBinary y)
 }

 // Alternative method for conversions.
 public SqlGuid ToSqlGuid()
 public readonly SqlGuid ToSqlGuid()
 {
 return (SqlGuid)this;
 }
Expand All@@ -336,7 +336,7 @@ public SqlGuid ToSqlGuid()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBinary)
 {
Expand All@@ -347,7 +347,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBinary));
 }

 public int CompareTo(SqlBinary value)
 public readonly int CompareTo(SqlBinary value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -362,7 +362,7 @@ public int CompareTo(SqlBinary value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBinary))
 {
Expand DownExpand Up@@ -407,7 +407,7 @@ internal static int HashByteArray(byte[] rgbValue, int length)
 return ulValue;
 }
 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 if (_value is null)
 return 0;
Expand All@@ -420,7 +420,7 @@ public override int GetHashCode()
 return HashByteArray(_value, cbLen);
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down

40 changes: 20 additions & 20 deletions
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLBoolean.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ private SqlBoolean(int value, bool fNull)
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.Null'/>.
 /// </summary>
 public bool IsNull
 public readonly bool IsNull
 {
 get { return m_value == x_Null; }
 }
Expand All@@ -62,7 +62,7 @@ public bool IsNull
 /// <summary>
 /// Gets or sets the <see cref='SqlBoolean'/> to be <see langword='true'/> or <see langword='false'/>.
 /// </summary>
 public bool Value
 public readonly bool Value
 {
 get
 {
Expand All@@ -78,15 +78,15 @@ public bool Value
 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.True'/>.
 /// </summary>
 public bool IsTrue
 public readonly bool IsTrue
 {
 get { return m_value == x_True; }
 }

 /// <summary>
 /// Gets whether the current <see cref='Value'/> is <see cref='SqlBoolean.False'/>.
 /// </summary>
 public bool IsFalse
 public readonly bool IsFalse
 {
 get { return m_value == x_False; }
 }
Expand DownExpand Up@@ -173,7 +173,7 @@ public static bool operator false(SqlBoolean x)


 // property: ByteValue
 public byte ByteValue
 public readonly byte ByteValue
 {
 get
 {
Expand All@@ -184,7 +184,7 @@ public byte ByteValue
 }
 }

 public override string ToString()
 public override readonly string ToString()
 {
 return IsNull ? SQLResource.NullString : Value.ToString();
 }
Expand DownExpand Up@@ -384,47 +384,47 @@ public static SqlBoolean LessThanOrEquals(SqlBoolean x, SqlBoolean y)

 // Alternative method for conversions.

 public SqlByte ToSqlByte()
 public readonly SqlByte ToSqlByte()
 {
 return (SqlByte)this;
 }

 public SqlDouble ToSqlDouble()
 public readonly SqlDouble ToSqlDouble()
 {
 return (SqlDouble)this;
 }

 public SqlInt16 ToSqlInt16()
 public readonly SqlInt16 ToSqlInt16()
 {
 return (SqlInt16)this;
 }

 public SqlInt32 ToSqlInt32()
 public readonly SqlInt32 ToSqlInt32()
 {
 return (SqlInt32)this;
 }

 public SqlInt64 ToSqlInt64()
 public readonly SqlInt64 ToSqlInt64()
 {
 return (SqlInt64)this;
 }

 public SqlMoney ToSqlMoney()
 public readonly SqlMoney ToSqlMoney()
 {
 return (SqlMoney)this;
 }

 public SqlDecimal ToSqlDecimal()
 public readonly SqlDecimal ToSqlDecimal()
 {
 return (SqlDecimal)this;
 }

 public SqlSingle ToSqlSingle()
 public readonly SqlSingle ToSqlSingle()
 {
 return (SqlSingle)this;
 }

 public SqlString ToSqlString()
 public readonly SqlString ToSqlString()
 {
 return (SqlString)this;
 }
Expand All@@ -438,7 +438,7 @@ public SqlString ToSqlString()
 // or a value greater than zero if this > object.
 // null is considered to be less than any instance.
 // If object is not of same type, this method throws an ArgumentException.
 public int CompareTo(object? value)
 public readonly int CompareTo(object? value)
 {
 if (value is SqlBoolean)
 {
Expand All@@ -449,7 +449,7 @@ public int CompareTo(object? value)
 throw ADP.WrongType(value!.GetType(), typeof(SqlBoolean));
 }

 public int CompareTo(SqlBoolean value)
 public readonly int CompareTo(SqlBoolean value)
 {
 // If both Null, consider them equal.
 // Otherwise, Null is less than anything.
Expand All@@ -464,7 +464,7 @@ public int CompareTo(SqlBoolean value)
 }

 // Compares this instance with a specified object
 public override bool Equals(object? value)
 public override readonly bool Equals(object? value)
 {
 if (!(value is SqlBoolean))
 {
Expand All@@ -480,12 +480,12 @@ public override bool Equals(object? value)
 }

 // For hashing purpose
 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return IsNull ? 0 : Value.GetHashCode();
 }

 XmlSchema? IXmlSerializable.GetSchema() { return null; }
readonly XmlSchema? IXmlSerializable.GetSchema() { return null; }

 void IXmlSerializable.ReadXml(XmlReader reader)
 {
Expand Down
Loading