Skip to content

System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hrrrrustic wants to merge 3 commits into from
Closed

System.Xml readonly annotation #51798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ba46db
readonly annotation
hrrrrustic Apr 12, 2021
a1ae378
readonly annotation .Linq
hrrrrustic Apr 12, 2021
3e85b43
ref file
hrrrrustic Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
}
}

private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
{
string namespaceName = ns.NamespaceName;
if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
}
}

private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
{
string namespaceName = ns.NamespaceName;
if (namespaceName.Length == 0) return string.Empty;
Expand Down
10 changes: 5 additions & 5 deletions src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
internal uint m_data3;
internal uint m_data4;

public bool IsPositive
public readonly bool IsPositive
{
get
{
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
return (char)(uiDigit + '0');
}

public decimal ToDecimal()
public readonly decimal ToDecimal()
{
if ((int)m_data4 != 0 || m_bScale > 28)
throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

// Is this RE numeric valid?
[System.Diagnostics.Conditional("DEBUG")]
private void AssertValid()
private readonly void AssertValid()
{
// Scale,Prec in range
Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
public BinXmlSqlMoney(int v) { _data = v; }
public BinXmlSqlMoney(long v) { _data = v; }

public decimal ToDecimal()
public readonly decimal ToDecimal()
{
bool neg;
ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
}

public override string ToString()
public override readonly string ToString()
{
decimal money = ToDecimal();
// Formatting of SqlMoney: At least two digits after decimal point
Expand Down
20 changes: 10 additions & 10 deletions src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
this.prefix = this.localname = this.namespaceUri = string.Empty;
}

public bool MatchNs(string lname, string nsUri)
public readonly bool MatchNs(string lname, string nsUri)
{
return lname == this.localname && nsUri == this.namespaceUri;
}

public bool MatchPrefix(string prefix, string lname)
public readonly bool MatchPrefix(string prefix, string lname)
{
return lname == this.localname && prefix == this.prefix;
}

public void CheckPrefixNS(string prefix, string namespaceUri)
public readonly void CheckPrefixNS(string prefix, string namespaceUri)
{
if (this.prefix == prefix && this.namespaceUri != namespaceUri)
throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
}

public override int GetHashCode()
public override readonly int GetHashCode()
{
return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
}

public int GetNSHashCode()
public readonly int GetNSHashCode()
{
return HashCode.Combine(this.namespaceUri, this.localname);
}


public override bool Equals([NotNullWhen(true)] object? other)
public override readonly bool Equals([NotNullWhen(true)] object? other)
{
if (other is QName that)
{
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
return false;
}

public override string ToString()
public override readonly string ToString()
{
if (prefix.Length == 0)
return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
this.prevHash = 0;
}

public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
{
localname = this.name.localname;
namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
return this.hashCode = this.name.GetNSHashCode();
}

public bool MatchNS(string localname, string namespaceUri)
public readonly bool MatchNS(string localname, string namespaceUri)
{
return this.name.MatchNs(localname, namespaceUri);
}

public bool MatchHashNS(int hash, string localname, string namespaceUri)
public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
{
return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
}
Expand Down
12 changes: 6 additions & 6 deletions src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
/// <summary>
/// Return the page on which the next node will be allocated.
/// </summary>
public XPathNode[] NextNodePage
public readonly XPathNode[] NextNodePage
{
get { return _page; }
}

/// <summary>
/// Return the page index that the next node will be given.
/// </summary>
public int NextNodeIndex
public readonly int NextNodeIndex
{
get { return _pageInfo.NodeCount; }
}
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
/// <summary>
/// Return the type of the cached text block.
/// </summary>
public TextBlockType TextType
public readonly TextBlockType TextType
{
get { return _textType; }
}

/// <summary>
/// Returns true if text has been cached.
/// </summary>
public bool HasText
public readonly bool HasText
{
get { return _textType != TextBlockType.None; }
}

/// <summary>
/// Returns the line number of the last text block to be cached.
/// </summary>
public int LineNumber
public readonly int LineNumber
{
get { return _lineNum; }
}

/// <summary>
/// Returns the line position of the last text block to be cached.
/// </summary>
public int LinePosition
public readonly int LinePosition
{
get { return _linePos; }
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
System.Xml readonly annotation by hrrrrustic · Pull Request #51798 · dotnet/runtime · GitHub
Skip to content
System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


System.Xml readonly annotation
#51798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5ba46db

readonly annotation


hrrrrustic Apr 12, 2021
a1ae378

readonly annotation .Linq


hrrrrustic Apr 12, 2021
3e85b43

ref file


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
 internal uint m_data3;
 internal uint m_data4;

 public bool IsPositive
 public readonly bool IsPositive
 {
 get
 {
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
 return (char)(uiDigit + '0');
 }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 if ((int)m_data4 != 0 || m_bScale > 28)
 throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

 // Is this RE numeric valid?
 [System.Diagnostics.Conditional("DEBUG")]
 private void AssertValid()
 private readonly void AssertValid()
 {
 // Scale,Prec in range
 Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
 public BinXmlSqlMoney(int v) { _data = v; }
 public BinXmlSqlMoney(long v) { _data = v; }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 bool neg;
 ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
 return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
 }

 public override string ToString()
 public override readonly string ToString()
 {
 decimal money = ToDecimal();
 // Formatting of SqlMoney: At least two digits after decimal point
Expand Down

20 changes: 10 additions & 10 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
 this.prefix = this.localname = this.namespaceUri = string.Empty;
 }

 public bool MatchNs(string lname, string nsUri)
 public readonly bool MatchNs(string lname, string nsUri)
 {
 return lname == this.localname && nsUri == this.namespaceUri;
 }

 public bool MatchPrefix(string prefix, string lname)
 public readonly bool MatchPrefix(string prefix, string lname)
 {
 return lname == this.localname && prefix == this.prefix;
 }

 public void CheckPrefixNS(string prefix, string namespaceUri)
 public readonly void CheckPrefixNS(string prefix, string namespaceUri)
 {
 if (this.prefix == prefix && this.namespaceUri != namespaceUri)
 throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
 }

 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
 }

 public int GetNSHashCode()
 public readonly int GetNSHashCode()
 {
 return HashCode.Combine(this.namespaceUri, this.localname);
 }


 public override bool Equals([NotNullWhen(true)] object? other)
 public override readonly bool Equals([NotNullWhen(true)] object? other)
 {
 if (other is QName that)
 {
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
 return false;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 if (prefix.Length == 0)
 return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
 this.prevHash = 0;
 }

 public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 {
 localname = this.name.localname;
 namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
 return this.hashCode = this.name.GetNSHashCode();
 }

 public bool MatchNS(string localname, string namespaceUri)
 public readonly bool MatchNS(string localname, string namespaceUri)
 {
 return this.name.MatchNs(localname, namespaceUri);
 }

 public bool MatchHashNS(int hash, string localname, string namespaceUri)
 public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
 {
 return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
 }
Expand Down

12 changes: 6 additions & 6 deletions
src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
 /// <summary>
 /// Return the page on which the next node will be allocated.
 /// </summary>
 public XPathNode[] NextNodePage
 public readonly XPathNode[] NextNodePage
 {
 get { return _page; }
 }

 /// <summary>
 /// Return the page index that the next node will be given.
 /// </summary>
 public int NextNodeIndex
 public readonly int NextNodeIndex
 {
 get { return _pageInfo.NodeCount; }
 }
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
 /// <summary>
 /// Return the type of the cached text block.
 /// </summary>
 public TextBlockType TextType
 public readonly TextBlockType TextType
 {
 get { return _textType; }
 }

 /// <summary>
 /// Returns true if text has been cached.
 /// </summary>
 public bool HasText
 public readonly bool HasText
 {
 get { return _textType != TextBlockType.None; }
 }

 /// <summary>
 /// Returns the line number of the last text block to be cached.
 /// </summary>
 public int LineNumber
 public readonly int LineNumber
 {
 get { return _lineNum; }
 }

 /// <summary>
 /// Returns the line position of the last text block to be cached.
 /// </summary>
 public int LinePosition
 public readonly int LinePosition
 {
 get { return _linePos; }
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
System.Xml readonly annotation by hrrrrustic · Pull Request #51798 · dotnet/runtime · GitHub
Skip to content
System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


System.Xml readonly annotation
#51798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5ba46db

readonly annotation


hrrrrustic Apr 12, 2021
a1ae378

readonly annotation .Linq


hrrrrustic Apr 12, 2021
3e85b43

ref file


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
 internal uint m_data3;
 internal uint m_data4;

 public bool IsPositive
 public readonly bool IsPositive
 {
 get
 {
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
 return (char)(uiDigit + '0');
 }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 if ((int)m_data4 != 0 || m_bScale > 28)
 throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

 // Is this RE numeric valid?
 [System.Diagnostics.Conditional("DEBUG")]
 private void AssertValid()
 private readonly void AssertValid()
 {
 // Scale,Prec in range
 Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
 public BinXmlSqlMoney(int v) { _data = v; }
 public BinXmlSqlMoney(long v) { _data = v; }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 bool neg;
 ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
 return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
 }

 public override string ToString()
 public override readonly string ToString()
 {
 decimal money = ToDecimal();
 // Formatting of SqlMoney: At least two digits after decimal point
Expand Down

20 changes: 10 additions & 10 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
 this.prefix = this.localname = this.namespaceUri = string.Empty;
 }

 public bool MatchNs(string lname, string nsUri)
 public readonly bool MatchNs(string lname, string nsUri)
 {
 return lname == this.localname && nsUri == this.namespaceUri;
 }

 public bool MatchPrefix(string prefix, string lname)
 public readonly bool MatchPrefix(string prefix, string lname)
 {
 return lname == this.localname && prefix == this.prefix;
 }

 public void CheckPrefixNS(string prefix, string namespaceUri)
 public readonly void CheckPrefixNS(string prefix, string namespaceUri)
 {
 if (this.prefix == prefix && this.namespaceUri != namespaceUri)
 throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
 }

 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
 }

 public int GetNSHashCode()
 public readonly int GetNSHashCode()
 {
 return HashCode.Combine(this.namespaceUri, this.localname);
 }


 public override bool Equals([NotNullWhen(true)] object? other)
 public override readonly bool Equals([NotNullWhen(true)] object? other)
 {
 if (other is QName that)
 {
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
 return false;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 if (prefix.Length == 0)
 return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
 this.prevHash = 0;
 }

 public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 {
 localname = this.name.localname;
 namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
 return this.hashCode = this.name.GetNSHashCode();
 }

 public bool MatchNS(string localname, string namespaceUri)
 public readonly bool MatchNS(string localname, string namespaceUri)
 {
 return this.name.MatchNs(localname, namespaceUri);
 }

 public bool MatchHashNS(int hash, string localname, string namespaceUri)
 public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
 {
 return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
 }
Expand Down

12 changes: 6 additions & 6 deletions
src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
 /// <summary>
 /// Return the page on which the next node will be allocated.
 /// </summary>
 public XPathNode[] NextNodePage
 public readonly XPathNode[] NextNodePage
 {
 get { return _page; }
 }

 /// <summary>
 /// Return the page index that the next node will be given.
 /// </summary>
 public int NextNodeIndex
 public readonly int NextNodeIndex
 {
 get { return _pageInfo.NodeCount; }
 }
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
 /// <summary>
 /// Return the type of the cached text block.
 /// </summary>
 public TextBlockType TextType
 public readonly TextBlockType TextType
 {
 get { return _textType; }
 }

 /// <summary>
 /// Returns true if text has been cached.
 /// </summary>
 public bool HasText
 public readonly bool HasText
 {
 get { return _textType != TextBlockType.None; }
 }

 /// <summary>
 /// Returns the line number of the last text block to be cached.
 /// </summary>
 public int LineNumber
 public readonly int LineNumber
 {
 get { return _lineNum; }
 }

 /// <summary>
 /// Returns the line position of the last text block to be cached.
 /// </summary>
 public int LinePosition
 public readonly int LinePosition
 {
 get { return _linePos; }
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
System.Xml readonly annotation by hrrrrustic · Pull Request #51798 · dotnet/runtime · GitHub
Skip to content
System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


System.Xml readonly annotation
#51798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5ba46db

readonly annotation


hrrrrustic Apr 12, 2021
a1ae378

readonly annotation .Linq


hrrrrustic Apr 12, 2021
3e85b43

ref file


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
 internal uint m_data3;
 internal uint m_data4;

 public bool IsPositive
 public readonly bool IsPositive
 {
 get
 {
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
 return (char)(uiDigit + '0');
 }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 if ((int)m_data4 != 0 || m_bScale > 28)
 throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

 // Is this RE numeric valid?
 [System.Diagnostics.Conditional("DEBUG")]
 private void AssertValid()
 private readonly void AssertValid()
 {
 // Scale,Prec in range
 Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
 public BinXmlSqlMoney(int v) { _data = v; }
 public BinXmlSqlMoney(long v) { _data = v; }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 bool neg;
 ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
 return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
 }

 public override string ToString()
 public override readonly string ToString()
 {
 decimal money = ToDecimal();
 // Formatting of SqlMoney: At least two digits after decimal point
Expand Down

20 changes: 10 additions & 10 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
 this.prefix = this.localname = this.namespaceUri = string.Empty;
 }

 public bool MatchNs(string lname, string nsUri)
 public readonly bool MatchNs(string lname, string nsUri)
 {
 return lname == this.localname && nsUri == this.namespaceUri;
 }

 public bool MatchPrefix(string prefix, string lname)
 public readonly bool MatchPrefix(string prefix, string lname)
 {
 return lname == this.localname && prefix == this.prefix;
 }

 public void CheckPrefixNS(string prefix, string namespaceUri)
 public readonly void CheckPrefixNS(string prefix, string namespaceUri)
 {
 if (this.prefix == prefix && this.namespaceUri != namespaceUri)
 throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
 }

 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
 }

 public int GetNSHashCode()
 public readonly int GetNSHashCode()
 {
 return HashCode.Combine(this.namespaceUri, this.localname);
 }


 public override bool Equals([NotNullWhen(true)] object? other)
 public override readonly bool Equals([NotNullWhen(true)] object? other)
 {
 if (other is QName that)
 {
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
 return false;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 if (prefix.Length == 0)
 return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
 this.prevHash = 0;
 }

 public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 {
 localname = this.name.localname;
 namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
 return this.hashCode = this.name.GetNSHashCode();
 }

 public bool MatchNS(string localname, string namespaceUri)
 public readonly bool MatchNS(string localname, string namespaceUri)
 {
 return this.name.MatchNs(localname, namespaceUri);
 }

 public bool MatchHashNS(int hash, string localname, string namespaceUri)
 public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
 {
 return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
 }
Expand Down

12 changes: 6 additions & 6 deletions
src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
 /// <summary>
 /// Return the page on which the next node will be allocated.
 /// </summary>
 public XPathNode[] NextNodePage
 public readonly XPathNode[] NextNodePage
 {
 get { return _page; }
 }

 /// <summary>
 /// Return the page index that the next node will be given.
 /// </summary>
 public int NextNodeIndex
 public readonly int NextNodeIndex
 {
 get { return _pageInfo.NodeCount; }
 }
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
 /// <summary>
 /// Return the type of the cached text block.
 /// </summary>
 public TextBlockType TextType
 public readonly TextBlockType TextType
 {
 get { return _textType; }
 }

 /// <summary>
 /// Returns true if text has been cached.
 /// </summary>
 public bool HasText
 public readonly bool HasText
 {
 get { return _textType != TextBlockType.None; }
 }

 /// <summary>
 /// Returns the line number of the last text block to be cached.
 /// </summary>
 public int LineNumber
 public readonly int LineNumber
 {
 get { return _lineNum; }
 }

 /// <summary>
 /// Returns the line position of the last text block to be cached.
 /// </summary>
 public int LinePosition
 public readonly int LinePosition
 {
 get { return _linePos; }
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
System.Xml readonly annotation by hrrrrustic · Pull Request #51798 · dotnet/runtime · GitHub
Skip to content
System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


System.Xml readonly annotation
#51798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5ba46db

readonly annotation


hrrrrustic Apr 12, 2021
a1ae378

readonly annotation .Linq


hrrrrustic Apr 12, 2021
3e85b43

ref file


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
 internal uint m_data3;
 internal uint m_data4;

 public bool IsPositive
 public readonly bool IsPositive
 {
 get
 {
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
 return (char)(uiDigit + '0');
 }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 if ((int)m_data4 != 0 || m_bScale > 28)
 throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

 // Is this RE numeric valid?
 [System.Diagnostics.Conditional("DEBUG")]
 private void AssertValid()
 private readonly void AssertValid()
 {
 // Scale,Prec in range
 Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
 public BinXmlSqlMoney(int v) { _data = v; }
 public BinXmlSqlMoney(long v) { _data = v; }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 bool neg;
 ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
 return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
 }

 public override string ToString()
 public override readonly string ToString()
 {
 decimal money = ToDecimal();
 // Formatting of SqlMoney: At least two digits after decimal point
Expand Down

20 changes: 10 additions & 10 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
 this.prefix = this.localname = this.namespaceUri = string.Empty;
 }

 public bool MatchNs(string lname, string nsUri)
 public readonly bool MatchNs(string lname, string nsUri)
 {
 return lname == this.localname && nsUri == this.namespaceUri;
 }

 public bool MatchPrefix(string prefix, string lname)
 public readonly bool MatchPrefix(string prefix, string lname)
 {
 return lname == this.localname && prefix == this.prefix;
 }

 public void CheckPrefixNS(string prefix, string namespaceUri)
 public readonly void CheckPrefixNS(string prefix, string namespaceUri)
 {
 if (this.prefix == prefix && this.namespaceUri != namespaceUri)
 throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
 }

 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
 }

 public int GetNSHashCode()
 public readonly int GetNSHashCode()
 {
 return HashCode.Combine(this.namespaceUri, this.localname);
 }


 public override bool Equals([NotNullWhen(true)] object? other)
 public override readonly bool Equals([NotNullWhen(true)] object? other)
 {
 if (other is QName that)
 {
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
 return false;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 if (prefix.Length == 0)
 return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
 this.prevHash = 0;
 }

 public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 {
 localname = this.name.localname;
 namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
 return this.hashCode = this.name.GetNSHashCode();
 }

 public bool MatchNS(string localname, string namespaceUri)
 public readonly bool MatchNS(string localname, string namespaceUri)
 {
 return this.name.MatchNs(localname, namespaceUri);
 }

 public bool MatchHashNS(int hash, string localname, string namespaceUri)
 public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
 {
 return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
 }
Expand Down

12 changes: 6 additions & 6 deletions
src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
 /// <summary>
 /// Return the page on which the next node will be allocated.
 /// </summary>
 public XPathNode[] NextNodePage
 public readonly XPathNode[] NextNodePage
 {
 get { return _page; }
 }

 /// <summary>
 /// Return the page index that the next node will be given.
 /// </summary>
 public int NextNodeIndex
 public readonly int NextNodeIndex
 {
 get { return _pageInfo.NodeCount; }
 }
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
 /// <summary>
 /// Return the type of the cached text block.
 /// </summary>
 public TextBlockType TextType
 public readonly TextBlockType TextType
 {
 get { return _textType; }
 }

 /// <summary>
 /// Returns true if text has been cached.
 /// </summary>
 public bool HasText
 public readonly bool HasText
 {
 get { return _textType != TextBlockType.None; }
 }

 /// <summary>
 /// Returns the line number of the last text block to be cached.
 /// </summary>
 public int LineNumber
 public readonly int LineNumber
 {
 get { return _lineNum; }
 }

 /// <summary>
 /// Returns the line position of the last text block to be cached.
 /// </summary>
 public int LinePosition
 public readonly int LinePosition
 {
 get { return _linePos; }
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
System.Xml readonly annotation by hrrrrustic · Pull Request #51798 · dotnet/runtime · GitHub
Skip to content
System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


System.Xml readonly annotation
#51798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5ba46db

readonly annotation


hrrrrustic Apr 12, 2021
a1ae378

readonly annotation .Linq


hrrrrustic Apr 12, 2021
3e85b43

ref file


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
 internal uint m_data3;
 internal uint m_data4;

 public bool IsPositive
 public readonly bool IsPositive
 {
 get
 {
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
 return (char)(uiDigit + '0');
 }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 if ((int)m_data4 != 0 || m_bScale > 28)
 throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

 // Is this RE numeric valid?
 [System.Diagnostics.Conditional("DEBUG")]
 private void AssertValid()
 private readonly void AssertValid()
 {
 // Scale,Prec in range
 Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
 public BinXmlSqlMoney(int v) { _data = v; }
 public BinXmlSqlMoney(long v) { _data = v; }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 bool neg;
 ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
 return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
 }

 public override string ToString()
 public override readonly string ToString()
 {
 decimal money = ToDecimal();
 // Formatting of SqlMoney: At least two digits after decimal point
Expand Down

20 changes: 10 additions & 10 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
 this.prefix = this.localname = this.namespaceUri = string.Empty;
 }

 public bool MatchNs(string lname, string nsUri)
 public readonly bool MatchNs(string lname, string nsUri)
 {
 return lname == this.localname && nsUri == this.namespaceUri;
 }

 public bool MatchPrefix(string prefix, string lname)
 public readonly bool MatchPrefix(string prefix, string lname)
 {
 return lname == this.localname && prefix == this.prefix;
 }

 public void CheckPrefixNS(string prefix, string namespaceUri)
 public readonly void CheckPrefixNS(string prefix, string namespaceUri)
 {
 if (this.prefix == prefix && this.namespaceUri != namespaceUri)
 throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
 }

 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
 }

 public int GetNSHashCode()
 public readonly int GetNSHashCode()
 {
 return HashCode.Combine(this.namespaceUri, this.localname);
 }


 public override bool Equals([NotNullWhen(true)] object? other)
 public override readonly bool Equals([NotNullWhen(true)] object? other)
 {
 if (other is QName that)
 {
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
 return false;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 if (prefix.Length == 0)
 return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
 this.prevHash = 0;
 }

 public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 {
 localname = this.name.localname;
 namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
 return this.hashCode = this.name.GetNSHashCode();
 }

 public bool MatchNS(string localname, string namespaceUri)
 public readonly bool MatchNS(string localname, string namespaceUri)
 {
 return this.name.MatchNs(localname, namespaceUri);
 }

 public bool MatchHashNS(int hash, string localname, string namespaceUri)
 public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
 {
 return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
 }
Expand Down

12 changes: 6 additions & 6 deletions
src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
 /// <summary>
 /// Return the page on which the next node will be allocated.
 /// </summary>
 public XPathNode[] NextNodePage
 public readonly XPathNode[] NextNodePage
 {
 get { return _page; }
 }

 /// <summary>
 /// Return the page index that the next node will be given.
 /// </summary>
 public int NextNodeIndex
 public readonly int NextNodeIndex
 {
 get { return _pageInfo.NodeCount; }
 }
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
 /// <summary>
 /// Return the type of the cached text block.
 /// </summary>
 public TextBlockType TextType
 public readonly TextBlockType TextType
 {
 get { return _textType; }
 }

 /// <summary>
 /// Returns true if text has been cached.
 /// </summary>
 public bool HasText
 public readonly bool HasText
 {
 get { return _textType != TextBlockType.None; }
 }

 /// <summary>
 /// Returns the line number of the last text block to be cached.
 /// </summary>
 public int LineNumber
 public readonly int LineNumber
 {
 get { return _lineNum; }
 }

 /// <summary>
 /// Returns the line position of the last text block to be cached.
 /// </summary>
 public int LinePosition
 public readonly int LinePosition
 {
 get { return _linePos; }
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
System.Xml readonly annotation by hrrrrustic · Pull Request #51798 · dotnet/runtime · GitHub
Skip to content
System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


System.Xml readonly annotation
#51798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5ba46db

readonly annotation


hrrrrustic Apr 12, 2021
a1ae378

readonly annotation .Linq


hrrrrustic Apr 12, 2021
3e85b43

ref file


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
 internal uint m_data3;
 internal uint m_data4;

 public bool IsPositive
 public readonly bool IsPositive
 {
 get
 {
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
 return (char)(uiDigit + '0');
 }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 if ((int)m_data4 != 0 || m_bScale > 28)
 throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

 // Is this RE numeric valid?
 [System.Diagnostics.Conditional("DEBUG")]
 private void AssertValid()
 private readonly void AssertValid()
 {
 // Scale,Prec in range
 Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
 public BinXmlSqlMoney(int v) { _data = v; }
 public BinXmlSqlMoney(long v) { _data = v; }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 bool neg;
 ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
 return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
 }

 public override string ToString()
 public override readonly string ToString()
 {
 decimal money = ToDecimal();
 // Formatting of SqlMoney: At least two digits after decimal point
Expand Down

20 changes: 10 additions & 10 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
 this.prefix = this.localname = this.namespaceUri = string.Empty;
 }

 public bool MatchNs(string lname, string nsUri)
 public readonly bool MatchNs(string lname, string nsUri)
 {
 return lname == this.localname && nsUri == this.namespaceUri;
 }

 public bool MatchPrefix(string prefix, string lname)
 public readonly bool MatchPrefix(string prefix, string lname)
 {
 return lname == this.localname && prefix == this.prefix;
 }

 public void CheckPrefixNS(string prefix, string namespaceUri)
 public readonly void CheckPrefixNS(string prefix, string namespaceUri)
 {
 if (this.prefix == prefix && this.namespaceUri != namespaceUri)
 throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
 }

 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
 }

 public int GetNSHashCode()
 public readonly int GetNSHashCode()
 {
 return HashCode.Combine(this.namespaceUri, this.localname);
 }


 public override bool Equals([NotNullWhen(true)] object? other)
 public override readonly bool Equals([NotNullWhen(true)] object? other)
 {
 if (other is QName that)
 {
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
 return false;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 if (prefix.Length == 0)
 return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
 this.prevHash = 0;
 }

 public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 {
 localname = this.name.localname;
 namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
 return this.hashCode = this.name.GetNSHashCode();
 }

 public bool MatchNS(string localname, string namespaceUri)
 public readonly bool MatchNS(string localname, string namespaceUri)
 {
 return this.name.MatchNs(localname, namespaceUri);
 }

 public bool MatchHashNS(int hash, string localname, string namespaceUri)
 public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
 {
 return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
 }
Expand Down

12 changes: 6 additions & 6 deletions
src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
 /// <summary>
 /// Return the page on which the next node will be allocated.
 /// </summary>
 public XPathNode[] NextNodePage
 public readonly XPathNode[] NextNodePage
 {
 get { return _page; }
 }

 /// <summary>
 /// Return the page index that the next node will be given.
 /// </summary>
 public int NextNodeIndex
 public readonly int NextNodeIndex
 {
 get { return _pageInfo.NodeCount; }
 }
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
 /// <summary>
 /// Return the type of the cached text block.
 /// </summary>
 public TextBlockType TextType
 public readonly TextBlockType TextType
 {
 get { return _textType; }
 }

 /// <summary>
 /// Returns true if text has been cached.
 /// </summary>
 public bool HasText
 public readonly bool HasText
 {
 get { return _textType != TextBlockType.None; }
 }

 /// <summary>
 /// Returns the line number of the last text block to be cached.
 /// </summary>
 public int LineNumber
 public readonly int LineNumber
 {
 get { return _lineNum; }
 }

 /// <summary>
 /// Returns the line position of the last text block to be cached.
 /// </summary>
 public int LinePosition
 public readonly int LinePosition
 {
 get { return _linePos; }
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
System.Xml readonly annotation by hrrrrustic · Pull Request #51798 · dotnet/runtime · GitHub
Skip to content
System.Xml readonly annotation#51798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

hrrrrustic
wants to merge
3
commits into

from

 Closed


System.Xml readonly annotation
#51798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5ba46db

readonly annotation


hrrrrustic Apr 12, 2021
a1ae378

readonly annotation .Linq


hrrrrustic Apr 12, 2021
3e85b43

ref file


hrrrrustic Apr 12, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XLinq.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -292,7 +292,7 @@ public async Task WriteElementAsync(XElement e, CancellationToken cancellationTo
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand DownExpand Up@@ -556,7 +556,7 @@ private void FlushElement()
 }
 }

 private string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 private readonly string? GetPrefixOfNamespace(XNamespace ns, bool allowDefaultNamespace)
 {
 string namespaceName = ns.NamespaceName;
 if (namespaceName.Length == 0) return string.Empty;
Expand Down

10 changes: 5 additions & 5 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/SqlUtils.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ internal struct BinXmlSqlDecimal
 internal uint m_data3;
 internal uint m_data4;

 public bool IsPositive
 public readonly bool IsPositive
 {
 get
 {
Expand DownExpand Up@@ -139,7 +139,7 @@ private static char ChFromDigit(uint uiDigit)
 return (char)(uiDigit + '0');
 }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 if ((int)m_data4 != 0 || m_bScale > 28)
 throw new XmlException(SR.SqlTypes_ArithOverflow, (string?)null);
Expand DownExpand Up@@ -246,7 +246,7 @@ public override string ToString()

 // Is this RE numeric valid?
 [System.Diagnostics.Conditional("DEBUG")]
 private void AssertValid()
 private readonly void AssertValid()
 {
 // Scale,Prec in range
 Debug.Assert(m_bScale <= s_NUMERIC_MAX_PRECISION, "m_bScale <= NUMERIC_MAX_PRECISION", "In AssertValid");
Expand DownExpand Up@@ -277,7 +277,7 @@ internal struct BinXmlSqlMoney
 public BinXmlSqlMoney(int v) { _data = v; }
 public BinXmlSqlMoney(long v) { _data = v; }

 public decimal ToDecimal()
 public readonly decimal ToDecimal()
 {
 bool neg;
 ulong v;
Expand All@@ -296,7 +296,7 @@ public decimal ToDecimal()
 return new decimal(unchecked((int)v), unchecked((int)(v >> 32)), 0, neg, MoneyScale);
 }

 public override string ToString()
 public override readonly string ToString()
 {
 decimal money = ToDecimal();
 // Formatting of SqlMoney: At least two digits after decimal point
Expand Down

20 changes: 10 additions & 10 deletions
src/libraries/System.Private.Xml/src/System/Xml/BinaryXml/XmlBinaryReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,34 +79,34 @@ public void Clear()
 this.prefix = this.localname = this.namespaceUri = string.Empty;
 }

 public bool MatchNs(string lname, string nsUri)
 public readonly bool MatchNs(string lname, string nsUri)
 {
 return lname == this.localname && nsUri == this.namespaceUri;
 }

 public bool MatchPrefix(string prefix, string lname)
 public readonly bool MatchPrefix(string prefix, string lname)
 {
 return lname == this.localname && prefix == this.prefix;
 }

 public void CheckPrefixNS(string prefix, string namespaceUri)
 public readonly void CheckPrefixNS(string prefix, string namespaceUri)
 {
 if (this.prefix == prefix && this.namespaceUri != namespaceUri)
 throw new XmlException(SR.XmlBinary_NoRemapPrefix, new string[] { prefix, this.namespaceUri, namespaceUri });
 }

 public override int GetHashCode()
 public override readonly int GetHashCode()
 {
 return this.prefix.GetHashCode() ^ this.localname.GetHashCode();
 }

 public int GetNSHashCode()
 public readonly int GetNSHashCode()
 {
 return HashCode.Combine(this.namespaceUri, this.localname);
 }


 public override bool Equals([NotNullWhen(true)] object? other)
 public override readonly bool Equals([NotNullWhen(true)] object? other)
 {
 if (other is QName that)
 {
Expand All@@ -115,7 +115,7 @@ public override bool Equals([NotNullWhen(true)] object? other)
 return false;
 }

 public override string ToString()
 public override readonly string ToString()
 {
 if (prefix.Length == 0)
 return this.localname;
Expand DownExpand Up@@ -185,7 +185,7 @@ public void Set(QName n, int pos)
 this.prevHash = 0;
 }

 public void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 public readonly void GetLocalnameAndNamespaceUri(out string localname, out string namespaceUri)
 {
 localname = this.name.localname;
 namespaceUri = this.name.namespaceUri;
Expand All@@ -198,12 +198,12 @@ public int GetLocalnameAndNamespaceUriAndHash(out string localname, out string n
 return this.hashCode = this.name.GetNSHashCode();
 }

 public bool MatchNS(string localname, string namespaceUri)
 public readonly bool MatchNS(string localname, string namespaceUri)
 {
 return this.name.MatchNs(localname, namespaceUri);
 }

 public bool MatchHashNS(int hash, string localname, string namespaceUri)
 public readonly bool MatchHashNS(int hash, string localname, string namespaceUri)
 {
 return this.hashCode == hash && this.name.MatchNs(localname, namespaceUri);
 }
Expand Down

12 changes: 6 additions & 6 deletions
src/libraries/System.Private.Xml/src/System/Xml/Cache/XPathDocumentBuilder.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -807,15 +807,15 @@ public void Init(int initialPageSize)
 /// <summary>
 /// Return the page on which the next node will be allocated.
 /// </summary>
 public XPathNode[] NextNodePage
 public readonly XPathNode[] NextNodePage
 {
 get { return _page; }
 }

 /// <summary>
 /// Return the page index that the next node will be given.
 /// </summary>
 public int NextNodeIndex
 public readonly int NextNodeIndex
 {
 get { return _pageInfo.NodeCount; }
 }
Expand DownExpand Up@@ -867,31 +867,31 @@ public void Initialize(IXmlLineInfo? lineInfo)
 /// <summary>
 /// Return the type of the cached text block.
 /// </summary>
 public TextBlockType TextType
 public readonly TextBlockType TextType
 {
 get { return _textType; }
 }

 /// <summary>
 /// Returns true if text has been cached.
 /// </summary>
 public bool HasText
 public readonly bool HasText
 {
 get { return _textType != TextBlockType.None; }
 }

 /// <summary>
 /// Returns the line number of the last text block to be cached.
 /// </summary>
 public int LineNumber
 public readonly int LineNumber
 {
 get { return _lineNum; }
 }

 /// <summary>
 /// Returns the line position of the last text block to be cached.
 /// </summary>
 public int LinePosition
 public readonly int LinePosition
 {
 get { return _linePos; }
 }
Expand Down
Loading