Skip to content

Closing opened handles to avoid resource leak. - #51950

Merged
mikem8361 merged 1 commit into
dotnet:mainfrom
Sundow:issue-50422
May 25, 2021
Merged

Closing opened handles to avoid resource leak.#51950
mikem8361 merged 1 commit into
dotnet:mainfrom
Sundow:issue-50422

Conversation

@Sundow

Copy link
Copy Markdown
Contributor

SymReader::InitializeFromFile opens file handles which were not closed causing resource leaks on each call.

Fix#50422

SymReader::InitializeFromFile opens file handles which were not closed causing resource leaks on each call.
Fixdotnet#50422
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

SymReader::InitializeFromFile opens file handles which were not closed causing resource leaks on each call.

Fix #50422

Author:Sundow
Assignees:-
Labels:

area-Diagnostics-coreclr

Milestone:-

@tommcdon
tommcdon requested a review from mikem8361May 21, 2021 04:44
@tommcdon

Copy link
Copy Markdown
Member

@mikem8361 PTAL

@Sundow

Copy link
Copy Markdown
ContributorAuthor

Is there anything left to do for me after this pull request is approved? Or just waiting for someone with write access to merge?

@mikem8361
mikem8361 merged commit c90debb into dotnet:mainMay 25, 2021
@Sundow
Sundow deleted the issue-50422 branch May 26, 2021 07:31
@ghostghost locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SymReader::InitializeFromFile opens a few handles but never closes them

3 participants

@Sundow@tommcdon@mikem8361