Skip to content

Obsolete the Rijndael and RijndaelManaged classes - #52366

Merged
bartonjs merged 2 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/obsolete-rijndael
May 6, 2021
Merged

Obsolete the Rijndael and RijndaelManaged classes#52366
bartonjs merged 2 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/obsolete-rijndael

Conversation

@jeffhandley

@jeffhandleyjeffhandley commented May 6, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#46930, marking the Rijndael and RijndaelManaged classes as obsolete, guiding usage toward Aes.

@jeffhandleyjeffhandley added area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a previous release. labels May 6, 2021
@jeffhandley
jeffhandley requested a review from bartonjsMay 6, 2021 07:07
@ghost

ghost commented May 6, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #46930, marking the Rijndael and RijndaelManaged classes as obsolete, guiding usage toward Aes and AesManaged.

Author:jeffhandley
Assignees:-
Labels:

area-System.Security, breaking-change

Milestone:-

@ghost

ghost commented May 6, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added new-api-needs-documentation needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels May 6, 2021
@jeffhandleyjeffhandley mentioned this pull request May 6, 2021
Closed
14 tasks
@jeffhandley

jeffhandley commented May 6, 2021

Copy link
Copy Markdown
MemberAuthor

The breaking change documentation will be covered by dotnet/docs#23856.

/cc @gewarren

@jeffhandleyjeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label May 6, 2021
@filipnavara

filipnavara commented May 6, 2021

Copy link
Copy Markdown
Member

#52303 is making AesManaged obsolete, shouldn't this point straight to Aes only?

@jeffhandley

jeffhandley commented May 6, 2021

Copy link
Copy Markdown
MemberAuthor

#52303 is making AesManaged obsolete, shouldn't this point straight to Aes only?

Great catch; thanks!

@bartonjs
bartonjs merged commit 7ea26e6 into dotnet:mainMay 6, 2021
@jeffhandley
jeffhandley deleted the jeffhandley/obsolete-rijndael branch May 6, 2021 17:13
@jeffhandleyjeffhandley mentioned this pull request May 6, 2021
Merged
@karelzkarelz added this to the 6.0.0 milestone May 20, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjsbartonjsbartonjs approved these changes

Assignees

No one assigned

Labels

area-System.Securitybreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Obsolete the Rijndael and RijndaelManaged classes

4 participants

@jeffhandley@filipnavara@bartonjs@karelz