Fix WaitForConnectionAsync when NamedPipeServerStream is disposed - #52825

Merged

stephentoub merged 8 commits into

dotnet:mainfrom

manandre:dispose-shared-namedpipeserverstream

Jul 18, 2021

manandre commented May 16, 2021

Contributor

/cc @jaredpar @davidfowl

ghost added the area-System.IO label

ghost commented May 16, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #40674

/cc @jaredpar @davidfowl

Author:	manandre
Assignees:	-
Labels:	`area-System.IO`
Milestone:	-

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs Outdated

stephentoub approved these changes

View reviewed changes

manandre force-pushed the dispose-shared-namedpipeserverstream branch from b13a2c5 to 6e6e7bbCompare

May 26, 2021 18:46

manandreand others added 6 commits

June 1, 2021 19:13

Fix WaitForConnectionAsync when NamedPipeServerStream is disposed

bfb150e

Align Unix implementation on broken pipe IO exception as on Windows

4c02549

Add missing methods to test against ObjectDisposedException

5ede4a3

Apply suggestions from code review

7e5d486

Co-authored-by: Stephen Toub <stoub@microsoft.com>

Rebase and fix suggestions

64f7e78

Cancel Accept on dispose

ef60a2f

manandre force-pushed the dispose-shared-namedpipeserverstream branch from 6e6e7bb to ef60a2fCompare

June 1, 2021 22:09

Improve test

8a6e802

manandre requested a review from stephentoub

June 2, 2021 21:45

stephentoub reviewed

View reviewed changes

src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs Outdated

src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs Outdated

Apply suggestions from code review

edf50b3

stephentoub approved these changes

View reviewed changes

stephentoub merged commit c5edf0e into dotnet:main

ManickaP mentioned this pull request

[QUIC] Remove AppContext switch from S.N.Quic #56027

Merged

ghost locked as resolved and limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.