[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdh1418 merged 13 commits into from
May 19, 2021
Merged

[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip #52859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
863699a
[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform
May 17, 2021
9871fe4
[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…
May 17, 2021
aa482fc
[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …
May 17, 2021
6c58373
[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…
May 17, 2021
bff22a3
[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform
May 17, 2021
8e75ea4
[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…
May 17, 2021
64d012a
[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…
May 17, 2021
c863805
[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue
May 17, 2021
6fb59b7
[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue
May 17, 2021
aedde8d
[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue
May 17, 2021
f684019
[MacCatalyst][libraries] Remove test project level skips
May 17, 2021
671cfb3
[MacCatalyst] Add forgotten PNSE and ActiveIssue
May 18, 2021
cd95e8a
[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…
May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
public partial class HostTests
{
[Fact]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
public async Task StopAsyncWithCancellation()
{
var builder = new HostBuilder();
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
// path that followed the symlink.
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
public void ChDir()
{
var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
// Can't get current directory on OSX before setting it.
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
public void CurDir()
{
Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down
1 change: 1 addition & 0 deletions ...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
// path that followed the symlink.
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
public void CurrentDirectorySet()
{
var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Console/tests/CancelKeyPress.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
private const int WaitFailTestTimeoutSeconds = 30;

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void CanAddAndRemoveHandler()
{
ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Console/tests/Color.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void InvalidColors()
{
AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void RoundtrippingColor()
{
Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void RedirectedOutputDoesNotUseAnsiSequences()
{
// Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Console/tests/ConsoleEncoding.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

[Theory]
[MemberData(nameof(InputData))]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public void TestEncoding(string inputString)
{
TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public void TestValidEncodings()
{
Action<Encoding> check = encoding =>
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Console/tests/ReadAndWrite.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static unsafe void OutputEncodingPreamble()
{
Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static unsafe void OutputEncoding()
{
Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
};

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void ReadAndReadLine()
{
TextWriter savedStandardOutput = Console.Out;
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Console/tests/SetIn.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void SetInThrowsOnNull()
{
TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void SetInReadLine()
{
const string TextStringFormat = "Test {0}";
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Console/tests/SyncTextReader.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
// NOTE: These tests test the underlying SyncTextReader by
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Console/tests/ThreadSafety.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
const int NumberOfIterations = 100;

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void OpenStandardXXXCanBeCalledConcurrently()
{
Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void SetStandardXXXCanBeCalledConcurrently()
{
TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void ReadMayBeCalledConcurrently()
{
const char TestChar = '+';
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.Console/tests/Timeout.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void OpenStandardXXX_WriteTimeOut()
{
using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void OpenStandardXXX_ReadTimeOut()
{
using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void OpenStandardXXX_CanTimeOut()
{
using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down
28 changes: 14 additions & 14 deletions src/libraries/System.Console/tests/WindowAndCursorProps.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
public static void BufferWidth_GetUnix_ReturnsWindowWidth()
{
Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
public static void BufferHeight_GetUnix_ReturnsWindowHeight()
{
Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
public static void WindowWidth_GetUnix_Success()
{
// Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
public static void WindowHeight_GetUnix_Success()
{
// Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
public static void LargestWindowWidth_UnixGet_ReturnsExpected()
{
Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
public static void LargestWindowHeight_UnixGet_ReturnsExpected()
{
Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
}

[Theory]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
[InlineData(true)]
[InlineData(false)]
public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void SetCursorPosition_Invoke_Success()
{
if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public static void GetCursorPosition_Invoke_ReturnsExpected()
{
if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public void CursorLeft_Set_GetReturnsExpected()
{
if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
[Theory]
[InlineData(-1)]
[InlineData(short.MaxValue + 1)]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
{
if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public void CursorTop_Set_GetReturnsExpected()
{
if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
[Theory]
[InlineData(-1)]
[InlineData(short.MaxValue + 1)]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
{
if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
}

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
public void CursorSize_GetUnix_ReturnsExpected()
{
Assert.Equal(100, Console.CursorSize);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mdh1418
merged 13 commits into

from

May 19, 2021
 Merged


[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip
#52859
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
863699a

[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform

May 17, 2021
9871fe4

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…

May 17, 2021
aa482fc

[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …

May 17, 2021
6c58373

[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…

May 17, 2021
bff22a3

[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform

May 17, 2021
8e75ea4

[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…

May 17, 2021
64d012a

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…

May 17, 2021
c863805

[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue

May 17, 2021
6fb59b7

[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue

May 17, 2021
aedde8d

[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue

May 17, 2021
f684019

[MacCatalyst][libraries] Remove test project level skips

May 17, 2021
671cfb3

[MacCatalyst] Add forgotten PNSE and ActiveIssue

May 18, 2021
cd95e8a

[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…

May 18, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
 public partial class HostTests
 {
 [Fact]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
 public async Task StopAsyncWithCancellation()
 {
 var builder = new HostBuilder();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void ChDir()
 {
 var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
 // Can't get current directory on OSX before setting it.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurDir()
 {
 Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down

1 change: 1 addition & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurrentDirectorySet()
 {
 var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/CancelKeyPress.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
 private const int WaitFailTestTimeoutSeconds = 30;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void CanAddAndRemoveHandler()
 {
 ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Color.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void InvalidColors()
 {
 AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
 AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RoundtrippingColor()
 {
 Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RedirectedOutputDoesNotUseAnsiSequences()
 {
 // Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/ConsoleEncoding.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

 [Theory]
 [MemberData(nameof(InputData))]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestEncoding(string inputString)
 {
 TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestValidEncodings()
 {
 Action<Encoding> check = encoding =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ReadAndWrite.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncodingPreamble()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncoding()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
 };

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadAndReadLine()
 {
 TextWriter savedStandardOutput = Console.Out;
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/SetIn.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInThrowsOnNull()
 {
 TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInReadLine()
 {
 const string TextStringFormat = "Test {0}";
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/SyncTextReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
 // NOTE: These tests test the underlying SyncTextReader by
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ThreadSafety.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
 const int NumberOfIterations = 100;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXXCanBeCalledConcurrently()
 {
 Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetStandardXXXCanBeCalledConcurrently()
 {
 TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadMayBeCalledConcurrently()
 {
 const char TestChar = '+';
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Timeout.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_WriteTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_ReadTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_CanTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down

28 changes: 14 additions & 14 deletions
src/libraries/System.Console/tests/WindowAndCursorProps.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferWidth_GetUnix_ReturnsWindowWidth()
 {
 Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferHeight_GetUnix_ReturnsWindowHeight()
 {
 Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowWidth_GetUnix_Success()
 {
 // Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowHeight_GetUnix_Success()
 {
 // Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowWidth_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowHeight_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
 }

 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [InlineData(true)]
 [InlineData(false)]
 public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetCursorPosition_Invoke_Success()
 {
 if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void GetCursorPosition_Invoke_ReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
 public void CursorSize_GetUnix_ReturnsExpected()
 {
 Assert.Equal(100, Console.CursorSize);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mdh1418
merged 13 commits into

from

May 19, 2021
 Merged


[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip
#52859
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
863699a

[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform

May 17, 2021
9871fe4

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…

May 17, 2021
aa482fc

[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …

May 17, 2021
6c58373

[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…

May 17, 2021
bff22a3

[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform

May 17, 2021
8e75ea4

[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…

May 17, 2021
64d012a

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…

May 17, 2021
c863805

[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue

May 17, 2021
6fb59b7

[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue

May 17, 2021
aedde8d

[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue

May 17, 2021
f684019

[MacCatalyst][libraries] Remove test project level skips

May 17, 2021
671cfb3

[MacCatalyst] Add forgotten PNSE and ActiveIssue

May 18, 2021
cd95e8a

[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…

May 18, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
 public partial class HostTests
 {
 [Fact]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
 public async Task StopAsyncWithCancellation()
 {
 var builder = new HostBuilder();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void ChDir()
 {
 var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
 // Can't get current directory on OSX before setting it.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurDir()
 {
 Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down

1 change: 1 addition & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurrentDirectorySet()
 {
 var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/CancelKeyPress.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
 private const int WaitFailTestTimeoutSeconds = 30;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void CanAddAndRemoveHandler()
 {
 ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Color.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void InvalidColors()
 {
 AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
 AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RoundtrippingColor()
 {
 Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RedirectedOutputDoesNotUseAnsiSequences()
 {
 // Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/ConsoleEncoding.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

 [Theory]
 [MemberData(nameof(InputData))]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestEncoding(string inputString)
 {
 TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestValidEncodings()
 {
 Action<Encoding> check = encoding =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ReadAndWrite.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncodingPreamble()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncoding()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
 };

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadAndReadLine()
 {
 TextWriter savedStandardOutput = Console.Out;
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/SetIn.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInThrowsOnNull()
 {
 TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInReadLine()
 {
 const string TextStringFormat = "Test {0}";
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/SyncTextReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
 // NOTE: These tests test the underlying SyncTextReader by
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ThreadSafety.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
 const int NumberOfIterations = 100;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXXCanBeCalledConcurrently()
 {
 Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetStandardXXXCanBeCalledConcurrently()
 {
 TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadMayBeCalledConcurrently()
 {
 const char TestChar = '+';
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Timeout.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_WriteTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_ReadTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_CanTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down

28 changes: 14 additions & 14 deletions
src/libraries/System.Console/tests/WindowAndCursorProps.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferWidth_GetUnix_ReturnsWindowWidth()
 {
 Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferHeight_GetUnix_ReturnsWindowHeight()
 {
 Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowWidth_GetUnix_Success()
 {
 // Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowHeight_GetUnix_Success()
 {
 // Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowWidth_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowHeight_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
 }

 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [InlineData(true)]
 [InlineData(false)]
 public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetCursorPosition_Invoke_Success()
 {
 if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void GetCursorPosition_Invoke_ReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
 public void CursorSize_GetUnix_ReturnsExpected()
 {
 Assert.Equal(100, Console.CursorSize);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mdh1418
merged 13 commits into

from

May 19, 2021
 Merged


[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip
#52859
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
863699a

[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform

May 17, 2021
9871fe4

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…

May 17, 2021
aa482fc

[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …

May 17, 2021
6c58373

[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…

May 17, 2021
bff22a3

[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform

May 17, 2021
8e75ea4

[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…

May 17, 2021
64d012a

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…

May 17, 2021
c863805

[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue

May 17, 2021
6fb59b7

[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue

May 17, 2021
aedde8d

[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue

May 17, 2021
f684019

[MacCatalyst][libraries] Remove test project level skips

May 17, 2021
671cfb3

[MacCatalyst] Add forgotten PNSE and ActiveIssue

May 18, 2021
cd95e8a

[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…

May 18, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
 public partial class HostTests
 {
 [Fact]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
 public async Task StopAsyncWithCancellation()
 {
 var builder = new HostBuilder();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void ChDir()
 {
 var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
 // Can't get current directory on OSX before setting it.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurDir()
 {
 Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down

1 change: 1 addition & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurrentDirectorySet()
 {
 var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/CancelKeyPress.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
 private const int WaitFailTestTimeoutSeconds = 30;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void CanAddAndRemoveHandler()
 {
 ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Color.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void InvalidColors()
 {
 AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
 AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RoundtrippingColor()
 {
 Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RedirectedOutputDoesNotUseAnsiSequences()
 {
 // Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/ConsoleEncoding.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

 [Theory]
 [MemberData(nameof(InputData))]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestEncoding(string inputString)
 {
 TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestValidEncodings()
 {
 Action<Encoding> check = encoding =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ReadAndWrite.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncodingPreamble()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncoding()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
 };

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadAndReadLine()
 {
 TextWriter savedStandardOutput = Console.Out;
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/SetIn.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInThrowsOnNull()
 {
 TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInReadLine()
 {
 const string TextStringFormat = "Test {0}";
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/SyncTextReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
 // NOTE: These tests test the underlying SyncTextReader by
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ThreadSafety.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
 const int NumberOfIterations = 100;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXXCanBeCalledConcurrently()
 {
 Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetStandardXXXCanBeCalledConcurrently()
 {
 TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadMayBeCalledConcurrently()
 {
 const char TestChar = '+';
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Timeout.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_WriteTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_ReadTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_CanTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down

28 changes: 14 additions & 14 deletions
src/libraries/System.Console/tests/WindowAndCursorProps.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferWidth_GetUnix_ReturnsWindowWidth()
 {
 Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferHeight_GetUnix_ReturnsWindowHeight()
 {
 Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowWidth_GetUnix_Success()
 {
 // Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowHeight_GetUnix_Success()
 {
 // Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowWidth_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowHeight_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
 }

 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [InlineData(true)]
 [InlineData(false)]
 public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetCursorPosition_Invoke_Success()
 {
 if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void GetCursorPosition_Invoke_ReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
 public void CursorSize_GetUnix_ReturnsExpected()
 {
 Assert.Equal(100, Console.CursorSize);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mdh1418
merged 13 commits into

from

May 19, 2021
 Merged


[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip
#52859
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
863699a

[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform

May 17, 2021
9871fe4

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…

May 17, 2021
aa482fc

[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …

May 17, 2021
6c58373

[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…

May 17, 2021
bff22a3

[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform

May 17, 2021
8e75ea4

[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…

May 17, 2021
64d012a

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…

May 17, 2021
c863805

[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue

May 17, 2021
6fb59b7

[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue

May 17, 2021
aedde8d

[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue

May 17, 2021
f684019

[MacCatalyst][libraries] Remove test project level skips

May 17, 2021
671cfb3

[MacCatalyst] Add forgotten PNSE and ActiveIssue

May 18, 2021
cd95e8a

[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…

May 18, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
 public partial class HostTests
 {
 [Fact]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
 public async Task StopAsyncWithCancellation()
 {
 var builder = new HostBuilder();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void ChDir()
 {
 var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
 // Can't get current directory on OSX before setting it.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurDir()
 {
 Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down

1 change: 1 addition & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurrentDirectorySet()
 {
 var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/CancelKeyPress.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
 private const int WaitFailTestTimeoutSeconds = 30;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void CanAddAndRemoveHandler()
 {
 ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Color.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void InvalidColors()
 {
 AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
 AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RoundtrippingColor()
 {
 Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RedirectedOutputDoesNotUseAnsiSequences()
 {
 // Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/ConsoleEncoding.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

 [Theory]
 [MemberData(nameof(InputData))]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestEncoding(string inputString)
 {
 TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestValidEncodings()
 {
 Action<Encoding> check = encoding =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ReadAndWrite.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncodingPreamble()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncoding()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
 };

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadAndReadLine()
 {
 TextWriter savedStandardOutput = Console.Out;
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/SetIn.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInThrowsOnNull()
 {
 TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInReadLine()
 {
 const string TextStringFormat = "Test {0}";
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/SyncTextReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
 // NOTE: These tests test the underlying SyncTextReader by
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ThreadSafety.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
 const int NumberOfIterations = 100;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXXCanBeCalledConcurrently()
 {
 Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetStandardXXXCanBeCalledConcurrently()
 {
 TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadMayBeCalledConcurrently()
 {
 const char TestChar = '+';
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Timeout.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_WriteTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_ReadTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_CanTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down

28 changes: 14 additions & 14 deletions
src/libraries/System.Console/tests/WindowAndCursorProps.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferWidth_GetUnix_ReturnsWindowWidth()
 {
 Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferHeight_GetUnix_ReturnsWindowHeight()
 {
 Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowWidth_GetUnix_Success()
 {
 // Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowHeight_GetUnix_Success()
 {
 // Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowWidth_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowHeight_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
 }

 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [InlineData(true)]
 [InlineData(false)]
 public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetCursorPosition_Invoke_Success()
 {
 if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void GetCursorPosition_Invoke_ReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
 public void CursorSize_GetUnix_ReturnsExpected()
 {
 Assert.Equal(100, Console.CursorSize);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mdh1418
merged 13 commits into

from

May 19, 2021
 Merged


[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip
#52859
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
863699a

[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform

May 17, 2021
9871fe4

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…

May 17, 2021
aa482fc

[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …

May 17, 2021
6c58373

[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…

May 17, 2021
bff22a3

[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform

May 17, 2021
8e75ea4

[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…

May 17, 2021
64d012a

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…

May 17, 2021
c863805

[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue

May 17, 2021
6fb59b7

[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue

May 17, 2021
aedde8d

[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue

May 17, 2021
f684019

[MacCatalyst][libraries] Remove test project level skips

May 17, 2021
671cfb3

[MacCatalyst] Add forgotten PNSE and ActiveIssue

May 18, 2021
cd95e8a

[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…

May 18, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
 public partial class HostTests
 {
 [Fact]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
 public async Task StopAsyncWithCancellation()
 {
 var builder = new HostBuilder();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void ChDir()
 {
 var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
 // Can't get current directory on OSX before setting it.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurDir()
 {
 Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down

1 change: 1 addition & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurrentDirectorySet()
 {
 var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/CancelKeyPress.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
 private const int WaitFailTestTimeoutSeconds = 30;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void CanAddAndRemoveHandler()
 {
 ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Color.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void InvalidColors()
 {
 AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
 AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RoundtrippingColor()
 {
 Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RedirectedOutputDoesNotUseAnsiSequences()
 {
 // Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/ConsoleEncoding.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

 [Theory]
 [MemberData(nameof(InputData))]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestEncoding(string inputString)
 {
 TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestValidEncodings()
 {
 Action<Encoding> check = encoding =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ReadAndWrite.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncodingPreamble()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncoding()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
 };

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadAndReadLine()
 {
 TextWriter savedStandardOutput = Console.Out;
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/SetIn.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInThrowsOnNull()
 {
 TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInReadLine()
 {
 const string TextStringFormat = "Test {0}";
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/SyncTextReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
 // NOTE: These tests test the underlying SyncTextReader by
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ThreadSafety.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
 const int NumberOfIterations = 100;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXXCanBeCalledConcurrently()
 {
 Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetStandardXXXCanBeCalledConcurrently()
 {
 TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadMayBeCalledConcurrently()
 {
 const char TestChar = '+';
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Timeout.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_WriteTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_ReadTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_CanTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down

28 changes: 14 additions & 14 deletions
src/libraries/System.Console/tests/WindowAndCursorProps.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferWidth_GetUnix_ReturnsWindowWidth()
 {
 Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferHeight_GetUnix_ReturnsWindowHeight()
 {
 Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowWidth_GetUnix_Success()
 {
 // Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowHeight_GetUnix_Success()
 {
 // Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowWidth_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowHeight_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
 }

 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [InlineData(true)]
 [InlineData(false)]
 public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetCursorPosition_Invoke_Success()
 {
 if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void GetCursorPosition_Invoke_ReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
 public void CursorSize_GetUnix_ReturnsExpected()
 {
 Assert.Equal(100, Console.CursorSize);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mdh1418
merged 13 commits into

from

May 19, 2021
 Merged


[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip
#52859
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
863699a

[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform

May 17, 2021
9871fe4

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…

May 17, 2021
aa482fc

[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …

May 17, 2021
6c58373

[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…

May 17, 2021
bff22a3

[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform

May 17, 2021
8e75ea4

[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…

May 17, 2021
64d012a

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…

May 17, 2021
c863805

[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue

May 17, 2021
6fb59b7

[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue

May 17, 2021
aedde8d

[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue

May 17, 2021
f684019

[MacCatalyst][libraries] Remove test project level skips

May 17, 2021
671cfb3

[MacCatalyst] Add forgotten PNSE and ActiveIssue

May 18, 2021
cd95e8a

[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…

May 18, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
 public partial class HostTests
 {
 [Fact]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
 public async Task StopAsyncWithCancellation()
 {
 var builder = new HostBuilder();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void ChDir()
 {
 var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
 // Can't get current directory on OSX before setting it.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurDir()
 {
 Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down

1 change: 1 addition & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurrentDirectorySet()
 {
 var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/CancelKeyPress.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
 private const int WaitFailTestTimeoutSeconds = 30;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void CanAddAndRemoveHandler()
 {
 ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Color.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void InvalidColors()
 {
 AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
 AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RoundtrippingColor()
 {
 Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RedirectedOutputDoesNotUseAnsiSequences()
 {
 // Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/ConsoleEncoding.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

 [Theory]
 [MemberData(nameof(InputData))]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestEncoding(string inputString)
 {
 TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestValidEncodings()
 {
 Action<Encoding> check = encoding =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ReadAndWrite.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncodingPreamble()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncoding()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
 };

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadAndReadLine()
 {
 TextWriter savedStandardOutput = Console.Out;
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/SetIn.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInThrowsOnNull()
 {
 TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInReadLine()
 {
 const string TextStringFormat = "Test {0}";
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/SyncTextReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
 // NOTE: These tests test the underlying SyncTextReader by
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ThreadSafety.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
 const int NumberOfIterations = 100;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXXCanBeCalledConcurrently()
 {
 Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetStandardXXXCanBeCalledConcurrently()
 {
 TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadMayBeCalledConcurrently()
 {
 const char TestChar = '+';
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Timeout.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_WriteTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_ReadTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_CanTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down

28 changes: 14 additions & 14 deletions
src/libraries/System.Console/tests/WindowAndCursorProps.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferWidth_GetUnix_ReturnsWindowWidth()
 {
 Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferHeight_GetUnix_ReturnsWindowHeight()
 {
 Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowWidth_GetUnix_Success()
 {
 // Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowHeight_GetUnix_Success()
 {
 // Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowWidth_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowHeight_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
 }

 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [InlineData(true)]
 [InlineData(false)]
 public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetCursorPosition_Invoke_Success()
 {
 if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void GetCursorPosition_Invoke_ReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
 public void CursorSize_GetUnix_ReturnsExpected()
 {
 Assert.Equal(100, Console.CursorSize);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip#52859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mdh1418
merged 13 commits into

from

May 19, 2021
 Merged


[MacCatalyst][libraries] Add specific SkipOnPlatform and ActiveIssues instead of test level skip
#52859
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
863699a

[MacCatalyst][libraries] Add System.Console.Tests SkipOnPlatform

May 17, 2021
9871fe4

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests SkipOnP…

May 17, 2021
aa482fc

[MacCatalyst][libraries] Add Microsoft.Extensions.Hosting.Unit.Tests …

May 17, 2021
6c58373

[MacCatalyst][libraries] Add System.Net.NetworkInformation.Functional…

May 17, 2021
bff22a3

[MacCatalyst][libraries] Add System.IO.FileSystems.Tests SkipOnPlatform

May 17, 2021
8e75ea4

[MacCatalyst][libraries] Add Microsoft.VisualBasic.Core.Tests ActiveI…

May 17, 2021
64d012a

[MacCatalyst][libraries] Add System.Diagnostics.Process.Tests ActiveI…

May 17, 2021
c863805

[MacCatalyst][libraries] Add System.Threading.Thread.Tests ActiveIssue

May 17, 2021
6fb59b7

[MacCatalyst][libraries] Add System.IO.FileSystem.Tests ActiveIssue

May 17, 2021
aedde8d

[MacCatalyst][libraries] Add System.Runtime.Extensions.Tests ActiveIssue

May 17, 2021
f684019

[MacCatalyst][libraries] Remove test project level skips

May 17, 2021
671cfb3

[MacCatalyst] Add forgotten PNSE and ActiveIssue

May 18, 2021
cd95e8a

[MacCatalyst][libraries] Coalesce MacCatalyst into iOS tvOS SkipOnPla…

May 18, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Hosting.Tests
 public partial class HostTests
 {
 [Fact]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on iOS or tvOS.")]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")]
 public async Task StopAsyncWithCancellation()
 {
 var builder = new HostBuilder();
Expand Down

2 changes: 2 additions & 0 deletions
src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ protected override void Dispose(bool disposing)
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void ChDir()
 {
 var savedDirectory = System.IO.Directory.GetCurrentDirectory();
Expand DownExpand Up@@ -86,6 +87,7 @@ static string getString(string fileName)
 // Can't get current directory on OSX before setting it.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurDir()
 {
 Assert.Equal(FileSystem.CurDir(), System.IO.Directory.GetCurrentDirectory());
Expand Down

1 change: 1 addition & 0 deletions
...ibraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/FileSystemTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -298,6 +298,7 @@ public void CurrentDirectoryGet()
 // path that followed the symlink.
 [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotOSX))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/50572", TestPlatforms.Android)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/52851", TestPlatforms.MacCatalyst)]
 public void CurrentDirectorySet()
 {
 var SavedCurrentDirectory = System.IO.Directory.GetCurrentDirectory();
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/CancelKeyPress.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,7 @@ public partial class CancelKeyPressTests
 private const int WaitFailTestTimeoutSeconds = 30;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void CanAddAndRemoveHandler()
 {
 ConsoleCancelEventHandler handler = (sender, e) =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Color.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,15 +12,15 @@
public class Color
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void InvalidColors()
 {
 AssertExtensions.Throws<ArgumentException>(null, () => Console.BackgroundColor = (ConsoleColor)42);
 AssertExtensions.Throws<ArgumentException>(null, () => Console.ForegroundColor = (ConsoleColor)42);
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RoundtrippingColor()
 {
 Console.BackgroundColor = Console.BackgroundColor;
Expand DownExpand Up@@ -49,7 +49,7 @@ public static void BackgroundColor_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void RedirectedOutputDoesNotUseAnsiSequences()
 {
 // Make sure that redirecting to a memory stream causes Console not to write out the ANSI sequences
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/ConsoleEncoding.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public static IEnumerable<object[]> InputData()

 [Theory]
 [MemberData(nameof(InputData))]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestEncoding(string inputString)
 {
 TextWriter outConsoleStream = Console.Out;
Expand DownExpand Up@@ -79,7 +79,7 @@ public void TestEncoding(string inputString)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void TestValidEncodings()
 {
 Action<Encoding> check = encoding =>
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ReadAndWrite.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -258,7 +258,7 @@ private static unsafe void ValidateConsoleEncoding(Encoding encoding)
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncodingPreamble()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand All@@ -281,7 +281,7 @@ public static unsafe void OutputEncodingPreamble()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static unsafe void OutputEncoding()
 {
 Encoding curEncoding = Console.OutputEncoding;
Expand DownExpand Up@@ -349,7 +349,7 @@ public static void InputEncoding_Getter_Throws_PlatformNotSupportedException()
 };

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadAndReadLine()
 {
 TextWriter savedStandardOutput = Console.Out;
Expand Down

4 changes: 2 additions & 2 deletions
src/libraries/System.Console/tests/SetIn.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class SetIn
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInThrowsOnNull()
 {
 TextReader savedIn = Console.In;
Expand All@@ -26,7 +26,7 @@ public static void SetInThrowsOnNull()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetInReadLine()
 {
 const string TextStringFormat = "Test {0}";
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Console/tests/SyncTextReader.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
using System.Text;
using Xunit;

[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
[SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
public class SyncTextReader
{
 // NOTE: These tests test the underlying SyncTextReader by
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/ThreadSafety.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ public class ThreadSafety
 const int NumberOfIterations = 100;

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXXCanBeCalledConcurrently()
 {
 Parallel.For(0, NumberOfIterations, i =>
Expand DownExpand Up@@ -41,7 +41,7 @@ public static void OpenStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetStandardXXXCanBeCalledConcurrently()
 {
 TextReader savedStandardInput = Console.In;
Expand DownExpand Up@@ -84,7 +84,7 @@ public static void SetStandardXXXCanBeCalledConcurrently()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ReadMayBeCalledConcurrently()
 {
 const char TestChar = '+';
Expand Down

6 changes: 3 additions & 3 deletions
src/libraries/System.Console/tests/Timeout.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class TimeOut
{
 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_WriteTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -27,7 +27,7 @@ public static void OpenStandardXXX_WriteTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_ReadTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand All@@ -43,7 +43,7 @@ public static void OpenStandardXXX_ReadTimeOut()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void OpenStandardXXX_CanTimeOut()
 {
 using (Stream standardOut = Console.OpenStandardOutput(), standardIn = Console.OpenStandardInput(), standardError = Console.OpenStandardError())
Expand Down

28 changes: 14 additions & 14 deletions
src/libraries/System.Console/tests/WindowAndCursorProps.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
public class WindowAndCursorProps
{
 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferWidth_GetUnix_ReturnsWindowWidth()
 {
 Assert.Equal(Console.WindowWidth, Console.BufferWidth);
Expand All@@ -25,7 +25,7 @@ public static void BufferWidth_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void BufferHeight_GetUnix_ReturnsWindowHeight()
 {
 Assert.Equal(Console.WindowHeight, Console.BufferHeight);
Expand DownExpand Up@@ -62,7 +62,7 @@ public static void WindowWidth_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowWidth_GetUnix_Success()
 {
 // Validate that Console.WindowWidth returns some value in a non-redirected o/p.
Expand DownExpand Up@@ -94,7 +94,7 @@ public static void WindowHeight_SetInvalid_ThrowsArgumentOutOfRangeException(int
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void WindowHeight_GetUnix_Success()
 {
 // Validate that Console.WindowHeight returns some value in a non-redirected o/p.
Expand All@@ -110,15 +110,15 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException()
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowWidth_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 Helpers.RunInRedirectedOutput((data) => Assert.Equal(Console.WindowWidth, Console.LargestWindowWidth));
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 public static void LargestWindowHeight_UnixGet_ReturnsExpected()
 {
 Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));
Expand DownExpand Up@@ -191,7 +191,7 @@ public static void CursorVisible_GetUnix_ThrowsPlatformNotSupportedException()
 }

 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix
 [InlineData(true)]
 [InlineData(false)]
 public static void CursorVisible_SetUnixRedirected_Nop(bool value)
Expand DownExpand Up@@ -337,7 +337,7 @@ public static void SetCursorPosition_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void SetCursorPosition_Invoke_Success()
 {
 if (!OperatingSystem.IsWindows() || (!Console.IsInputRedirected && !Console.IsOutputRedirected))
Expand All@@ -364,7 +364,7 @@ public void SetCursorPosition_InvalidPosition_ThrowsArgumentOutOfRangeException(
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public static void GetCursorPosition_Invoke_ReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -391,7 +391,7 @@ public static void GetCursorPosition_Invoke_ReturnsExpected()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -413,7 +413,7 @@ public void CursorLeft_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorLeft_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows && Console.IsOutputRedirected)
Expand All@@ -434,7 +434,7 @@ public void CursorLeft_Setter_Throws_PlatformNotSupportedException()
 }

 [Fact]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_Set_GetReturnsExpected()
 {
 if (!Console.IsInputRedirected && !Console.IsOutputRedirected)
Expand All@@ -456,7 +456,7 @@ public void CursorTop_Set_GetReturnsExpected()
 [Theory]
 [InlineData(-1)]
 [InlineData(short.MaxValue + 1)]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Not supported on Browser, iOS, or tvOS.")]
 [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")]
 public void CursorTop_SetInvalid_ThrowsArgumentOutOfRangeException(int value)
 {
 if (PlatformDetection.IsWindows & Console.IsOutputRedirected)
Expand DownExpand Up@@ -505,7 +505,7 @@ public void CursorSize_SetInvalidValue_ThrowsArgumentOutOfRangeException(int val
 }

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)]
 public void CursorSize_GetUnix_ReturnsExpected()
 {
 Assert.Equal(100, Console.CursorSize);
Expand Down
Loading