') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Skip flakey mobile library test crashes by mdh1418 · Pull Request #52931 · dotnet/runtime · GitHub
Skip to content

Skip flakey mobile library test crashes - #52931

Merged
mdh1418 merged 17 commits into
dotnet:mainfrom
mdh1418:skip_flakey_mobile_library_test_crashes
May 21, 2021
Merged

Skip flakey mobile library test crashes#52931
mdh1418 merged 17 commits into
dotnet:mainfrom
mdh1418:skip_flakey_mobile_library_test_crashes

Conversation

@mdh1418

@mdh1418mdh1418 commented May 18, 2021•
edited
Loading

Copy link
Copy Markdown
Member

The work done in #50800 and #51491 addressed the majority of test failures and crashes in Android, iOS, tvOS, and MacCatalyst. Addressing flakey tests failures and flakey test suite crashes (where the suite crashes in CI but runs and passes locally) is an ongoing process.

In this dropbox paper, many lanes on the runtime-staging pipeline are monitored to see which test suites fail.

This PR adds the failing test suites to test exclusions in tests.proj and will fall under the issue #52615.

@ghostghost added the area-Meta label May 18, 2021
@mdh1418
mdh1418force-pushed the skip_flakey_mobile_library_test_crashes branch from e9ea318 to 648c986CompareMay 19, 2021 15:47
@mdh1418
mdh1418 marked this pull request as ready for review May 19, 2021 19:04
akoeplinger
akoeplinger approved these changes May 19, 2021
View reviewed changes
Comment threadsrc/libraries/tests.proj Outdated
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetOS)' == 'Android' and '$(TargetArchitecture)' == 'x64'">

@akoeplingerakoeplingerMay 19, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this and other Android ItemGroups should have the RunDisabledAndroidTests condition so we can still run them (btw. do we have a draft PR which runs all the tests somewhere?)

@mdh1418mdh1418May 19, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'll put up a draft PR to run all of these tests as well.

@steveisoksteveisokMay 19, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to bump this #50095

akoeplinger
akoeplinger reviewed May 21, 2021
View reviewed changes
Comment threadsrc/libraries/tests.proj Outdated
@mdh1418

mdh1418 commented May 21, 2021

Copy link
Copy Markdown
MemberAuthor

The test suites failing on runtime-staging both here and in #50095 are all related to Package Installation Error

@mdh1418
mdh1418 merged commit 5c656ca into dotnet:mainMay 21, 2021
@mdh1418
mdh1418 deleted the skip_flakey_mobile_library_test_crashes branch May 21, 2021 19:18
@runfoapprunfoappBot mentioned this pull request Jun 2, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@directhexdirecthexAwaiting requested review from directhex
@radicalradicalAwaiting requested review from radical
@steveisoksteveisokAwaiting requested review from steveisok

Assignees

No one assigned

Labels

area-Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdh1418@steveisok@akoeplinger