Build support for s390x: PAL layer by uweigand · Pull Request #53287 · dotnet/runtime

uweigand · 2021-05-26T15:01:58Z

Add PAL implementation for Linux on s390x
Define BIGENDIAN on s390x when compiling coreclr
Do not run HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES cmake test when
cross-compiling

Note to reviewers:

The primary intent of this patch is to enable building ilasm/ildasm on s390x (even though we do not support coreclr VM/JIT)
However, the PAL support provided here is still complete and passes all paltests
As there is no Windows on s390x, there is no pre-existing CONTEXT structure, so I made one up. In particular, the CONTEXT_S390X define re-uses the same value as CONTEXT_AMD64. Let me know if I should instead choose another bit.
Similarly, there is no s390x PE file format, so IMAGE_FILE_MACHINE_NATIVE is defined to IMAGE_FILE_MACHINE_UNKNOWN

AaronRobinsonMSFT · 2021-05-26T21:47:22Z

janvorli · 2021-05-26T21:57:36Z

This is never executed while cross compiling, cmake skips all check_*_source_runs during cross compilation. The HAVE_xxx values for cross compilation are taken from the tryrun.cmake file. So this change should not be needed, but you'll need to update the eng/native/tryrun.cmake

Ah, I missed that, sorry. Patch updated accordingly.

uweigand · 2021-06-07T17:00:31Z

Ping? Anything else that needs to be addressed?

janvorli · 2021-06-07T17:51:42Z

I have just noticed this #if has a wrong condition (event before your change). Since you are touching this code, could you please fix it? It should be
#if (HAVE_GREGSET_T || HAVE___GREGSET_T) && !defined(HOST_S390X)
Actually, the related #endif comment need to be updated to match your change (and this fix) to
#endif // HAVE_GREGSET_T || HAVE___GREGSET_T || !HOST_S390X

janvorli · 2021-06-07T17:52:39Z

Can you please update the matching @endif comment?

janvorli · 2021-06-07T18:24:26Z

A nit - in the #endif comments, the convention we use is just !HOST_S390X instead of !defined(HOST_S390X)

Ah, I see. Updated.

* Add PAL implementation for Linux on s390x * Define BIGENDIAN on s390x when compiling coreclr * Provide a default HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE value in eng/native/tryrun.cmake

janvorli

LGTM, thank you!

ghost · 2021-06-07T18:59:22Z

Hello @janvorli!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

uweigand · 2021-06-07T19:05:18Z

Thanks for the review! Would you mind having a look the two related PRs as well:
#53286
#53289
Both are required to get the PAL to actually build on s390x.

ghost added the area-PAL-coreclr only for closed issues label May 26, 2021

janvorli reviewed May 26, 2021
View reviewed changes

runfoappBot mentioned this pull request May 27, 2021
FileSystemWatcher_DirectorySymbolicLink_TargetsFile_Fails #53366
Open

janvorli reviewed Jun 7, 2021
View reviewed changes

Build support for s390x: PAL layer
4638924
* Add PAL implementation for Linux on s390x * Define BIGENDIAN on s390x when compiling coreclr * Provide a default HAVE_FUNCTIONAL_PTHREAD_ROBUST_MUTEXES_EXITCODE value in eng/native/tryrun.cmake

janvorli approved these changes Jun 7, 2021
View reviewed changes

janvorli added the auto-merge label Jun 7, 2021

marek-safar merged commit 5d6278a into dotnet:mainJun 8, 2021

ghost locked as resolved and limited conversation to collaborators Jul 8, 2021

uweigand deleted the s390x-clr-pal branch July 14, 2021 22:32

Uh oh!

Conversation

uweigand commented May 26, 2021

Uh oh!

AaronRobinsonMSFT commented May 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

uweigand commented Jun 7, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janvorli left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jun 7, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

uweigand commented Jun 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.