Skip to content

Disable diagnostics support as default in Mono Android sample app. - #53716

Merged
lateralusX merged 1 commit into
dotnet:mainfrom
lateralusX:lateralusX/remove-runtime-components-in-sample
Jun 6, 2021
Merged

Disable diagnostics support as default in Mono Android sample app.#53716
lateralusX merged 1 commit into
dotnet:mainfrom
lateralusX:lateralusX/remove-runtime-components-in-sample

Conversation

@lateralusX

@lateralusXlateralusX commented Jun 4, 2021

Copy link
Copy Markdown
Member

No description provided.

@ghostghost added the area-Build-mono label Jun 4, 2021
@lateralusXlateralusX changed the title Disable diagnostics support as default in Android sample app.Disable diagnostics support as default in Mono Android sample app.Jun 4, 2021
@marek-safar

marek-safar commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

@steveisok can we stop messing up with the sample and do the work property as independent units that we can regularly validate ?

@lateralusX

lateralusX commented Jun 4, 2021

Copy link
Copy Markdown
MemberAuthor

The work unit was adding ability to run diagnostics with the sample apps, this issue was a regression from that work, but it actually exposed another issue with our Android release shared library builds not being stripped, dramatically increase the size of sample app when using dynamic linked mono runtime (as used by workloads like XA). Maybe we should have a test running on PR's monitor size of sample apps?

@lateralusX

lateralusX commented Jun 4, 2021

Copy link
Copy Markdown
MemberAuthor

Size increase is mainly caused by this, #53722, will temporary remove dynamic linking in sample app on Android until we strip shared libraries as part of runtime build.

@lateralusX

lateralusX commented Jun 4, 2021

Copy link
Copy Markdown
MemberAuthor

Switching back to static linking will take APK size of sample app on Android back to 2.6 MB.

lambdageek
lambdageek reviewed Jun 4, 2021
View reviewed changes
Comment threadsrc/mono/sample/Android/AndroidSampleApp.csproj Outdated
@lateralusX
lateralusXforce-pushed the lateralusX/remove-runtime-components-in-sample branch from f884688 to 8f3656cCompareJune 4, 2021 14:44
@lateralusX

lateralusX commented Jun 4, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Keeping dynamic linking on Android since the should be the default, size will be adjusted once #53240 gets merged.

@lateralusX
lateralusX merged commit a9d2f03 into dotnet:mainJun 6, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jul 6, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok left review comments
@lambdageeklambdageeklambdageek left review comments
@SamMonoRTSamMonoRTSamMonoRT approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lateralusX@marek-safar@steveisok@lambdageek@SamMonoRT