Skip to content

Apply BuiltInComInterop feature switch to managed code - #54056

Merged
eerhardt merged 3 commits into
dotnet:mainfrom
marek-safar:com2
Nov 18, 2021
Merged

Apply BuiltInComInterop feature switch to managed code#54056
eerhardt merged 3 commits into
dotnet:mainfrom
marek-safar:com2

Conversation

@marek-safar

@marek-safarmarek-safar commented Jun 11, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up on #43501

@ghost

ghost commented Jun 11, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@marek-safar
marek-safar marked this pull request as ready for review June 11, 2021 11:44
@ghost

ghost commented Jun 11, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up on #43501

Author:marek-safar
Assignees:-
Labels:

area-System.Runtime

Milestone:-

MichalStrehovsky
MichalStrehovsky reviewed Jun 12, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.Shared.xml Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.Shared.xml Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.Shared.xml Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.Shared.xml Outdated
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Jun 12, 2021

Copy link
Copy Markdown
Member

/cc @jkoritzinsky@elinor-fung

@AaronRobinsonMSFTAaronRobinsonMSFT mentioned this pull request Jun 29, 2021
Merged
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jul 1, 2021
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the suggestion from @LakshanF in #54056 (comment) done prior to check-in. After that looks good.

@karelzkarelz mentioned this pull request Jul 28, 2021
Closed
@eerhardt

eerhardt commented Nov 4, 2021

Copy link
Copy Markdown
Member

I see there are conflicts to resolve. @marek-safar - do you want me to take over this PR and push it forward?

@marek-safar

marek-safar commented Nov 10, 2021

Copy link
Copy Markdown
ContributorAuthor

@eerhardt please go ahead and finish this.

@eerhardt

eerhardt commented Nov 11, 2021

Copy link
Copy Markdown
Member

@LakshanF - do those BuiltInComInterop.IsSupported"), false tests get run in CI now? Or is there a way for me to do that run on this PR?

@eerhardt

eerhardt commented Nov 18, 2021

Copy link
Copy Markdown
Member

do those BuiltInComInterop.IsSupported"), false tests get run in CI now? Or is there a way for me to do that run on this PR?

I chatted offline to @LakshanF about running the above tests. We decided that running the tests with BuiltInComInterop=false set inside coreclr wouldn't be beneficial with this change. The reason being that the changes here only affected trimmed/linked managed code. Since those tests wouldn't actually trim the managed code, these changes won't be affected.

With that, I believe this change is ready to merge. @AaronRobinsonMSFT@MichalStrehovsky - Can you give this one more quick check before I merge it?

@eerhardt
eerhardt merged commit 8ae135a into dotnet:mainNov 18, 2021
@MichalStrehovskyMichalStrehovsky mentioned this pull request Nov 20, 2021
Merged
@eerhardteerhardt mentioned this pull request Nov 23, 2021
Merged
vitek-karas added a commit to vitek-karas/runtime that referenced this pull request Nov 24, 2021
@vitek-karas
Suppress trim warning caused by recent attribute removal changes
fbadd4f
This fixes a new warning generated by trimming some apps which was introduced in dotnet#54056.
The `ComVisibleAttribute` in this case is referenced, but if it's removed it doesn't change functionality in any way.
@vitek-karasvitek-karas mentioned this pull request Nov 24, 2021
Merged
vitek-karas added a commit that referenced this pull request Nov 26, 2021
@vitek-karas
Suppress trim warning caused by recent attribute removal changes (#62023
90b8c70
)
This fixes a new warning generated by trimming some apps which was introduced in #54056.
The `ComVisibleAttribute` in this case is referenced, but if it's removed it doesn't change functionality in any way.
This was referenced Nov 29, 2021
Closed
Closed
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
+1 more reviewer
@LakshanFLakshanFLakshanF left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtime.InteropServices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marek-safar@AaronRobinsonMSFT@eerhardt@LakshanF@MichalStrehovsky