Add write-raw APIs to Utf8JsonWriter by layomia · Pull Request #54254 · dotnet/runtime

layomia · 2021-06-15T23:42:52Z

ghost · 2021-06-15T23:42:56Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2021-06-15T23:42:58Z

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #1784.

FYI @ahsonkhan

Author:	layomia
Assignees:	layomia
Labels:	`area-System.Text.Json`
Milestone:	6.0.0

ahsonkhan

JsonWriterOptions.SkipValidation needs to be honored, particularly when it is set to false.

davidfowl · 2021-06-16T08:18:43Z

I used a similar API in JSON.NET ~8 years ago and it caused my first security bug 🤣

layomia · 2021-06-23T19:37:07Z

@ahsonkhan thanks for reviewing! Will address the feedback shortly.

steveharter

LGTM; misc XLM doc\test feedback.

steveharter · 2021-07-02T14:40:53Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2021-07-02T14:41:09Z

Azure Pipelines successfully started running 1 pipeline(s).

@ahsonkhan

I've addressed @ahsonkhan's feedback.

ghost · 2021-07-02T16:49:35Z

Hello @layomia!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Add write-raw APIs to Utf8JsonWriter
2b9a5ec

layomia added the area-System.Text.Json label Jun 15, 2021

layomia added this to the 6.0.0 milestone Jun 15, 2021

layomia requested review from eiriktsarpalis and steveharter June 15, 2021 23:42

layomia self-assigned this Jun 15, 2021

layomia requested a review from jozkee as a code owner June 15, 2021 23:42

ghost added the new-api-needs-documentation label Jun 15, 2021

ahsonkhan reviewed Jun 15, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/System.Text.Json.Tests.csproj Outdated

ahsonkhan reviewed Jun 15, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 15, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs

ahsonkhan reviewed Jun 15, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan previously requested changes Jun 16, 2021
View reviewed changes

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.WriteRaw.cs

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.WriteRaw.cs

ahsonkhan reviewed Jun 16, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.WriteRaw.cs Outdated

layomia force-pushed the WriteRaw branch from f11a2ce to bd4fb4dCompare June 30, 2021 01:46

Address review feedback
3ac5592

layomia force-pushed the WriteRaw branch from bd4fb4d to 3ac5592Compare June 30, 2021 02:02

ahsonkhan reviewed Jun 30, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 30, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 30, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs

ahsonkhan reviewed Jun 30, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 30, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

ahsonkhan reviewed Jun 30, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.WriteRaw.cs Outdated

layomia mentioned this pull request Jul 1, 2021
System.Text.Json: Add TimeSpanConverter #54186
Merged

Address review feedback
e47ee37

ahsonkhan self-requested a review July 1, 2021 22:46

steveharter approved these changes Jul 2, 2021
View reviewed changes

dotnet deleted a comment from azure-pipelinesBotJul 2, 2021

Address review feedback
eea5f1b

layomia added the auto-merge label Jul 2, 2021

Make long-running tests outerloop
e158057

layomia commented Jul 3, 2021
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Raw.cs Outdated

Fix call to core logic
86584f0

ghost merged commit ad51267 into dotnet:mainJul 3, 2021

layomia mentioned this pull request Jul 19, 2021
Reduce allocations in VersionConverter #55564
Merged

This was referenced Jul 28, 2021
System.Net.Security test run killed on Mono Linux #56478
Closed
[WinHttpHandler] Long running test: ResponseHeadersRead_SynchronizationContextNotUsedByHandler on Win7/Win8 #54034
Closed

ghost locked as resolved and limited conversation to collaborators Aug 2, 2021

This pull request was closed.

Uh oh!

Conversation

layomia commented Jun 15, 2021

Uh oh!

ghost commented Jun 15, 2021

Uh oh!

ghost commented Jun 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahsonkhan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidfowl commented Jun 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

layomia commented Jun 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveharter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveharter commented Jul 2, 2021

Uh oh!

azure-pipelinesBot commented Jul 2, 2021

Uh oh!

ghost commented Jul 2, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davidfowl commented Jun 16, 2021•
edited
Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.