Skip to content

Enable more LDAP TLS tests on linux - #54377

Merged
krwq merged 2 commits into
dotnet:mainfrom
iinuwa:fix/enable-more-ldap-tls-tests-on-linux
Jul 1, 2021
Merged

Enable more LDAP TLS tests on linux#54377
krwq merged 2 commits into
dotnet:mainfrom
iinuwa:fix/enable-more-ldap-tls-tests-on-linux

Conversation

@iinuwa

@iinuwaiinuwa commented Jun 17, 2021

Copy link
Copy Markdown
Contributor

As a follow up to #52904, this removes the SupportedOsPlatform("windows") attribute from LdapSessionOptions.SecureSocketLayer, which was causing weird Intellisense issues in VS Code on Linux.

It also enables some tests for LdapSessionOptions.SecureSocketsLayer for Linux that were missed in the previous PR.

@iinuwa

iinuwa commented Jun 17, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I have a question about line 62 in LdapSessionTests.cs: I would enable that test, but it seems that it should be Assert.Equal(options.SecureSocketsLayer, value) rather than Assert.False(options.SecureSocketsLayer)... unless it's supposed to be testing that you can't update that property after assigning the LdapSessionOptions it to a connection.

@iinuwa

iinuwa commented Jun 30, 2021

Copy link
Copy Markdown
ContributorAuthor

@krwq, thanks for reviewing! I see that the tests are all passing now; is there anything else I need to do for this to be merged?

@krwq
krwq merged commit 784ddff into dotnet:mainJul 1, 2021
@karelzkarelz mentioned this pull request Jul 28, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwqkrwqkrwq approved these changes

Assignees

No one assigned

Labels

area-System.DirectoryServices

Projects

No open projects
Triage POD for Reflection, META, etc.
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iinuwa@krwq