Uh oh!
There was an error while loading. Please reload this page.
Enable win registry install location for all architectures - #54698
Conversation
ghost
commented
Jun 24, 2021
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsFollow-up of #53763 Enable the multi-architecture install locations on Windows Registry. The registration mechanism works the same way, we are only lifting the requirement of having to be running on x64/x86 to use the registry.
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Given that you made basically no changes to existing tests - does it mean that we don't run the tests on Windows ARM32 or ARM64 at all?
Or does it mean that we didn't have any tests validating the current behavior?
There was a problem hiding this comment.
Apparently the host tests don't run on arm or arm64 at all (Windows or not):
runtime/eng/pipelines/installer/jobs/base-job.yml
Lines 63 to 69 in fc4a427
There was a problem hiding this comment.
I'll enable them on a separate PR (which should be merged before this one) -- curious if this will cause existing tests to fail.
There was a problem hiding this comment.
Fair warning - I expect enabling them may be a bit involved. I think the main reason the arm/arm64 tests are currently skipped is that the hosting tests haven't been set up to send tests to helix, so they just run on the build machine (which works fine for x64/x86).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Apparently the host tests don't run on arm or arm64 at all (Windows or not):
runtime/eng/pipelines/installer/jobs/base-job.yml
Lines 63 to 69 in fc4a427
Uh oh!
There was an error while loading. Please reload this page.
vitek-karas
left a comment
There was a problem hiding this comment.
I think we should be able to merge this - assuming we did some manual testing of it.
agocke
commented
Aug 19, 2021
@mateoatr Is this ready to go? |
mateoatr
commented
Aug 20, 2021
Yup. I did some local validation on a win-arm64 machine: arm apps work as expected, running an x86 apphost works fine as well. The |
agocke
commented
Aug 20, 2021
Do we still need to swap the DOTNET_ROOT ordering, or is that already done? |
mateoatr
commented
Aug 20, 2021
Nope. It's already done -- I was having issues with |
agocke
commented
Aug 20, 2021
/backport to release/6.0-rc1 |
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1151559541 |
Follow-up of #53763
Enable the multi-architecture install locations on Windows Registry. The registration mechanism works the same way, we are only lifting the requirement of having to be running on x64/x86 to use the registry.