Skip to content

Add nullable annotations to System.ComponentModel.TypeConverter - #54961

Merged
krwq merged 4 commits into
dotnet:mainfrom
krwq:nullable-type-converter
Jul 8, 2021
Merged

Add nullable annotations to System.ComponentModel.TypeConverter#54961
krwq merged 4 commits into
dotnet:mainfrom
krwq:nullable-type-converter

Conversation

@krwq

@krwqkrwq commented Jun 30, 2021

Copy link
Copy Markdown
Member

cc: @dotnet/nullablefc

@krwq
krwq requested a review from stephentoubJune 30, 2021 14:12
@ghost

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

cc: @dotnet/nullablefc

Author:krwq
Assignees:-
Labels:

area-System.ComponentModel, new-api-needs-documentation

Milestone:-

@krwq
krwqforce-pushed the nullable-type-converter branch from 0eca142 to 0c041e7CompareJuly 1, 2021 09:43
@krwq

krwq commented Jul 1, 2021

Copy link
Copy Markdown
MemberAuthor

I've rebased to fix the merge conflicts - note they didn't affect TypeConverter (except comment changes) - just System.Data.Common

@stephentoub

Copy link
Copy Markdown
Member

This is daunting ;-)
image

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only spot checked, but overall it LGTM (left a few comments about the TODO-NULLABLEs throughout).

@dotnetdotnet deleted a comment from azure-pipelinesBotJul 7, 2021
@dotnetdotnet deleted a comment from azure-pipelinesBotJul 7, 2021
@krwqkrwq closed this Jul 7, 2021
@krwqkrwq reopened this Jul 7, 2021
@krwq
krwq merged commit 885296a into dotnet:mainJul 8, 2021
@ghostghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@krwq@stephentoub@roji@safern