Uh oh!
There was an error while loading. Please reload this page.
Add nullable annotations to System.ComponentModel.TypeConverter - #54961
Conversation
ghost
commented
Jun 30, 2021
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
commented
Jun 30, 2021
Tagging subscribers to this area: @safern Issue Detailscc: @dotnet/nullablefc
|
0eca142 to
0c041e7Comparekrwq
commented
Jul 1, 2021
I've rebased to fix the merge conflicts - note they didn't affect TypeConverter (except comment changes) - just System.Data.Common |
stephentoub
commented
Jul 1, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stephentoub
left a comment
There was a problem hiding this comment.
I only spot checked, but overall it LGTM (left a few comments about the TODO-NULLABLEs throughout).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.

cc: @dotnet/nullablefc